From: Max Nikulin <email@example.com> To: firstname.lastname@example.org Subject: Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend Date: Wed, 17 Nov 2021 23:12:02 +0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 15/11/2021 23:05, Daniel Kraus wrote: > Max Nikulin writes: > > Attached is the patch changed the logic to use a temp file with org-babel-eval. Thank you for contribution. I do not have strong objection any more. I am not familiar with babel internals, so I leave further discussion to maintainers. If you have not signed copyright assignment yet, likely you should do it to proceed (I am unsure concerning precise rules concerning line counting). See https://orgmode.org/contribute.html and https://orgmode.org/worg/org-contribute.html for details. > Somehow it doesn't feel too great to create unnecessary temp files > but I looked how other babel backends do it and e.g. ob-js and ob-haskell > use the same logic. Code fragment might be huge enough to exceed limit on arguments length, so I think that file is safer. Some interpreters and compilers generates more meaningful errors and stacktraces when act on a file. Another option is to feed content to process standard input. With `call-process' or an related command it should be possible to implement any variant, including raw argument without intermediate shell pass. See info "(elisp) Synchronous Processes" or https://www.gnu.org/software/emacs/manual/html_node/elisp/Synchronous-Processes.html > + (with-temp-file script-file > + (insert expanded)) > + (org-babel-eval > + (format "%s %s" bb (org-babel-process-file-name script-file)) > + ""))) Since other babel packages use the same approach, I will not argue. By the way, isn't second argument of `org-babel-eval' intended for code that may be executed without a temporary file? Some babel languages support sessions. I have no idea if it is applicable to babashka.
next prev parent reply other threads:[~2021-11-17 16:21 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-14 15:28 Daniel Kraus 2021-11-14 16:25 ` Max Nikulin 2021-11-14 16:30 ` Daniel Kraus 2021-11-15 14:33 ` Max Nikulin 2021-11-15 16:05 ` Daniel Kraus 2021-11-17 16:12 ` Max Nikulin [this message] 2021-11-20 10:18 ` Daniel Kraus 2021-12-22 22:34 ` Daniel Kraus 2022-01-31 7:58 ` Daniel Kraus 2022-02-02 15:58 ` Max Nikulin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com' \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).