From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uFlwAC8dX2HUVwAAgWs5BA (envelope-from ) for ; Thu, 07 Oct 2021 18:15:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 8AKjNy4dX2GGCgAA1q6Kng (envelope-from ) for ; Thu, 07 Oct 2021 16:15:42 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 68EE037E49 for ; Thu, 7 Oct 2021 18:15:42 +0200 (CEST) Received: from localhost ([::1]:60200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYW3Z-0001IH-EA for larch@yhetil.org; Thu, 07 Oct 2021 12:15:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYW2p-0001I2-2J for emacs-orgmode@gnu.org; Thu, 07 Oct 2021 12:14:55 -0400 Received: from ciao.gmane.io ([116.202.254.214]:57038) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYW2n-0007Ku-Lz for emacs-orgmode@gnu.org; Thu, 07 Oct 2021 12:14:54 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mYW2l-0008rZ-2l for emacs-orgmode@gnu.org; Thu, 07 Oct 2021 18:14:51 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken Date: Thu, 7 Oct 2021 23:14:45 +0700 Message-ID: References: <87mtnovv7f.fsf@alphapapa.net> <87h7dvy70t.fsf@localhost> <87ee8zxwic.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <87ee8zxwic.fsf@localhost> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-1.964, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633623342; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=asNxikOlyyglTc4llWPTD2nABWigF667SuzLZFxjLyM=; b=Jq37Q/9Td0oXRlpLgMMm5KRS5eCBAv5j4+GeGe3v+683s+FN3q/+IEUjKKBHviZ68hl3hm CYHjDkWNmt7ZOzP0ZVML900cef9cm8lzKKYqLGLCr7GaQUcMRI3vdfDWN26uxogoYiIzV5 ajmpoBfKofJvYCz3BmghPytLb1+iomC5WcdXurJS4rFS5z+39zMgh/PrZEc5gXacxjsZtc Pb1/BZ9yeC1wOYIfU7ZquKRbU1zvXOn9MdvV8CAt4sekxEb1zm9Qp7zmKEcUK1QfEGsPMd aWvDnh5oC7riDQExD5bAxvYLqUfBwaBdXhUIKi4OvCnu60rf7AzE1g0S7gUSmQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633623342; a=rsa-sha256; cv=none; b=elMpQyx2N2j8irdthhMdEjnk3LfC2+keWAOEQhnNcuEsIU+rMWVUqqipES1jgr67avFRgO 6qU1IZtfM8/e/It7iU0q0lLICIElYbXxL1+R+Z+ZZP88VOtv8BLkN8pC4VNGoBPz6UuD9b zq8c41L/5qAX8G1p6M7qAr3rLAhy2ZgKJCtQEu3EwaoSjMsmu3NBc8ZUTafU1C2D9qv1RI FqZSRfHiRAQuvE/aHHKchsUUHlYvqwhp7laSpti6o4XY/mqGoOqusLlUC4E0RoSWVRkVfN 9qFV84TNImyy/H7CEvaHULXhi4iu+8tgk54dtK9XnshfZYihGK8+FUz5XwpvWw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -0.32 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 68EE037E49 X-Spam-Score: -0.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: kCShJERZ1Nkz On 05/10/2021 23:32, Ihor Radchenko wrote: > Max Nikulin writes: > > I tried come up with the reason why org-no-popup was used in the initial > implementation. I think, the reason is avoiding situation like what you > may see after running > (let ((pop-up-frames t)) (funcall-interactively #'org-goto)) > So, removing the macro completely is not a good idea. > > I have updated the patch that should work without dropping the macro. > See the attached. Thank you, Ihor. Your updated patch works in default configuration (-Q). I am not familiar with knobs of `display-buffer' function so I have no idea if someone may complain that such variant overrides his setup or works incorrectly with his preferences.