emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Fix some typos
@ 2021-09-16 21:40 Stefan Kangas
  2021-09-17  9:03 ` Timothy
  0 siblings, 1 reply; 16+ messages in thread
From: Stefan Kangas @ 2021-09-16 21:40 UTC (permalink / raw)
  To: Org-mode

[-- Attachment #1: Type: text/plain, Size: 80 bytes --]

Please find attached another clean-up patch that fixes a small number of
typos.

[-- Attachment #2: 0001-Fix-some-typos.patch --]
[-- Type: text/x-diff, Size: 4487 bytes --]

From 2619a525d025a8d4359cff440264c1fd3e9581c8 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefan@marxist.se>
Date: Thu, 16 Sep 2021 21:58:35 +0200
Subject: [PATCH] ; Fix some typos

---
 doc/org-manual.org | 4 ++--
 etc/ORG-NEWS       | 2 +-
 lisp/ob-java.el    | 2 +-
 lisp/org-plot.el   | 6 +++---
 lisp/org.el        | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/doc/org-manual.org b/doc/org-manual.org
index 61b743346..249a2f7d9 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -13880,7 +13880,7 @@ The LaTeX export back-end converts horizontal rules by the specified
 
 The LaTeX export back-end accepts four attributes for verse blocks:
 =:lines=, =:center=, =:versewidth= and =:latexcode=. The three first
-require the external LaTeX package =verse.sty=, wich is an extension
+require the external LaTeX package =verse.sty=, which is an extension
 of the standard LaTeX environment. The purpose of these attributes is
 explained below.
 
@@ -13904,7 +13904,7 @@ A complete example with Shakespeare's first sonnet:
 From fairest creatures we desire increase,
 That thereby beauty’s rose might never die,
 But as the riper should by time decrease,
-His tender heir mught bear his memeory:
+His tender heir mught bear his memory:
 But thou, contracted to thine own bright eyes,
 Feed’st thy light’st flame with self-substantial fuel,
 Making a famine where abundance lies,
diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS
index 83a67da96..ad6cfa3f7 100644
--- a/etc/ORG-NEWS
+++ b/etc/ORG-NEWS
@@ -253,7 +253,7 @@ that Org mode configures LaTeX to process any new float type.
 
 The LaTeX export back-end accepts four attributes for verse blocks:
 =:lines=, =:center=, =:versewidth= and =:latexcode=. The three first
-require the external LaTeX package =verse.sty=, wich is an extension
+require the external LaTeX package =verse.sty=, which is an extension
 of the standard LaTeX environment. The purpose of these attributes is
 explained below.
 
diff --git a/lisp/ob-java.el b/lisp/ob-java.el
index 54d909061..c93c65b7f 100644
--- a/lisp/ob-java.el
+++ b/lisp/ob-java.el
@@ -472,7 +472,7 @@ If RESULT-TYPE equals `output' then return standard output as a
 string.  If RESULT-TYPE equals `value' then return the value
 returned by the source block, as elisp.
 
-RESULT-PARAMS input params used to format the reponse.
+RESULT-PARAMS input params used to format the response.
 
 RESULT-FILE filename of the tempfile to store the returned value in
 for `value' RESULT-TYPE.  Not used for `output' RESULT-TYPE."
diff --git a/lisp/org-plot.el b/lisp/org-plot.el
index 0e5032b48..be599b02d 100644
--- a/lisp/org-plot.el
+++ b/lisp/org-plot.el
@@ -230,7 +230,7 @@ If HARD-MIN and HARD-MAX can be used to fix the ends of the axis."
 
 (defun org--plot/nice-frequency-pick (frequencies)
   "From a list of FREQUENCIES, try to sensibly pick a sample of the most frequent."
-  ;; TODO this mosly works decently, but counld do with some tweaking to work more consistently.
+  ;; TODO this mosly works decently, but could do with some tweaking to work more consistently.
   (cl-case (length frequencies)
     (1 (list (car (nth 0 frequencies))))
     (2 (if (<= 3 (/ (cdr (nth 0 frequencies))
@@ -354,7 +354,7 @@ the argument, and must return a string to be used."
     (radar :plot-func
 	   (lambda (table _data-file _num-cols params plot-str)
 	     (list (org--plot/radar table params)))))
-  "List of plists describing the avalible plot types.
+  "List of plists describing the available plot types.
 The car is the type name, and the property :plot-func must be
 set.  The value of :plot-func is a lambda which yields plot-lines
 \(a list of strings) as the cdr.
@@ -405,7 +405,7 @@ set angles degree
 set key bmargin center horizontal
 unset border
 
-# Load data and settup
+# Load data and setup
 load \"%s\"
 
 # General settings
diff --git a/lisp/org.el b/lisp/org.el
index c265a34a6..8b9d57157 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -8857,7 +8857,7 @@ If the file does not exist, throw an error."
       (save-window-excursion
 	(message "Running %s...done" cmd)
         ;; Handlers such as "gio open" and kde-open5 start viewer in background
-        ;; and exit immediately.  Use pipe connnection type instead of pty to
+        ;; and exit immediately.  Use pipe connection type instead of pty to
         ;; avoid killing children processes with SIGHUP when temporary terminal
         ;; session is finished.
         ;;
-- 
2.30.2


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Fix some typos
  2021-09-16 21:40 [PATCH] Fix some typos Stefan Kangas
@ 2021-09-17  9:03 ` Timothy
  2021-09-17 10:05   ` Marco Wahl
  0 siblings, 1 reply; 16+ messages in thread
From: Timothy @ 2021-09-17  9:03 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

Hi Stefan,

Thanks again for going through our documentation and picking up these mistakes.
I’ve just applied this as 215d80d :)

All the best,
Timothy

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Fix some typos
  2021-09-17  9:03 ` Timothy
@ 2021-09-17 10:05   ` Marco Wahl
  2021-09-17 10:26     ` Stefan Kangas
  2021-09-22 16:47     ` Max Nikulin
  0 siblings, 2 replies; 16+ messages in thread
From: Marco Wahl @ 2021-09-17 10:05 UTC (permalink / raw)
  To: Timothy; +Cc: emacs-orgmode, Stefan Kangas

Timothy and Stefan!

Praise thy effort!

Thou shall not change "memeory" to "memory" tho!


Thy nittpicker!


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Fix some typos
  2021-09-17 10:05   ` Marco Wahl
@ 2021-09-17 10:26     ` Stefan Kangas
  2021-09-22 16:47     ` Max Nikulin
  1 sibling, 0 replies; 16+ messages in thread
From: Stefan Kangas @ 2021-09-17 10:26 UTC (permalink / raw)
  To: Marco Wahl, Timothy; +Cc: emacs-orgmode

Marco Wahl <marcowahlsoft@gmail.com> writes:

> Thy nittpicker!

    “This above all: to thine own self be true,
    And it must follow, as the night the day,
    Thou canst not then be false to any man.”


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Fix some typos
  2021-09-17 10:05   ` Marco Wahl
  2021-09-17 10:26     ` Stefan Kangas
@ 2021-09-22 16:47     ` Max Nikulin
  2021-09-22 20:18       ` Juan Manuel Macías
  2021-09-23 10:25       ` Marco Wahl
  1 sibling, 2 replies; 16+ messages in thread
From: Max Nikulin @ 2021-09-22 16:47 UTC (permalink / raw)
  To: emacs-orgmode; +Cc: Juan Manuel Macías, Marco Wahl

Please, forgive my ignorance of Shakespeare's poetry.

On 17/09/2021 17:05, Marco Wahl wrote:
 >> On 17/09/2021 04:40, Stefan Kangas wrote:
> 
>>> Please find attached another clean-up patch that fixes a small
>>> number of typos. > > Thou shall not change "memeory" to "memory" tho
I think, a bit more is required to avoid recurring attempts to change 
spelling if you would like to see such variant. Static code analyzers 
usually have a feature that allows to ignore specific warning at a 
particular line, see e.g. 
https://flake8.pycqa.org/en/latest/user/violations.html#in-line-ignoring-errors 
for Python's flake8.

Maybe "LocalWords:" could do a similar trick for ispell.el at least for 
the whole file. Unsure if it is possible to add an exception for the 
quote only.

However there is namely "memory" in the "1609 Quarto", see e.g. 
https://en.wikipedia.org/wiki/Sonnet_1 Web pages with the same variant 
as in the Org manual do not mention the source (particular edition). I 
hope, I just do not know what is considered as the canonical variant for 
not so old language.


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Fix some typos
  2021-09-22 16:47     ` Max Nikulin
@ 2021-09-22 20:18       ` Juan Manuel Macías
  2021-09-23 14:49         ` Max Nikulin
  2021-09-23 10:25       ` Marco Wahl
  1 sibling, 1 reply; 16+ messages in thread
From: Juan Manuel Macías @ 2021-09-22 20:18 UTC (permalink / raw)
  To: Max Nikulin, Marco Wahl; +Cc: orgmode

Hi all:

Max Nikulin writes:

> Please, forgive my ignorance of Shakespeare's poetry.
>
> On 17/09/2021 17:05, Marco Wahl wrote:
>>> On 17/09/2021 04:40, Stefan Kangas wrote:
>> 
>>>> Please find attached another clean-up patch that fixes a small
>>>> number of typos. > > Thou shall not change "memeory" to "memory" tho
> I think, a bit more is required to avoid recurring attempts to change
> spelling if you would like to see such variant. Static code analyzers 
> usually have a feature that allows to ignore specific warning at a
> particular line, see e.g. 
> https://flake8.pycqa.org/en/latest/user/violations.html#in-line-ignoring-errors
> for Python's flake8.
>
> Maybe "LocalWords:" could do a similar trick for ispell.el at least
> for the whole file. Unsure if it is possible to add an exception for
> the quote only.
>
> However there is namely "memory" in the "1609 Quarto", see e.g.
> https://en.wikipedia.org/wiki/Sonnet_1 Web pages with the same variant 
> as in the Org manual do not mention the source (particular edition). I
> hope, I just do not know what is considered as the canonical variant
> for not so old language.

I am not an expert on Shakespeare's poetry either, but as the author of
the patch where Sonnet 1 is included, I can say that 'memeory' is a typo
(sorry). At least I didn't use that word intentionally. I don't know if
there is any textual variant 'memeory', but in my case it is nothing
more than a simple typo :-).

Best regards,

Juan Manuel 






^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Fix some typos
  2021-09-22 16:47     ` Max Nikulin
  2021-09-22 20:18       ` Juan Manuel Macías
@ 2021-09-23 10:25       ` Marco Wahl
  1 sibling, 0 replies; 16+ messages in thread
From: Marco Wahl @ 2021-09-23 10:25 UTC (permalink / raw)
  To: Max Nikulin; +Cc: Juan Manuel Macías, emacs-orgmode

Max Nikulin <manikulin@gmail.com> writes:

> Please, forgive my ignorance of Shakespeare's poetry.

Ignorance is bliss!  (Sophocles)

> On 17/09/2021 17:05, Marco Wahl wrote:
>>> On 17/09/2021 04:40, Stefan Kangas wrote:

>>>> Please find attached another clean-up patch that fixes a small
>>>> number of typos. > > Thou shall not change "memeory" to "memory" tho

> I think, a bit more is required to avoid recurring attempts to change
> spelling if you would like to see such variant. Static code analyzers
> usually have a feature that allows to ignore specific warning at a
> particular line, see e.g.
> https://flake8.pycqa.org/en/latest/user/violations.html#in-line-ignoring-errors
> for Python's flake8.
>
> Maybe "LocalWords:" could do a similar trick for ispell.el at least for
> the whole file. Unsure if it is possible to add an exception for the
> quote only.

Interesting ideas!  

> However there is namely "memory" in the "1609 Quarto", see e.g.
> https://en.wikipedia.org/wiki/Sonnet_1 Web pages with the same variant
> as in the Org manual do not mention the source (particular edition). I
> hope, I just do not know what is considered as the canonical variant for
> not so old language.

Same here.  I have no idea.

What I found suspicious, was the correction occurring in a quote
section.  But you are right.  Since there is no reference to the source
the correction is worthy AFAICS.

If I'd be the only committer, I'd leave the "memeory" anyway.  But go
ahead and change the occurance to "memory" if you like.  I won't try to
stop you.







^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Fix some typos
  2021-09-22 20:18       ` Juan Manuel Macías
@ 2021-09-23 14:49         ` Max Nikulin
  2021-09-24  6:03           ` Loris Bennett
  0 siblings, 1 reply; 16+ messages in thread
From: Max Nikulin @ 2021-09-23 14:49 UTC (permalink / raw)
  To: Juan Manuel Macías, Marco Wahl; +Cc: orgmode

On 23/09/2021 03:18, Juan Manuel Macías wrote:
> Max Nikulin writes:
> 
>> However there is namely "memory" in the "1609 Quarto", see e.g.
>> https://en.wikipedia.org/wiki/Sonnet_1 Web pages with the same variant
>> as in the Org manual do not mention the source (particular edition). I
>> hope, I just do not know what is considered as the canonical variant
>> for not so old language.
> 
> I am not an expert on Shakespeare's poetry either, but as the author of
> the patch where Sonnet 1 is included, I can say that 'memeory' is a typo
> (sorry). At least I didn't use that word intentionally. I don't know if
> there is any textual variant 'memeory', but in my case it is nothing
> more than a simple typo :-).

Then "mught" should be another typo.

"His tender heire might beare his memory:" - 1609 Quatro

"His tender heir might bear his memory:" - Wikipedia citing Shakespeare, 
William. Duncan-Jones, Katherine. Shakespeare’s Sonnets. Bloomsbury 
Arden 2010. p. 113 ISBN 9781408017975

"His tender heir mught bear his memeory:" - some web pages and Org manual.


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Fix some typos
  2021-09-23 14:49         ` Max Nikulin
@ 2021-09-24  6:03           ` Loris Bennett
  2021-09-24 12:23             ` Juan Manuel Macías
  0 siblings, 1 reply; 16+ messages in thread
From: Loris Bennett @ 2021-09-24  6:03 UTC (permalink / raw)
  To: emacs-orgmode

Max Nikulin <manikulin@gmail.com> writes:

> On 23/09/2021 03:18, Juan Manuel Macías wrote:
>> Max Nikulin writes:
>>
>>> However there is namely "memory" in the "1609 Quarto", see e.g.
>>> https://en.wikipedia.org/wiki/Sonnet_1 Web pages with the same variant
>>> as in the Org manual do not mention the source (particular edition). I
>>> hope, I just do not know what is considered as the canonical variant
>>> for not so old language.
>>
>> I am not an expert on Shakespeare's poetry either, but as the author of
>> the patch where Sonnet 1 is included, I can say that 'memeory' is a typo
>> (sorry). At least I didn't use that word intentionally. I don't know if
>> there is any textual variant 'memeory', but in my case it is nothing
>> more than a simple typo :-).
>
> Then "mught" should be another typo.
>
> "His tender heire might beare his memory:" - 1609 Quatro

I think "Quatro" is another typo and should be "Quarto" (unless there
is a typo in the date and it is a line from little-know song by Suzi ...)

> "His tender heir might bear his memory:" - Wikipedia citing Shakespeare,
> William. Duncan-Jones, Katherine. Shakespeare’s Sonnets. Bloomsbury Arden
> 2010. p. 113 ISBN 9781408017975
>
> "His tender heir mught bear his memeory:" - some web pages and Org manual.
>
>
-- 
This signature is currently under construction.



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Fix some typos
  2021-09-24  6:03           ` Loris Bennett
@ 2021-09-24 12:23             ` Juan Manuel Macías
  2021-09-25 11:08               ` Marco Wahl
                                 ` (2 more replies)
  0 siblings, 3 replies; 16+ messages in thread
From: Juan Manuel Macías @ 2021-09-24 12:23 UTC (permalink / raw)
  To: Loris Bennett, Max Nikulin, Marco Wahl; +Cc: orgmode

[-- Attachment #1: Type: text/plain, Size: 1715 bytes --]

I attach a patch with Shakespeare's sonnet completely fixed: the poem is
replaced by the version included in Wikipedia (Shakespeare, William.
Duncan-Jones, Katherine. Shakespeare’s Sonnets. Bloomsbury Arden 2010.
p. 113). I also removed a spurious phrase that I put in that patch
(Org-News).

Best regards,

Juan Manuel

Loris Bennett writes:

> Max Nikulin <manikulin@gmail.com> writes:
>
>> On 23/09/2021 03:18, Juan Manuel Macías wrote:
>>> Max Nikulin writes:
>>>
>>>> However there is namely "memory" in the "1609 Quarto", see e.g.
>>>> https://en.wikipedia.org/wiki/Sonnet_1 Web pages with the same variant
>>>> as in the Org manual do not mention the source (particular edition). I
>>>> hope, I just do not know what is considered as the canonical variant
>>>> for not so old language.
>>>
>>> I am not an expert on Shakespeare's poetry either, but as the author of
>>> the patch where Sonnet 1 is included, I can say that 'memeory' is a typo
>>> (sorry). At least I didn't use that word intentionally. I don't know if
>>> there is any textual variant 'memeory', but in my case it is nothing
>>> more than a simple typo :-).
>>
>> Then "mught" should be another typo.
>>
>> "His tender heire might beare his memory:" - 1609 Quatro
>
> I think "Quatro" is another typo and should be "Quarto" (unless there
> is a typo in the date and it is a line from little-know song by Suzi ...)
>
>> "His tender heir might bear his memory:" - Wikipedia citing Shakespeare,
>> William. Duncan-Jones, Katherine. Shakespeare’s Sonnets. Bloomsbury Arden
>> 2010. p. 113 ISBN 9781408017975
>>
>> "His tender heir mught bear his memeory:" - some web pages and Org manual.
>>
>>


[-- Attachment #2: 0001-org-manual.org-ORG-NEWS-fix-Shakespeare-sonnet-and-a.patch --]
[-- Type: text/x-patch, Size: 3153 bytes --]

From f2e09b5e50a08b409e5f48df59dffbb36e9677ac Mon Sep 17 00:00:00 2001
From: Juan Manuel Macias <maciaschain@posteo.net>
Date: Fri, 24 Sep 2021 13:58:30 +0200
Subject: [PATCH] org-manual.org, ORG-NEWS: fix Shakespeare' sonnet and another
 typo
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* doc/org-manual.org (Verse blocks in LaTeX export): The previous
version of Shakespeare's sonnet is replaced by the version included in
Wikipedia (Shakespeare, William. Duncan-Jones, Katherine. Shakespeare’s
Sonnets. Bloomsbury Arden 2010. p. 113)
* etc/ORG-NEWS (Support verse blocks in LaTeX export): The last
sentence is superfluous. There is no explanation below.
---
 doc/org-manual.org | 17 +++++++++--------
 etc/ORG-NEWS       |  3 +--
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/doc/org-manual.org b/doc/org-manual.org
index b5de85cc9..ba396e205 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -13897,24 +13897,25 @@ explained below.
 - =:latexcode= :: It accepts any arbitrary LaTeX code that can be
   included within a LaTeX =verse= environment.
 
-A complete example with Shakespeare's first sonnet:
+A complete example with Shakespeare's first sonnet (source:
+[[https://en.wikipedia.org/wiki/Sonnet_1]]):
 
 #+begin_src org
 ,#+ATTR_LATEX: :center t :latexcode \color{red} :lines 5
-,#+ATTR_LATEX: :versewidth Feed’st thy light’st flame with self-substantial fuel,
+,#+ATTR_LATEX: :versewidth Feed’st thy light’s flame with self-substantial fuel,
 ,#+BEGIN_VERSE
 From fairest creatures we desire increase,
 That thereby beauty’s rose might never die,
-But as the riper should by time decrease,
-His tender heir mught bear his memeory:
+But as the riper should by time decease
+His tender heir might bear his memory:
 But thou, contracted to thine own bright eyes,
-Feed’st thy light’st flame with self-substantial fuel,
+Feed’st thy light’s flame with self-substantial fuel,
 Making a famine where abundance lies,
 Thyself thy foe, to thy sweet self too cruel.
-Thou that art now the world’s fresh ornament
+Thou that art now the world’s fresh ornament,
 And only herald to the gaudy spring,
-Within thine own bud buriest thy content
-And, tender churl, makest waste in niggarding.
+Within thine own bud buriest thy content,
+And, tender churl, mak’st waste in niggardly.
 Pity the world, or else this glutton be,
 To eat the world’s due, by the grave and thee.
 ,#+END_VERSE
diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS
index 7a46e825b..9a674cc04 100644
--- a/etc/ORG-NEWS
+++ b/etc/ORG-NEWS
@@ -254,8 +254,7 @@ that Org mode configures LaTeX to process any new float type.
 The LaTeX export back-end accepts four attributes for verse blocks:
 =:lines=, =:center=, =:versewidth= and =:latexcode=. The three first
 require the external LaTeX package =verse.sty=, which is an extension
-of the standard LaTeX environment. The purpose of these attributes is
-explained below.
+of the standard LaTeX environment.
 
 *** Support quote blocks in LaTeX export
 
-- 
2.32.0


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Fix some typos
  2021-09-24 12:23             ` Juan Manuel Macías
@ 2021-09-25 11:08               ` Marco Wahl
  2021-09-29 10:34                 ` Max Nikulin
  2021-09-25 11:47               ` [PATCH] org-manual.org, ORG-NEWS: fix Shakespeare' sonnet and another, typo Max Nikulin
  2021-09-29 11:14               ` [PATCH] Fix some typos Bastien
  2 siblings, 1 reply; 16+ messages in thread
From: Marco Wahl @ 2021-09-25 11:08 UTC (permalink / raw)
  To: Juan Manuel Macías; +Cc: Loris Bennett, orgmode, Max Nikulin

Please don't top post!  Hopefully there is consent about using the
bottom posting style on this list.

Juan Manuel Macías <maciaschain@posteo.net> writes:

> I attach a patch with Shakespeare's sonnet completely fixed: the poem is
> replaced by the version included in Wikipedia (Shakespeare, William.
> Duncan-Jones, Katherine. Shakespeare’s Sonnets. Bloomsbury Arden 2010.
> p. 113). I also removed a spurious phrase that I put in that patch
> (Org-News).

Thanks for the patch!

I agree to change the Shakespeare part to have a reference and be
corrected accordingly.

Thanks for the fix of the ORGNEWS entry.  Nitpick: I'd prefer the fix of
the ORGNEWS in a further patch for a little bit of more clarity.

AFAICS thy patch mught apply!





^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] org-manual.org, ORG-NEWS: fix Shakespeare' sonnet and another, typo
  2021-09-24 12:23             ` Juan Manuel Macías
  2021-09-25 11:08               ` Marco Wahl
@ 2021-09-25 11:47               ` Max Nikulin
  2021-09-29 11:14               ` [PATCH] Fix some typos Bastien
  2 siblings, 0 replies; 16+ messages in thread
From: Max Nikulin @ 2021-09-25 11:47 UTC (permalink / raw)
  To: emacs-orgmode

On 24/09/2021 19:23, Juan Manuel Macías wrote:
> I attach a patch with Shakespeare's sonnet completely fixed: the poem is
> replaced by the version included in Wikipedia (Shakespeare, William.
> Duncan-Jones, Katherine. Shakespeare’s Sonnets. Bloomsbury Arden 2010.
> p. 113).

Thank you, Juan Manuel. With you patch the text becomes almost identical to
- Shakespeare's Sonnets  (1883) William Shakespeare, edited by William 
J. Rolfe 
https://en.wikisource.org/wiki/Shakespeare%27s_Sonnets_(1883)/Sonnet_1
- Shakespeare's Sonnets  (1923) William Shakespeare, edited by Edward 
Bliss Reed 
https://en.wikisource.org/wiki/Shakespeare%27s_Sonnets_(1923)_Yale/Text/Sonnet_1

I think, variations are not significant: "niggardly" / "niggarding" and 
a few more commas in the older editions.

I hope, Unicode single comma apostrophe U+2019 (right single quotation 
mark) is not a problem (vs. \x27 ASCII character). Anyway it is used in 
the current variant and nobody complains.

I think, the patch should be applied to avoid proliferation of a variant 
with strange spelling in the web.



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Fix some typos
  2021-09-25 11:08               ` Marco Wahl
@ 2021-09-29 10:34                 ` Max Nikulin
  2021-09-29 11:09                   ` Marco Wahl
  2021-09-29 11:11                   ` Bastien Guerry
  0 siblings, 2 replies; 16+ messages in thread
From: Max Nikulin @ 2021-09-29 10:34 UTC (permalink / raw)
  To: emacs-orgmode; +Cc: Juan Manuel Macías, Marco Wahl

Bastien,

A message in this thread
https://orgmode.org/list/87tuiaxivh.fsf@posteo.net/ (Juan Manuel Macías, 
Fri, 24 Sep 2021 12:23:14 +0000) contains a patch that fixes a 
Shakespeare's sonnet in org-manual.org

Due to updated ORG-NEWS file, it could not be applied directly. I had it 
applied after

commit d74a82448bc28dd9be7b57611038bbb4c7172bce
Author: Sébastien Miquel <sebastien.miquel@posteo.eu>
Date:   Fri May 28 21:14:22 2021 +0200

and in such form it could be rebased to main. Alternatively ORG-NEWS 
part could be just dropped (and applied later).

The story is the following:
- 91373e15c8 doc/org-manual.org    13905 (Juan Manuel Macías 
2021-05-15 15:44:36 +0200 13906)
a documentation for verse formatting was added with a strange variant 
(spread over net though)
- 215d80d02b doc/org-manual.org    13907 (Stefan Kangas 
2021-09-16 14:40:12 -0700 13909)
besides other typos, one in this verse was fixed
- 4271f228db doc/org-manual.org    13909 (Marco Wahl 
2021-09-20 12:09:31 +0200 13909)
reverted one edit by Stefan likely assuming old English spelling.

Nobody has an idea concerning origin of current variant (particular 
edition of Shakespeare's book), so Juan Manuel created the patch with 
variant published in recent books.

In https://orgmode.org/list/sin28h$ufv$1@ciao.gmane.io/
I tried to add the following header
X-Woof-Patch: org-manual.org, ORG-NEWS: fix Shakespeare' sonnet and 
another typo
but the patch is not tracked currently on updates.orgmode.org

On 25/09/2021 18:08, Marco Wahl wrote:
> Juan Manuel Macías writes:
> 
>> I attach a patch with Shakespeare's sonnet completely fixed: the poem is
>> replaced by the version included in Wikipedia (Shakespeare, William.
>> Duncan-Jones, Katherine. Shakespeare’s Sonnets. Bloomsbury Arden 2010.
>> p. 113). I also removed a spurious phrase that I put in that patch
>> (Org-News).
> 
> Thanks for the fix of the ORGNEWS entry.  Nitpick: I'd prefer the fix of
> the ORGNEWS in a further patch for a little bit of more clarity.

I agree with such remark, however I still suppose that the patch could 
be applied even in current variant.



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Fix some typos
  2021-09-29 10:34                 ` Max Nikulin
@ 2021-09-29 11:09                   ` Marco Wahl
  2021-09-29 11:11                   ` Bastien Guerry
  1 sibling, 0 replies; 16+ messages in thread
From: Marco Wahl @ 2021-09-29 11:09 UTC (permalink / raw)
  To: Max Nikulin; +Cc: Bastien, Juan Manuel Macías, orgmode

Max Nikulin <manikulin@gmail.com> writes:

> Bastien,
>
> A message in this thread
> https://orgmode.org/list/87tuiaxivh.fsf@posteo.net/ (Juan Manuel
> Macías, Fri, 24 Sep 2021 12:23:14 +0000) contains a patch that fixes a
> Shakespeare's sonnet in org-manual.org
>
> Due to updated ORG-NEWS file, it could not be applied directly. I had
> it applied after
>
> commit d74a82448bc28dd9be7b57611038bbb4c7172bce
> Author: Sébastien Miquel <sebastien.miquel@posteo.eu>
> Date:   Fri May 28 21:14:22 2021 +0200
>
> and in such form it could be rebased to main. Alternatively ORG-NEWS
> part could be just dropped (and applied later).
>
> The story is the following:
> - 91373e15c8 doc/org-manual.org    13905 (Juan Manuel Macías
>   2021-05-15 15:44:36 +0200 13906)
> a documentation for verse formatting was added with a strange variant
> (spread over net though)
> - 215d80d02b doc/org-manual.org    13907 (Stefan Kangas 2021-09-16
>  14:40:12 -0700 13909)
> besides other typos, one in this verse was fixed
> - 4271f228db doc/org-manual.org    13909 (Marco Wahl 2021-09-20
>  12:09:31 +0200 13909)
> reverted one edit by Stefan likely assuming old English spelling.
>
> Nobody has an idea concerning origin of current variant (particular
> edition of Shakespeare's book), so Juan Manuel created the patch with
> variant published in recent books.
>
> In https://orgmode.org/list/sin28h$ufv$1@ciao.gmane.io/
> I tried to add the following header
> X-Woof-Patch: org-manual.org, ORG-NEWS: fix Shakespeare' sonnet and
> another typo
> but the patch is not tracked currently on updates.orgmode.org
>
> On 25/09/2021 18:08, Marco Wahl wrote:
>> Juan Manuel Macías writes:
>> 
>>> I attach a patch with Shakespeare's sonnet completely fixed: the poem is
>>> replaced by the version included in Wikipedia (Shakespeare, William.
>>> Duncan-Jones, Katherine. Shakespeare’s Sonnets. Bloomsbury Arden 2010.
>>> p. 113). I also removed a spurious phrase that I put in that patch
>>> (Org-News).
>> Thanks for the fix of the ORGNEWS entry.  Nitpick: I'd prefer the
>> fix of
>> the ORGNEWS in a further patch for a little bit of more clarity.
>
> I agree with such remark, however I still suppose that the patch could
> be applied even in current variant.

Please go ahead with the patches as you like!  That nitpick is meant as
a hint for commits to come!


Regards,
-- 
Marco


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Fix some typos
  2021-09-29 10:34                 ` Max Nikulin
  2021-09-29 11:09                   ` Marco Wahl
@ 2021-09-29 11:11                   ` Bastien Guerry
  1 sibling, 0 replies; 16+ messages in thread
From: Bastien Guerry @ 2021-09-29 11:11 UTC (permalink / raw)
  To: Max Nikulin; +Cc: Juan Manuel Macías, Marco Wahl, orgmode

Hi Max,

Max Nikulin <manikulin@gmail.com> writes:

> A message in this thread
> https://orgmode.org/list/87tuiaxivh.fsf@posteo.net/ (Juan Manuel
> Macías, Fri, 24 Sep 2021 12:23:14 +0000) contains a patch that fixes a
> Shakespeare's sonnet in org-manual.org

Thanks for bringing this to my attention: I've now applied Juan's
change in the main branch.

-- 
 Bastien


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Fix some typos
  2021-09-24 12:23             ` Juan Manuel Macías
  2021-09-25 11:08               ` Marco Wahl
  2021-09-25 11:47               ` [PATCH] org-manual.org, ORG-NEWS: fix Shakespeare' sonnet and another, typo Max Nikulin
@ 2021-09-29 11:14               ` Bastien
  2 siblings, 0 replies; 16+ messages in thread
From: Bastien @ 2021-09-29 11:14 UTC (permalink / raw)
  To: Juan Manuel Macías; +Cc: Marco Wahl, Loris Bennett, orgmode, Max Nikulin

Hi Juan,

Juan Manuel Macías <maciaschain@posteo.net> writes:

> I also removed a spurious phrase that I put in that patch
> (Org-News).

Applied too!  Thanks.

-- 
 Bastien


^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2021-09-29 11:15 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 21:40 [PATCH] Fix some typos Stefan Kangas
2021-09-17  9:03 ` Timothy
2021-09-17 10:05   ` Marco Wahl
2021-09-17 10:26     ` Stefan Kangas
2021-09-22 16:47     ` Max Nikulin
2021-09-22 20:18       ` Juan Manuel Macías
2021-09-23 14:49         ` Max Nikulin
2021-09-24  6:03           ` Loris Bennett
2021-09-24 12:23             ` Juan Manuel Macías
2021-09-25 11:08               ` Marco Wahl
2021-09-29 10:34                 ` Max Nikulin
2021-09-29 11:09                   ` Marco Wahl
2021-09-29 11:11                   ` Bastien Guerry
2021-09-25 11:47               ` [PATCH] org-manual.org, ORG-NEWS: fix Shakespeare' sonnet and another, typo Max Nikulin
2021-09-29 11:14               ` [PATCH] Fix some typos Bastien
2021-09-23 10:25       ` Marco Wahl

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).