From: Jim Porter <jporterbugs@gmail.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] Improve org-mouse support for checkboxes
Date: Sat, 18 Sep 2021 12:38:29 -0700 [thread overview]
Message-ID: <si5f7l$j3f$1@ciao.gmane.io> (raw)
[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]
While trying out `org-mouse', I noticed two semi-related issues with
checkboxes. First, intermediate-state checkboxes (like [-]) aren't
clickable. Second, if the checkboxes are inside a block and the theme
gives the block a background color, the block's background is removed
behind the checkbox. To see both of these in action:
$ cat file.org
* Regular
- [X] Checked.
- [-] Half-checked.
- [ ] Not checked.
* In block
#+begin_src org
- [X] Checked.
- [-] Half-checked.
- [ ] Not checked.
#+end_src
$ emacs -Q --eval '(progn (setq org-modules '"'"'(org-mouse))
(custom-set-faces '"'"'(org-block ((t :background "green")))))' file.org
The attached patch fixes both of these issues. For the first problem,
maybe it would be useful to put the regexp for checkboxes in a variable
somewhere so it doesn't get out of sync. I wasn't sure though, so I went
with the simpler solution for now.
My FSF copyright assignment should be on file, but let me know if there
are any issues there.
[-- Attachment #2: 0001-org-mouse-Support-intermediate-state-checkboxes.patch --]
[-- Type: text/plain, Size: 1249 bytes --]
From b2bd5115a89b9b26107aca4b59e516dc7d64f0cc Mon Sep 17 00:00:00 2001
From: Jim Porter <itsjimporter@gmail.com>
Date: Sat, 18 Sep 2021 12:22:41 -0700
Subject: [PATCH] org-mouse: Support intermediate-state checkboxes
* lisp/org-mouse.el (org-mode-hook): Use regexp from
`org-set-font-lock-defaults' and set font-lock keywords more robustly.
---
lisp/org-mouse.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/org-mouse.el b/lisp/org-mouse.el
index 4471d8e8d..eae6cd98f 100644
--- a/lisp/org-mouse.el
+++ b/lisp/org-mouse.el
@@ -890,8 +890,8 @@ This means, between the beginning of line and the point."
(when (memq 'activate-checkboxes org-mouse-features)
(font-lock-add-keywords
nil
- `(("^[ \t]*\\([-+*]\\|[0-9]+[.)]\\) +\\(\\[[ X]\\]\\)"
- (2 `(face org-checkbox keymap ,org-mouse-map mouse-face highlight) t)))
+ `(("^[ \t]*\\(?:[-+*]\\|[0-9]+[.)]\\)[ \t]+\\(?:\\[@\\(?:start:\\)?[0-9]+\\][ \t]*\\)?\\(\\[[- X]\\]\\)"
+ (1 `(face nil keymap ,org-mouse-map mouse-face highlight) prepend)))
t))
(defadvice org-open-at-point (around org-mouse-open-at-point activate)
--
2.25.1
next reply other threads:[~2021-09-18 19:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 19:38 Jim Porter [this message]
2021-09-18 20:54 ` [PATCH] Improve org-mouse support for checkboxes Samuel Wales
2021-09-18 22:47 ` Jim Porter
2021-09-26 5:58 ` Bastien
2021-09-26 18:11 ` Jim Porter
2021-09-26 20:18 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='si5f7l$j3f$1@ciao.gmane.io' \
--to=jporterbugs@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).