From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gJO3L18aDGFiJQEAgWs5BA (envelope-from ) for ; Thu, 05 Aug 2021 19:05:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SHNLK18aDGErNQAAbx9fmQ (envelope-from ) for ; Thu, 05 Aug 2021 17:05:35 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E2ABBAA71 for ; Thu, 5 Aug 2021 19:05:34 +0200 (CEST) Received: from localhost ([::1]:57416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBgoI-0007LX-0l for larch@yhetil.org; Thu, 05 Aug 2021 13:05:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48088) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBgnx-0007L9-JB for emacs-orgmode@gnu.org; Thu, 05 Aug 2021 13:05:13 -0400 Received: from ciao.gmane.io ([116.202.254.214]:39654) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBgnw-0005HJ-76 for emacs-orgmode@gnu.org; Thu, 05 Aug 2021 13:05:13 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mBgnt-000ARQ-Ti for emacs-orgmode@gnu.org; Thu, 05 Aug 2021 19:05:09 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Maxim Nikulin Subject: Re: [PATCH] org-agenda.el: Avoid dependency on subr-x Date: Fri, 6 Aug 2021 00:04:59 +0700 Message-ID: References: <09a29a60-b254-9207-0d44-eaf0b1ba964b@ya.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 27 X-Spam_score: 2.7 X-Spam_bar: ++ X-Spam_report: (2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.132, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628183135; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=wClq75gtICUaQqhhf9+nTeMt+RGrSZfV9EV24zxWPZ4=; b=KbfaCH3px1A9L5nIvJAQMFx/+o02zG8gw2u6UnXRmhX2LNsMfp7ahSCcTN02oLa1a2/aCC 4FA05si+sgQgbL7HVgIpZnz5MvJR3fGPp+6wTz9jfx9uJA+udfV/WXmcI5bQRUqjFBoyRS DsZZNORRq3VPyrD19WDZc9zd6yLsfwYf1C+B5kMz/aDwpTaS+9W4Qvw0e+/gGwyi9Lhxxs 302XqyFzn7etQnKaT6Bx73z6WTeMBtKlEsFU4WzO5sqEg5kMiYaGdQlGJ8PSTjpXsbprVH vJNB4nj/4N1DjD41uwScSJDopA5cDOF0mOLO4ru3+3YM8GBFXLelvJL6i5BBTQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628183135; a=rsa-sha256; cv=none; b=EiCGhA0BwMslB8qTSr6MsMW8OIRHS/WDdusSxRJ/5pZR7ZJdMWAFs89I9Z97WUZ8nyvS25 ukb18T2Pbqm+Uq1zOAO/R2SIR8Ym4taybpHC3rGfYlaaQLVAAElGwjxGhpZpGFeuGXBegf dnYzNl2IS8OggIWhUe37ZByaZW0gDYLEXJEn5xBDoEqBIywFOfWyioOTehnRi7n/t94yZu VzBkCpzztqnQma2VbZV67ur0Wz7pGvpqn3ef1jfRq3cZA8d8RvejlcXe6tROwGDN1s8LGP 4wy0wt2RZVW0mjg6rvZ+74GiYxU6zVJOXsV+jLUkzfldjpQeMT9ivA4uV9AvNA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.82 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: E2ABBAA71 X-Spam-Score: -1.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: bCU+UgOnkUvx On 05/08/2021 04:41, Вячеслав Гришин wrote: > Now I don't know if I need to do something extra, because the > problem arose because of my mistake. Vyacheslav, you do not need to react to my patch, it is for Org maintainers. There is neither continuous integration server nor ready to use configuration (e.g. a set of docker containers) to verify commits in clean environment. As a result some files may have minor issues that are unnoticeable by most of users. However it is better to fix inconsistencies like missed `require', etc. > When I removed the second version of Org and the extra code from .emacs, > everything worked. I don't know how to explain it, because I'm just > starting to learn emacs and lisp Notice that you can have more than one org mode version installed. E.g. in Debian and Ubuntu in addition to the version bundled with Emacs, it is possible to install elpa-org deb package. The version however is anyway noticeably older than current stable Org release, so people often use various package managers for Emacs. The problem you have met is not uncommon, example of usual response: https://orgmode.org/list/87im5gszqs.fsf@kyleam.com/ Unfortunately symptoms are usually quite obscure, they may reveal another issue. I do not know if it is possible to implement a trap to explicitly notify user that parts of org are loaded from different directories. There are may be some pitfalls on the way to have newer org version: - You should not require any org modules before `load-path' is adjusted. - Do not forget to recompile after update of sources. It seems, Emacs do not have means to detect stale .elc file similar to e.g. Python. - Attempt to try alternative version without modification of init.el may result in unexpected result. Usually "-Q" or at least "-q" option is required to suppress initialization. "-L" option is processed after init.el. So "emacs -L ~/src/org-mode/lisp" can easily result in mixed install. E.g. "emacs -Q -L ~/src/org-mode/lisp -l ~/.emacs.d/init.el" mostly work but there are some edge cases since it is not full equivalent of real initialization. There is no way to specify custom init file through command line option, it is necessary to create a part of parallel universe and pass it as --user option argument, HOME or XDG_CONFIG_HOME (for latest emacs version) environment: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=15539#121 Do not be afraid by such complications too much. ELPA package is the recommended way to have latest stable version: https://orgmode.org/install.html Alternatively ensure that (add-to-list 'load-path "~/src/org-mode/lisp") is early enough in your init.el.