From: Ruijie Yu via "General discussions about Org-mode." <emacs-orgmode@gnu.org>
To: Ruijie Yu <ruijie@netyu.xyz>
Cc: emacs-orgmode@gnu.org
Subject: Re: Major mode of orgweb/publish.sh?
Date: Fri, 14 Apr 2023 16:15:04 +0800 [thread overview]
Message-ID: <sdvzg7a6fph.fsf@fw.net.yu> (raw)
In-Reply-To: <sdv4jpi7ugk.fsf@fw.net.yu>
[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]
Ruijie Yu <ruijie@netyu.xyz> writes:
>> Hello,
>>
>> What is the expected major mode for orgweb/publish.sh? When I open it,
>> I see it is in `shell-script-mode'. This is what I see in
>> orgweb/publish.sh:
>>
>> --8<---------------cut here---------------start------------->8---
>> #!/usr/bin/env sh
>>
>> ":" ; exec emacs --quick --script "$0" -- "$@" # -*- mode: emacs-lisp; lexical-binding: t; -*-
>> ...
>> --8<---------------cut here---------------end--------------->8---
>>
>> When I remove the empty line 2 and run `normal-mode', the file now opens
>> in `emacs-lisp-mode'. I have a sneaking suspicion that
>> `emacs-lisp-mode' is the expected major mode for this file, because
>> there is also the `lexical-binding' variable declaration on the property
>> line, which has no effects when the major mode is shell.
>
> In case I am right, I'll send a patch for this and another issue I find
> for review shortly.
Here attached is the patch for orgweb. The commit message describes the
two issues I find regarding orgweb/publish.sh.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-publish.sh-fixed-major-mode-converted-load-into-requ.patch --]
[-- Type: text/x-patch, Size: 1395 bytes --]
From 90fd8ecc39cb279ee27e0db2f637f60c7b80af07 Mon Sep 17 00:00:00 2001
From: Ruijie Yu <ruijie@netyu.xyz>
Date: Fri, 14 Apr 2023 16:04:27 +0800
Subject: [PATCH] * publish.sh: fixed major mode; converted load into require
Major mode was erronously set to shell-script-mode because of the empty line.
Converted the `load' into `require' because it allows someone working on a local
repo to `eval-buffer' successfully, given that the individual installs these
dependencies from GNU/NonGNU Elpa. Previously, due to the hard-coded path,
`eval-buffer' would not be successful.
---
publish.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/publish.sh b/publish.sh
index f756ff6..b3911d2 100755
--- a/publish.sh
+++ b/publish.sh
@@ -1,13 +1,13 @@
#!/usr/bin/env sh
-
-":"; exec emacs --quick --script "$0" -- "$@" # -*- mode: emacs-lisp; lexical-binding: t; -*-
+":" ; exec emacs --quick --script "$0" -- "$@" # -*- mode: emacs-lisp; lexical-binding: t; -*-
(add-to-list 'load-path "~/org-mode/lisp/")
(add-to-list 'load-path "~/org-contrib/lisp/")
(require 'ox-html)
(require 'ox-extra)
(ox-extras-activate '(ignore-headlines))
-(load "/usr/share/emacs/site-lisp/elpa-src/htmlize-1.56/htmlize.el")
+(add-to-list 'load-path "/usr/share/emacs/site-lisp/elpa-src/htmlize-1.56")
+(require 'htmlize)
(setq make-backup-files nil
debug-on-error t)
--
2.40.0
[-- Attachment #3: Type: text/plain, Size: 16 bytes --]
--
Best,
RY
next prev parent reply other threads:[~2023-04-14 8:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 7:49 Major mode of orgweb/publish.sh? Ruijie Yu via General discussions about Org-mode.
2023-04-14 8:11 ` Ruijie Yu via General discussions about Org-mode.
2023-04-14 8:15 ` Ruijie Yu via General discussions about Org-mode. [this message]
2023-04-14 8:28 ` Ihor Radchenko
2023-04-14 9:20 ` Ruijie Yu via General discussions about Org-mode.
2023-04-19 16:54 ` Max Nikulin
2023-04-19 9:49 ` Bastien Guerry
2023-04-21 3:09 ` Ruijie Yu via General discussions about Org-mode.
2023-04-14 8:20 ` Ihor Radchenko
2023-04-14 8:19 ` Ruijie Yu via General discussions about Org-mode.
2023-04-14 8:54 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sdvzg7a6fph.fsf@fw.net.yu \
--to=emacs-orgmode@gnu.org \
--cc=ruijie@netyu.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).