emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ruijie Yu via "General discussions about Org-mode." <emacs-orgmode@gnu.org>
To: Andreas Gerler <baron@bundesbrandschatzamt.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [O] [PATCH] ob-eval: display error fix
Date: Sat, 07 Jan 2023 15:33:25 -0600	[thread overview]
Message-ID: <sdvfscmja88.fsf@fw.net.yu> (raw)
In-Reply-To: <BAD93849-5D53-4754-88E6-F4477899E382@bundesbrandschatzamt.de>

Hi Andreas,

-    (display-buffer buf))
+    (if org-babel-eval-error-display-notify
+        (display-buffer buf)
+      (if (or (not (numberp exit-code))
+              (> exit-code 0))
+          (display-buffer buf))))

Quick question, does it help or hurt readability if we change this
nested `if' into a `cond' expression?

Or, alternatively, since both the outer then branch and the inner then
branch are the same expression, maybe we can just combine all three
conditions into a single `or' call?

Something like

(when (or org-babel-eval-error-display-notify
          (not (numberp exit-code))
          (> exit-code 0))
  (display-buffer buf))



  reply	other threads:[~2023-01-07 21:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-07 13:24 [O] [PATCH] ob-eval: display error fix Andreas Gerler
2023-01-07 21:33 ` Ruijie Yu via General discussions about Org-mode. [this message]
2023-01-08 11:16   ` Andreas Gerler
2023-01-27  1:48     ` Ruijie Yu via General discussions about Org-mode.
2023-01-27 13:10     ` Ihor Radchenko
2023-02-03 17:04       ` Andreas Gerler
2023-04-14 12:44 ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sdvfscmja88.fsf@fw.net.yu \
    --to=emacs-orgmode@gnu.org \
    --cc=baron@bundesbrandschatzamt.de \
    --cc=ruijie@netyu.xyz \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).