From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 8J+CC7tjc2QECgAASxT56A (envelope-from ) for ; Sun, 28 May 2023 16:22:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yMBTCrtjc2REHgEAG6o9tA (envelope-from ) for ; Sun, 28 May 2023 16:22:51 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B626917A83 for ; Sun, 28 May 2023 16:22:50 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3HHL-00019L-BA; Sun, 28 May 2023 10:21:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3HHG-00018k-O8 for emacs-orgmode@gnu.org; Sun, 28 May 2023 10:21:47 -0400 Received: from netyu.xyz ([152.44.41.246] helo=mail.netyu.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3HHD-00074F-Ap for emacs-orgmode@gnu.org; Sun, 28 May 2023 10:21:46 -0400 Received: from fw.net.yu.netyu.xyz ( [222.248.4.98]) by netyu.xyz (OpenSMTPD) with ESMTPSA id 9114c311 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 28 May 2023 14:21:41 +0000 (UTC) References: <7a012430-6084-e693-1a86-f14d0512bebc@skyguard.com.cn> User-agent: mu4e 1.9.22; emacs 30.0.50 To: Pan Xie Cc: emacs-orgmode@gnu.org Subject: Re: [FR] Please add environment variable substitution in `org-display-inline-images' In-reply-to: <7a012430-6084-e693-1a86-f14d0512bebc@skyguard.com.cn> Date: Sun, 28 May 2023 22:21:29 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=152.44.41.246; envelope-from=ruijie@netyu.xyz; helo=mail.netyu.xyz X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Ruijie Yu From: Ruijie Yu via "General discussions about Org-mode." Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1685283770; a=rsa-sha256; cv=none; b=FgKf45afjUAnKiCn0A0YYRo7zJuDgK6a1LgolFYVD8lp7D22ULQWwvWxJRypOKEh1puboG mC8c04YXgHH/RmNj5nMRZbinliY9viQs7eBKDn7CzSFh0tt7yClevNVALdZYytOnMm17Yg Ij/lnfg5hED8Yp/SIVMx0QJyrzQ9wJe3FnreJKpA7CfBR0+qWLr81JK6edeZTDBvshDKCn 86PjPCDlDecJo+6gQ+Csm+VnmqSYiyL+iTPcIpcBkUHWNNAgasmqxdnVdWXMa8mTvGvZiU oYu3YwjtXV0iFoDGwLJFm0dgc9WwiqeoUR+Az6UGrCTfKJlwhX6fplr5ARQqog== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1685283770; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=kXGOz5dIphervJKL1EWt7etT+xmhvQN9wkUlUAFP0pQ=; b=rxiAuRjkYUqLwxQaE0GgLNPI0UJIcgb53olB2ht+NjwVbhQ1lr0DpzjneVmbqIqNkJfnhI v61ACX/pR7eMfvUZlv3Ke+xnW6sdhFtt7fh6SL4NFBRJZEaFPsCDSPokqTReBjCbY0yayq H/J7OnoaUcNNllIB4F9Tnuvomun0mXXpCu2gzkScl5Zeg+HM053E6Z1Ybcefs7bf6tneh+ EOj9NzG0okopwLfw4psYfZV10/x5HVpbTVSz9CEAMG+J7sxi4ThKSuY51SuLPYHu5/UgAf s98lSXOjSMo+ts1cRo6Gl0lCSwXLzhQVjx+qsDTrCkCtekLv/FBCvaBATxOESg== X-Migadu-Spam-Score: -3.95 X-Spam-Score: -3.95 X-Migadu-Queue-Id: B626917A83 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-TUID: xfXkQT47T+2l Pan Xie writes: > So my proposal of the code change would be (find "pxie" in the codes): Thanks for proposing a change. It would be best if you produced a patch file from this :) But someone with a bit more free time could do that as well. This is just FYI, and by no means a big deal, but it would become a huge burden for the maintainers to apply the proposed changes if the changeset becomes larger. For future reference, I'm talking about something like this (assuming you have git and a shell supporting IO redirect): $ git diff this-file.el > something.diff , or even better: $ git commit -m commit-message... $ git format-patch ... In either case, you would attach the generated file in your message. See also https://orgmode.org/worg/org-contribute.html for details. -- Best, RY