From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oBnUDTHBAmEwwAAAgWs5BA (envelope-from ) for ; Thu, 29 Jul 2021 16:54:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8Bd7CTHBAmGPJQAAbx9fmQ (envelope-from ) for ; Thu, 29 Jul 2021 14:54:41 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BF9571A121 for ; Thu, 29 Jul 2021 16:54:40 +0200 (CEST) Received: from localhost ([::1]:38532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m97Ql-0001KI-Rl for larch@yhetil.org; Thu, 29 Jul 2021 10:54:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m97QR-0001Jw-1h for emacs-orgmode@gnu.org; Thu, 29 Jul 2021 10:54:19 -0400 Received: from ciao.gmane.io ([116.202.254.214]:37104) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m97QP-0001wW-Fj for emacs-orgmode@gnu.org; Thu, 29 Jul 2021 10:54:18 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1m97QL-0004a9-Di for emacs-orgmode@gnu.org; Thu, 29 Jul 2021 16:54:13 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Maxim Nikulin Subject: Re: bug processing non emacs-lisp blocks Date: Thu, 29 Jul 2021 21:54:03 +0700 Message-ID: References: <87r1fh3gb1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 X-Woof-Patch: Confirmed In-Reply-To: <87r1fh3gb1.fsf@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 27 X-Spam_score: 2.7 X-Spam_bar: ++ X-Spam_report: (2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.125, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627570480; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=scPt2/XmAOaUaEOA0lgpPyXTsRuYNwcvLxRK0hrZQVs=; b=gCIZfv0LDm/LI/TXsIOEfxE9xfRocdAc01Y0VNVu0b9+xBXuTGiVPxwAxO9TfwxpYQiCG9 9pZbleheq2dwlOTTUOkVoKu3OPbDGqP4i99XuEFCqo2xC3klUHe4VTLyT3UdmJkot4rBMn icHVpc1heoa8zr9CoO6sfq9+0H7g/jUOZOfVjdZU1k5kkoPDiZgE3+ZQNqqdCJfMCVMxz7 pAG5SX3YprZYs6vQ2JpdE0DqcwjRPjOOTpmkwNxGFgca67GK5eI1Zv/uZwdB4V+nxN0WuS i3EWf01aWc6bofcM1+WsAHpuRKDF+8pL8MJUSAVthot/+YmWWzNwzhLIIZ5EcQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627570480; a=rsa-sha256; cv=none; b=h7QXU4CPUwr+2i6FeMPiH0atIaeHrrcChWZTcJkF3YBxI+JIdtSc6p8Os05iC0qArCXC+Q pZrDYf7gPQkWw6DfEsBivQFaY4n5/+nePJ64FHW7eLes4rCZ/Hl4RG6h4Gk7YqD82qefg9 pRYPvBcDLkvB9Yb1U5AlJezgg97R8T/9IdLcGHspRFjjcEkgy949NzmsGn0Zx4u/IiKELq iNlSgygcTEm/e+tV6MQTZ4fRM6p2tzAByf9PRfBOzR/+Zzhi994udsgUiYW63zuID9e74b RIu906kALqnqZOXOG0rNt2tf6FBoY+pG+yJxgT2fE5aFP0735TFjYegneLb2XA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.81 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: BF9571A121 X-Spam-Score: -1.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: tyQ24CXNGnAs On 29/07/2021 11:13, Tim Cross wrote: > dmg writes: > >> org-babel-load-file will try to tangle any source block that contains >> the substring emacs-lisp or elisp in their language. >> >> For example, the following code block will be tangled: >> >> #+begin_src emacs-lispDONOT >> (use-package "org-sidebar") >> #+end_src >> >> I think this is a regression. I used to comment out blocks from my >> .org init files by simply adding a XXX (as in emacs-lispXXXX). In >> current org these blocks are tangled :( > > I think your right. The regexp should only match on complete string. I agree as well. Related code changed in 9.4: - https://orgmode.org/list/CALOSHoRNnLxJMa6jnrt-iKiE-b9f9o3CLQDxFekrZVYiyzE0Qw@mail.gmail.com/T/#u - https://code.orgmode.org/bzg/org-mode/commit/be93859c78 The following is just my opinion, not a request for an update of the patch. Maybe it will be better to change `org-babel-tangle-collect-blocks' function in lisp/ob-tangle.el instead and to wrap passed argument in the suggested way (at first I thought of non-capturing group "\\(?:" "\\)", but it is not necessary since the regexp is passed to `string-match-p'). I suppose, it is more reliable default. If anyone really needs partial match, he may express it explicitly by adding ".*", "?", etc. I hope, such change will break no existing code.