From: Maxim Nikulin <email@example.com> To: firstname.lastname@example.org Subject: Re: [PATCH] make org-notify support for macOS desktop notification Date: Tue, 6 Jul 2021 19:13:42 +0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <7318E1D0-613A-4301-8097-779D3FEF1105@gmail.com> On 06/07/2021 08:45, stardiviner wrote: > Here is the new patch which invokes notifications though Emacs built-in API `ns-do-applescript`. I suspect, you considered your original patch as small and simple, didn't you? > + (format "display notification \"%s\" with title \"Org mode notification\"" > + (replace-regexp-in-string "\"" "#" notification)))) Last character of notification might be "\" so it might escape the closing quote. Some less common quote character like "´" may be less confusing than "#" in this confusing if proper escaping is a challenge. I am unsure how many people are still using 8-bit charsets. It seems there is no way to pass argv through `ns-do-applescript'. Is there at least a helper to escape strings similar to `shell-quote-argument'? Otherwise it is not friendly to developers since everyone has to do it himself. On 06/07/2021 07:06, Tim Cross wrote: > I suspect that any code > which 'encourages' the use of melpa packages will not be acceptabl If there are license problems with `osx-lib-notify2', I expect, it can be utilized through `org-show-notification-handler'. However users have to manually add such customization that is not really convenient. If `org-show-notification' depends on runtime configuration (whether DBus socket is available), maybe it is reasonable to rewrite the function and to add a convention that e.g. 'default return value causes attempt to call next handler in the responsibility chain. The intention is to allow fallback from `org-show-notification-handler' to standard notifiers or graceful degradation from `notifications-notify' to `message' if dbus connection is not available (e.g. Emacs is running in a minimal container). Such changes however out of scope of this patch.
next prev parent reply other threads:[~2021-07-06 12:17 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-04 0:23 stardiviner 2021-07-04 5:48 ` Maxim Nikulin 2021-07-05 3:50 ` stardiviner 2021-07-05 11:55 ` Maxim Nikulin 2021-07-05 22:36 ` stardiviner 2021-07-06 0:06 ` Tim Cross 2021-07-06 1:37 ` stardiviner 2021-07-06 8:12 ` Tim Cross 2021-07-06 1:45 ` [new patch] " stardiviner 2021-07-06 4:21 ` Christian Hopps 2021-07-06 15:30 ` [new patch] " stardiviner 2021-07-06 18:23 ` Christian Hopps 2021-07-08 0:00 ` stardiviner 2021-07-08 8:59 ` Christian Hopps 2021-07-08 9:35 ` STOP this patch for now stardiviner 2021-07-08 12:02 ` Christian Hopps 2021-07-06 12:13 ` Maxim Nikulin [this message] 2021-09-26 8:52 ` [new patch] Re: [PATCH] make org-notify support for macOS desktop notification Bastien 2021-09-30 15:01 ` Max Nikulin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org' \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] make org-notify support for macOS desktop notification' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).