* [PATCH] Add semimonth step for clocktables
@ 2020-03-20 11:35 Christian Hopps
2020-03-26 3:36 ` Kyle Meyer
0 siblings, 1 reply; 2+ messages in thread
From: Christian Hopps @ 2020-03-20 11:35 UTC (permalink / raw)
To: emacs-orgmode; +Cc: chopps
[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]
From 25818bb40620311d7bb497320acafc175c9f4276 Mon Sep 17 00:00:00 2001
From: Christian Hopps <chopps@gmail.com>
Date: Fri, 20 Mar 2020 06:58:29 -0400
---
lisp/org-clock.el | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 345fd9b5a..c902635f9 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -2784,6 +2784,7 @@ a number of clock tables."
(pcase step
(`day "Daily report: ")
(`week "Weekly report starting on: ")
+ (`semimonth "Semimonthly report starting on: ")
(`month "Monthly report starting on: ")
(`year "Annual report starting on: ")
(_ (user-error "Unknown `:step' specification: %S" step))))
@@ -2833,6 +2834,9 @@ a number of clock tables."
(let ((offset (if (= dow week-start) 7
(mod (- week-start dow) 7))))
(list 0 0 org-extend-today-until (+ d offset) m y)))
+ (`semimonth (list 0 0 0
+ (if (< d 16) 16 1)
+ (if (< d 16) m (1+ m)) y))
(`month (list 0 0 0 month-start (1+ m) y))
(`year (list 0 0 org-extend-today-until 1 1 (1+ y)))))))
(table-begin (line-beginning-position 0))
--
2.25.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Add semimonth step for clocktables
2020-03-20 11:35 [PATCH] Add semimonth step for clocktables Christian Hopps
@ 2020-03-26 3:36 ` Kyle Meyer
0 siblings, 0 replies; 2+ messages in thread
From: Kyle Meyer @ 2020-03-26 3:36 UTC (permalink / raw)
To: Christian Hopps; +Cc: emacs-orgmode
Thanks for the patch. The change looks fine to me.
A few things:
* Please update the commit message to follow the instructions at
<https://orgmode.org/worg/org-contribute.html>.
* Please send git-format-patch output either via git-send-email or as
an attachment. (At least with my usual git-am incantations, the
best I was able to do with this email's patch was to make a commit
with the proper change but with an empty commit message, including
the subject.)
* In my opinion it'd be better to send this patch as a follow-up to
the thread for the initial patch at
<https://lists.gnu.org/archive/html/emacs-orgmode/2020-03/msg00115.html>.
That way, the conversation stays in one place, and those that gave
feedback initially are more likely to see the follow-up and provide
additional feedback.
Could you send an updated patch to the original thread?
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-26 3:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-20 11:35 [PATCH] Add semimonth step for clocktables Christian Hopps
2020-03-26 3:36 ` Kyle Meyer
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).