From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Danjou Subject: Re: Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)] Date: Mon, 17 Jan 2011 16:08:04 +0100 Message-ID: References: <87ei9a30tx.fsf@norang.ca> <87k4j2e1bb.fsf@noorul.maa.corp.collab.net> <87y67i0z5c.fsf@norang.ca> <87zkr3h3qv.fsf@norang.ca> <257A79BB-86AC-43E5-AE9D-132168283FFB@gmail.com> <87k4i7gz5a.fsf@norang.ca> <8739ord2r4.fsf@norang.ca> <97009C4F-F6B7-4C54-BF3C-B3DE5EF15547@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0537684160==" Return-path: Received: from [140.186.70.92] (port=38177 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Peqgj-00008l-LQ for emacs-orgmode@gnu.org; Mon, 17 Jan 2011 10:08:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Peqgi-00070b-De for emacs-orgmode@gnu.org; Mon, 17 Jan 2011 10:08:09 -0500 Received: from coquelicot-s.easter-eggs.com ([213.215.37.94]:51173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Peqgi-000705-7M for emacs-orgmode@gnu.org; Mon, 17 Jan 2011 10:08:08 -0500 In-Reply-To: <97009C4F-F6B7-4C54-BF3C-B3DE5EF15547@gmail.com> (Carsten Dominik's message of "Mon, 17 Jan 2011 15:39:10 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: Bernt Hansen , Org Mode , Noorul Islam K M --===============0537684160== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain On Mon, Jan 17 2011, Carsten Dominik wrote: > have you been following this thread? I think this has to do with your > rewrite of the dagenda span stuff. Maybe you can find out better and > faster that I why this goes wrong? Please read the entire thread. I've followed but not sure I understood what the bug is. But from my various tries, I found a bug: when pressing 'j', the current span is discarded. Attached is a patch that should fix that, even for future use of `org-agenda-list' with the span unspecified. :) --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-agenda-span-on-date-jump.patch Content-Transfer-Encoding: quoted-printable From=209dd2fe6650b858a4083ebc083bb8d10a0d6ac7f2 Mon Sep 17 00:00:00 2001 From: Julien Danjou Date: Mon, 17 Jan 2011 16:05:28 +0100 Subject: [PATCH] Fix agenda span on date jump * org-agenda.el (org-agenda-list): Use org-agenda-current-span as a possible default span if it is set. Signed-off-by: Julien Danjou =2D-- lisp/org-agenda.el | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 0cd620c..0d695b5 100644 =2D-- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -3450,7 +3450,10 @@ given in `org-agenda-start-on-weekday'." (setq org-agenda-last-arguments (list include-all start-day span)) (org-compile-prefix-format 'agenda) (org-set-sorting-strategy 'agenda) =2D (let* ((span (org-agenda-ndays-to-span (or span org-agenda-ndays org-a= genda-span))) + (let* ((span (org-agenda-ndays-to-span (or span + org-agenda-current-span + org-agenda-ndays + org-agenda-span))) (today (org-today)) (sd (or start-day today)) (ndays (org-agenda-span-to-ndays span sd)) =2D-=20 1.7.2.3 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable =2D-=20 Julien Danjou =E2=9D=B1 http://julien.danjou.info --=-=-=-- --==-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAk00W1QACgkQpGK1HsL+5c1KhgCgko3YtwigCrxw6hSCHeEn/kGe vWcAn3Vm+FeFFgOOg4sp7AkdygDg0ruj =wnSp -----END PGP SIGNATURE----- --==-=-=-- --===============0537684160== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --===============0537684160==--