From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gBQBAbN+kWAebAEAgWs5BA (envelope-from ) for ; Tue, 04 May 2021 19:04:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id gE5OOLJ+kWCTIAAA1q6Kng (envelope-from ) for ; Tue, 04 May 2021 17:04:50 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6ED49176FB for ; Tue, 4 May 2021 19:04:50 +0200 (CEST) Received: from localhost ([::1]:59692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldyTZ-0001qT-Ez for larch@yhetil.org; Tue, 04 May 2021 13:04:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldyKh-0004WQ-ER for emacs-orgmode@gnu.org; Tue, 04 May 2021 12:55:39 -0400 Received: from ciao.gmane.io ([116.202.254.214]:56520) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldyKg-0006vC-2q for emacs-orgmode@gnu.org; Tue, 04 May 2021 12:55:39 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1ldyKa-0007N3-5r for emacs-orgmode@gnu.org; Tue, 04 May 2021 18:55:32 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Maxim Nikulin Subject: Re: [PATCH] Bug: fragile org refile cache Date: Tue, 4 May 2021 23:55:26 +0700 Message-ID: References: <87v98598un.fsf@localhost> <87k0olxjpz.fsf@localhost> <877dklxecq.fsf@localhost> <875z01d3j3.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <875z01d3j3.fsf@localhost> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620147890; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=hdNAjvrlj21cJvmn+TY0G9k29vL4qycorIucsXfZzis=; b=SXMAz2kepGNZ/B3q6XMH58p75qWbzdfEwUi9/Oq8A8N9ZHU2uYOL1ysV3m6T5VjZmtc9v5 pCZ4kAiYhmuvg6Ax0e+gEBk8TFB+z8yX8yScl4OsGCbW8yManWlGyEddLqBSg4sHgPhs/F EZd9zDcqXl+cqLvCV2Nw4WUyNyKxB1dK0CkoKwVrB4OMnLjjV1O+qfxxNg95nmR/aijXGp 2uL/0RhKucgsxb1vJazhB8/unxyQ27kpvZY0ONeEe11v1Dg0XsoO2nlIxhzW6rODI5vzV+ VCkGQPgZWP7HRwzWFjJALr2PFWOQHwpUZqzaz7P4EJBA3pX6c8H1masEGMYtlw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620147890; a=rsa-sha256; cv=none; b=qNnY+BfC+GE7j13my3aCyEpfoReHhA9gR5mamFdo4LITKFZjSCWpyA2T3iLh09xeKkdpdL oNypGelzHW/8XFn2L4D5k/MIN4aLdrFk+iNItS/5St4C8Nf9XLG2eOxzaJ3eMsVTzNDQui FS89BagFMYEpAVORsyD0Dpfg5vSIddsb6Q4NVL81+cENyEY0uVP0ND5ldD20NI9Tg1VOsR w8+Q1SHp+t0LyY0cArTfnBddmQ0ksSb3KYC7HlXA+61MO1R3gKVfYfMNimxxzIjN7LHJOq 0IShvaVJ1ZhqnLUB+47MhdyjMm1cjDmBMzhjozzdpFTVtY1rTHGNnioBMiiWgQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.86 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 6ED49176FB X-Spam-Score: -1.86 X-Migadu-Scanner: scn0.migadu.com X-TUID: 40pLfbGOh8iS On 02/05/2021 13:59, Ihor Radchenko wrote: > Maxim Nikulin writes: > >> Some additions. org-outline-path-cache is used solely by >> org-refile-get-targets (maybe there are some calls in other packages) >> but it efficiency is questionable. It was not clear for me earlier that >> the cache is reset before each scan through a buffer. So if >> org-refile-use is disabled, org-outline-path-cache from previous run of >> org-refile or org-goto is not used as well. A query to >> org-outline-path-cache requires at least one backward search and hash >> lookup. During sequential scan in org-refile-get-targets it is enough to >> have previous heading path to update it when new heading is found. I >> think, org-outline-path-cache should be deprecated. > > At least helm-org-ql and helm-org are using `org-get-outline-path' with > cache. I do think it is useful. Though, indeed, not as fast as > single-pass scan. Probably, we can rewrite the code of > `org-get-outline-path' instead of deprecating it? helm-org-ql.el that is a part of org-ql does not use cache when calling org-get-outline-path. helm-org performs sequential scan similar to org-refile-get-targets. Maybe a new function should be introduced to address such case. On 29/04/2021 21:12, Ihor Radchenko wrote: > Note that Org mode has integration with imenu. It is an alternative you > can use to jump around current buffer. I do not see any advantages of imenu over jumping using org-goto or org-refile with enabled cache.