From: Maxim Nikulin <firstname.lastname@example.org> To: email@example.com Subject: Re: [PATCH] Bug: fragile org refile cache Date: Tue, 4 May 2021 23:55:26 +0700 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <875z01d3j3.fsf@localhost> On 02/05/2021 13:59, Ihor Radchenko wrote: > Maxim Nikulin writes: > >> Some additions. org-outline-path-cache is used solely by >> org-refile-get-targets (maybe there are some calls in other packages) >> but it efficiency is questionable. It was not clear for me earlier that >> the cache is reset before each scan through a buffer. So if >> org-refile-use is disabled, org-outline-path-cache from previous run of >> org-refile or org-goto is not used as well. A query to >> org-outline-path-cache requires at least one backward search and hash >> lookup. During sequential scan in org-refile-get-targets it is enough to >> have previous heading path to update it when new heading is found. I >> think, org-outline-path-cache should be deprecated. > > At least helm-org-ql and helm-org are using `org-get-outline-path' with > cache. I do think it is useful. Though, indeed, not as fast as > single-pass scan. Probably, we can rewrite the code of > `org-get-outline-path' instead of deprecating it? helm-org-ql.el that is a part of org-ql does not use cache when calling org-get-outline-path. helm-org performs sequential scan similar to org-refile-get-targets. Maybe a new function should be introduced to address such case. On 29/04/2021 21:12, Ihor Radchenko wrote: > Note that Org mode has integration with imenu. It is an alternative you > can use to jump around current buffer. I do not see any advantages of imenu over jumping using org-goto or org-refile with enabled cache.
next prev parent reply other threads:[~2021-05-04 17:04 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-28 16:09 Maxim Nikulin 2021-04-29 0:50 ` Samuel Wales 2021-04-29 1:29 ` Ihor Radchenko 2021-04-29 1:34 ` Samuel Wales 2021-04-29 12:45 ` Maxim Nikulin 2021-04-29 14:12 ` Ihor Radchenko 2021-04-29 15:04 ` Maxim Nikulin 2021-04-29 16:08 ` Ihor Radchenko 2021-04-29 16:51 ` Maxim Nikulin 2021-04-30 16:56 ` Maxim Nikulin 2021-05-01 14:48 ` Maxim Nikulin 2021-05-02 6:59 ` Ihor Radchenko 2021-05-04 16:55 ` Maxim Nikulin [this message] 2021-05-05 0:53 ` Ihor Radchenko 2021-04-29 13:30 ` Ihor Radchenko 2021-04-29 19:17 ` Tim Cross 2021-04-29 22:43 ` Samuel Wales 2021-05-02 7:03 ` Ihor Radchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com' \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] Bug: fragile org refile cache' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).