From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CPKQKVHLfmCW8gAAgWs5BA (envelope-from ) for ; Tue, 20 Apr 2021 14:38:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id OD0zJVHLfmB2EQAAbx9fmQ (envelope-from ) for ; Tue, 20 Apr 2021 12:38:41 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 257BF1CA8F for ; Tue, 20 Apr 2021 14:38:41 +0200 (CEST) Received: from localhost ([::1]:49252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYpeJ-0005V2-Gc for larch@yhetil.org; Tue, 20 Apr 2021 08:38:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYpde-0005Uk-1g for emacs-orgmode@gnu.org; Tue, 20 Apr 2021 08:37:58 -0400 Received: from ciao.gmane.io ([116.202.254.214]:45082) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYpdb-000740-PQ for emacs-orgmode@gnu.org; Tue, 20 Apr 2021 08:37:57 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lYpdY-00019I-Rq for emacs-orgmode@gnu.org; Tue, 20 Apr 2021 14:37:52 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Maxim Nikulin Subject: Re: [Patch] to correctly sort the items with emphasis marks in a list Date: Tue, 20 Apr 2021 19:37:46 +0700 Message-ID: References: <87a6qg1rjx.fsf@posteo.net> <874kgft7n1.fsf@nicolasgoaziou.fr> <87blanxb1z.fsf@posteo.net> <87lf9fa3ak.fsf@posteo.net> <87sg3n8f33.fsf@posteo.net> <87tuo2d670.fsf@nicolasgoaziou.fr> <87r1j6b6ku.fsf@nicolasgoaziou.fr> <87h7k2b1v6.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <87h7k2b1v6.fsf@nicolasgoaziou.fr> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618922321; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qJ3y3HVxmAeGEb/6VJn+EBtq/879BUlQsaXrnlGBh7A=; b=GR67Da7ZmnLIuSn1rR6yuKfKSjizipdhCTS6uuLpKRCkaHwDUA421M3ouTqHcTRiNxvid4 YirhOdRjhq61q6ifQ6vRWagnX3y7cRsSxt6hUSMRUeXQPC68WT+NxeIxyMWUmk8UB7aIVj zll5B1e4kyO3A5gLQ/Q0X8K2yHf/bdVOsbbnTWhnE/eAftlj/jnpQ2V8f82fP1L+pAdG2I O6sopQKudLHgx5FU2e6e3Gc0q+4tmgj/ua32mTRE0a5RBqJap6mJhePzNgIo+hn5e5hOVj RSGz9N5yQN1k5UtPV64sDTxuhWuJZxpYTng30YuCMRn6YxO0XG2/w6IkK8z6EQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618922321; a=rsa-sha256; cv=none; b=RO5OMIU+muXv1bMD/PIgbgYsKVQk3DsGT2s/JqxBs9XvXNJcMNMYdblS234DP4+SfzTUtP Qc0TNNPQG25dznKVDpd4+iX4mZsNSv/rcnu+biWG1HrcXb8PrFEJqguDXXcJ/NWamFLJWf QjEJhDD40eVusJYQ2ETTGV0Hnc6jy/Tg9dZYRiLI8mi0dEmZhWUhH06+tvIe3rkQ3h8RXx MfKtDT7TANXg/5T3pM+syDUnDC6ozcjxll/c/YHRx6O8mjdjpCCipFIkIZblzWPmDOfSp9 lW4Y72bUNUctCFROdD4DpB/DAvLwbLllrRq67cRn8CahjOhyn7ZTRlYZrXupgw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.84 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 257BF1CA8F X-Spam-Score: -1.84 X-Migadu-Scanner: scn0.migadu.com X-TUID: UtIXW3N063k5 On 20/04/2021 00:50, Nicolas Goaziou wrote: > Maxim Nikulin writes: > >> On 19/04/2021 23:08, Nicolas Goaziou wrote: >>>> + ;; Space role in sorting. >>>> + ;; Test would fail for locales with ignored space, e.g. en_US, it works >>>> + ;; in C and currently rare locales having significant space (es_ES, pl_PL) >>>> + (should >>>> + (equal "- Time stamp\n- Timer\n" >>>> + (org-test-with-temp-text "- Timer\n- Time stamp\n" >>>> + (org-sort-list t ?a) >>>> + (buffer-string)))))) >>> Since this test is bound to fail for some developers, I assume it >>> shouldn't be included. >> >> Locale "C" is forced for this group of tests. > > Sorry, I don't understand. There is no locale change around this test, > so it will fail, for example, for me. I wouldn't want to get a noisy > failure each time I run tests. Certainly flaky tests must be avoided. However I can not identify the source of confusion (yours or mine). There is redefinition of `string-collate-lessp' to run tests with "C" locale: https://code.orgmode.org/bzg/org-mode/src/master/testing/lisp/test-org-list.el#L1207 And it works for me #+begin_src elisp (let ((original-string-collate-lessp (symbol-function #'string-collate-lessp))) (cl-letf (((symbol-function 'string-collate-lessp) (lambda (s1 s2 &optional locale ignore-case) (funcall original-string-collate-lessp s1 s2 "C" ignore-case)))) (org-test-with-temp-text "- Timer\n- Time stamp\n" (org-sort-list t ?a) (buffer-string)))) #+end_src #+RESULTS: : - Time stamp : - Timer #+begin_src elisp (let ((original-string-collate-lessp (symbol-function #'string-collate-lessp))) (cl-letf (((symbol-function 'string-collate-lessp) (lambda (s1 s2 &optional locale ignore-case) (funcall original-string-collate-lessp s1 s2 "en_US.UTF-8" ignore-case)))) (org-test-with-temp-text "- Timer\n- Time stamp\n" (org-sort-list t ?a) (buffer-string)))) #+end_src #+RESULTS: : - Timer : - Time stamp glibc-2.31 (source for locales package), Ubuntu-20.04 focal, emacs-26.3 Could you, please, show result of the following command in your environment (for a chance that "C" locale definition has changed): printf 'Timestamp\nTime zone\n' \ | LC_ALL= LC_COLLATE= LANG=C.UTF-8 LANGUAGE=en sort --debug sort: using ‘C.UTF-8’ sorting rules Time zone _________ Timestamp _________