From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +2GdLIu5CWBObAAA0tVLHw (envelope-from ) for ; Thu, 21 Jan 2021 17:27:39 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id KMdCKIu5CWBAZAAAbx9fmQ (envelope-from ) for ; Thu, 21 Jan 2021 17:27:39 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 508929402C8 for ; Thu, 21 Jan 2021 17:27:39 +0000 (UTC) Received: from localhost ([::1]:36844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2dk9-000416-PA for larch@yhetil.org; Thu, 21 Jan 2021 12:27:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56676) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2deu-0008F6-TG for emacs-orgmode@gnu.org; Thu, 21 Jan 2021 12:22:12 -0500 Received: from ciao.gmane.io ([116.202.254.214]:40286) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2dVl-0004lt-Cc for emacs-orgmode@gnu.org; Thu, 21 Jan 2021 12:12:47 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1l2dVf-0007NI-1o for emacs-orgmode@gnu.org; Thu, 21 Jan 2021 18:12:39 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Maxim Nikulin Subject: Re: [PATCH] Re: [BUG] [C-u C-u C-c C-o] open link with external program invalid to open file Date: Fri, 22 Jan 2021 00:12:33 +0700 Message-ID: References: <87ftazz9q0.fsf@gmail.com> <87lfho7ja2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------50A839E6DB0BDCF7652515CB" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 29 X-Spam_score: 2.9 X-Spam_bar: ++ X-Spam_report: (2.9 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, GAPPY_SUBJECT=0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.75 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 508929402C8 X-Spam-Score: -1.75 X-Migadu-Scanner: scn0.migadu.com X-TUID: 9T6T0C1GDEQG This is a multi-part message in MIME format. --------------50A839E6DB0BDCF7652515CB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 21/01/2021 07:58, Christopher Miles wrote: > > I "=git am=" your first patch, but failed to apply your second patch. Seems not > continuous. So I modify code manually. I found I can't find the local variable > ~shell-command~, and ~shell-command-switch~. Can your provide complete patch? So I > can test it. Second patch is an alternative to the first one. I could do 'git apply org-open-file-make-process-min.patch' to the current master with no conflict. However you are right, it should be ~shell-file-name~, not ~shell-command~. There is a typo in ~shell-command-switch~. Both ~shell-file-name~ and ~shell-command-switch~ are defined in emacs sources, they are not local variables. I do not think that the first patch could be accepted in any form. Launching a handler without shell is a serious change. However trying to rewrite that part, I realized that original code has a problem. I intentionally do not add formal patch description since I suppose that error reporting should be improved. --------------50A839E6DB0BDCF7652515CB Content-Type: text/x-patch; charset=UTF-8; name="org-open-file-make-process-min-2.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="org-open-file-make-process-min-2.patch" diff --git a/lisp/org.el b/lisp/org.el index 5b1443c4e..cf9e46525 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -8765,7 +8765,9 @@ If the file does not exist, throw an error." (save-window-excursion (message "Running %s...done" cmd) - (start-process-shell-command cmd nil cmd) + (make-process :name "org-open-file" :connection-type 'pipe + :buffer "*Messages*" :noquery 't + :command (list shell-file-name shell-command-switch cmd)) (and (boundp 'org-wait) (numberp org-wait) (sit-for org-wait)))) ((or (stringp cmd) (eq cmd 'emacs)) --------------50A839E6DB0BDCF7652515CB--