From: Maxim Nikulin <email@example.com> To: firstname.lastname@example.org Subject: Re: [BUG] [C-u C-u C-c C-o] open link with external program invalid to open file Date: Wed, 20 Jan 2021 23:27:10 +0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <PAXPR08MB6640EE1EF84F0C28A5201631A3A20@PAXPR08MB6640.eurprd08.prod.outlook.com> [-- Attachment #1: Type: text/plain, Size: 1017 bytes --] On 20/01/2021 10:21, Christopher Miles wrote: > > Thanks for your working. I will modify my mailcap config temporary until Org > Mode fix this issue. You're right, this change might break some behavior of some > users. I don't understand Emacs sub-process mechanism. Can't help on this > problem. But I'm interested in this. I will take some time to study in. Anyway, > thanks for your work. Changes could be less intrusive, see another (untested) patch. However I am against shell where it is really necessary. Personally, I am not comfortable with emacs subprocess functions as well. I just tried to avoid creation of a pseudoterminal that could make some harm to GUI application. I do not know if someone uses a handler that really require terminal features. I have realized that :filter argument is not appropriate to arbitrary handler that could spam with various assert messages. Maybe :sentinel is better to report configuration problem to user when handler is called with inappropriate arguments. [-- Attachment #2: org-open-file-make-process-min.patch --] [-- Type: text/x-patch, Size: 568 bytes --] diff --git a/lisp/org.el b/lisp/org.el index 5b1443c4e..43838783b 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -8765,7 +8765,9 @@ If the file does not exist, throw an error." (save-window-excursion (message "Running %s...done" cmd) - (start-process-shell-command cmd nil cmd) + (make-process :name "org-open-file" :connection-type 'pipe + :buffer "*Messages*" :noquery 't + :command (list shell-command shell-commad-switch cmd)) (and (boundp 'org-wait) (numberp org-wait) (sit-for org-wait)))) ((or (stringp cmd) (eq cmd 'emacs))
next prev parent reply other threads:[~2021-01-20 16:35 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-13 7:49 stardiviner 2020-06-13 14:51 ` Nicolas Goaziou 2020-06-14 9:08 ` stardiviner 2020-06-14 21:06 ` Nicolas Goaziou 2021-01-10 11:26 ` [BUG] [C-u C-u C-c C-o] open link with external program auto exited before child process " Christopher Miles [not found] ` <87sg799gnx.fsf@numbchild> 2021-01-10 12:13 ` Christopher Miles 2020-09-05 7:52 ` [BUG] [C-u C-u C-c C-o] open link with external program invalid to " Bastien 2021-01-18 16:32 ` Maxim Nikulin 2021-01-19 1:53 ` Christopher Miles 2021-01-19 17:00 ` Maxim Nikulin 2021-01-20 3:21 ` Christopher Miles 2021-01-20 16:27 ` Maxim Nikulin [this message] 2021-01-21 0:58 ` [PATCH] " Christopher Miles 2021-01-21 17:12 ` Maxim Nikulin 2021-01-22 6:00 ` Christopher Miles 2021-03-10 14:55 ` Maxim Nikulin 2021-03-11 9:33 ` Christopher Miles
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org' \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [BUG] [C-u C-u C-c C-o] open link with external program invalid to open file' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).