From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glenn Morris Subject: bug#15887: Possibly incorrect custom :types Date: Thu, 14 Nov 2013 12:18:04 -0500 Message-ID: References: <87habfw2jp.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vh0ZL-00054Y-Di for emacs-orgmode@gnu.org; Thu, 14 Nov 2013 12:19:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vh0ZK-0002hn-4K for emacs-orgmode@gnu.org; Thu, 14 Nov 2013 12:19:03 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:38373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vh0ZK-0002hj-16 for emacs-orgmode@gnu.org; Thu, 14 Nov 2013 12:19:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vh0ZJ-0002Th-MT for emacs-orgmode@gnu.org; Thu, 14 Nov 2013 12:19:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87habfw2jp.fsf@bzg.ath.cx> (Bastien's message of "Thu, 14 Nov 2013 14:11:54 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: 15887@debbugs.gnu.org I glanced at the diff. I'm not sure the :set changes are correct. Won't this make it impossible to customize these options? Those cases may have been some of the false positives I mentioned. Eg (if (or (featurep 'xemacs) (featurep 'python-mode)) 'python-mode 'python) is fine for :type 'function, but cus-test is simple-minded and doesn't realize that the result of the expression will always be a function, so it gives a bogus warning.