From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rodrigo Amestica <ramestica@gmail.com>
Subject: Re: capture template property :kill-buffer does not let me refile
Date: Wed, 06 Nov 2013 10:17:45 -0500
Message-ID: <ybi1u2tbluu.wl%ramestica@gmail.com>
References: <ybifvrp7yhi.wl%ramestica@gmail.com>
	<ybieh768y8c.wl%ramestica@gmail.com>
	<ybifvrmyxl3.wl%ramestica@gmail.com> <87ob5xk5oe.fsf@bzg.ath.cx>
Mime-Version: 1.0 (generated by SEMI 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55191)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ramestica@gmail.com>) id 1Ve4rz-0001BV-MY
	for emacs-orgmode@gnu.org; Wed, 06 Nov 2013 10:18:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ramestica@gmail.com>) id 1Ve4rr-0003zr-4u
	for emacs-orgmode@gnu.org; Wed, 06 Nov 2013 10:18:11 -0500
In-Reply-To: <87ob5xk5oe.fsf@bzg.ath.cx>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org

At Wed, 06 Nov 2013 14:42:25 +0100,
Bastien wrote:
> 
> [1  <text/plain (7bit)>]
> Hi Rodrigo,
> 
> Rodrigo Amestica <ramestica@gmail.com> writes:
> 
> > based on 'printf' type logging I have found one solution that looks to me like a
> > bug fix in org-capture-refile. But I'm obviously far from guessing any side
> > effect that I could be missing.
> >
> > In org-capture-refile if I move org-capture-finalize after the
> > save-window-excursion form then the :kill-buffer option works as expected
> > without interfering with the refile operation.
> >
> > I meant to say a bug fix because to me it sounds more reasonable to call
> > org-capture-finalize really when finished, in this specific case after refile.
> >
> > Does that make sense?
> 
> Yes it does -- I attach a patch, can you confirm it is what you did
> and it does what you want?

yes, that's what I did and it works as I expected. 

many thanks,
 Rodrigo

> 
> Also, I'd be glad if a few others could test the patch so that we can
> make more sure there are no side-effects -- I could not think of any.
> 
> Thanks,
> 
> [2 org-capture-refile.patch <text/x-diff (7bit)>]
> diff --git a/lisp/org-capture.el b/lisp/org-capture.el
> index 871382d..b832798 100644
> --- a/lisp/org-capture.el
> +++ b/lisp/org-capture.el
> @@ -787,14 +787,14 @@ already gone.  Any prefix argument will be passed to the refile command."
>    (let ((pos (point))
>  	(base (buffer-base-buffer (current-buffer)))
>  	(org-refile-for-capture t))
> -    (org-capture-finalize)
>      (save-window-excursion
>        (with-current-buffer (or base (current-buffer))
>  	(save-excursion
>  	  (save-restriction
>  	    (widen)
>  	    (goto-char pos)
> -	    (call-interactively 'org-refile)))))))
> +	    (call-interactively 'org-refile)))))
> +    (org-capture-finalize)))
>  
>  (defun org-capture-kill ()
>    "Abort the current capture process."
> [3  <text/plain (7bit)>]
> 
> -- 
>  Bastien