emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [POLL] Dealing with +1m/y repeaters when jumping to impossible date (should 05-31 +1m be 07-01 or 06-30?)
Date: Tue, 14 May 2024 18:08:20 +0700	[thread overview]
Message-ID: <v1vgn6$6io$1@ciao.gmane.io> (raw)
In-Reply-To: <87v83if2io.fsf@localhost>

On 13/05/2024 17:07, Ihor Radchenko wrote:
> 
> However, there are still some issues remaining.
> When updating timestamps repeating monthly across months with 30, 31,
> and 28 days we get
> 
> <2025-01-31 Fri +1m>
> <2025-02-28 Fri +1m>
> <2025-03-28 Fri +1m>
> ...
> <2026-01-28 Wed +1m>

Instead of using timestamp obtained on previous step, use original 
timestamp and multiple of the interval.

I have the following in my notes. However I have not find suitable 
functions in elisp:

https://debbugs.gnu.org/54764#10
Paul Eggert. Sat, 9 Apr 2022 00:52:57 -0700
> Generally speaking, 
> when Org mode is doing calendrical calculations it should use 
> calendrical functions rather than encode-time+decode-time, which are 
> best used for time calculations not calendar calculations.

Do you have any idea what Paul was writing about?

On 13/05/2024 17:07, Ihor Radchenko wrote:
> +           (type-unit (pcase type
> +                        ("h" 'hour) ("d" 'day) ("w" 'week)
> +                        ("m" 'month) ("y" 'year))))
I do not mind against `pcase' here, I just expected something like 
`assoc' and `string-to-char'.

> +	      ((or "m" "y")
Another comment that may be ignored: `type-unit' values might be used here.

> +          (org-encode-time
> +           (list
> +            (+ (if (eq unit 'second) value 0) (decoded-time-second time))
> +            (+ (if (eq unit 'minute) value 0) (decoded-time-minute time))
> +            (+ (if (eq unit 'hour) value 0)   (decoded-time-hour time))
> +            (+ (if (eq unit 'day) value 0)    (decoded-time-day time))

Have you considered using `min' with result of `date-days-in-month' here 
(or its sibling from timezone.el)?

> +(defun org-time-inc (unit value time)
Is there a chance that support of intervals like 1h20m will be required 
later?

> +            (+ (if (eq unit 'month) value 0)  (decoded-time-month time))
> +            (+ (if (eq unit 'year) value 0)   (decoded-time-year time))
> +            (decoded-time-weekday time)
> +            (if (memq unit '(day month year))
> +                nil ; Avoid auto-adjustments of time when jumping across DST.

Sorry, but you have to use -1, otherwise

(format-time-string
  "%F %T %Z %z"
  (encode-time '(0 30 12 15 1 2000 'ignored nil "Africa/Juba"))
  "Africa/Juba")
(error "Specified time is not representable")

> +              (decoded-time-dst time))
> +            (decoded-time-zone time))))))
> +    (if (not org-repeat-round-time) new-time
I am in doubts if `org-time-inc' should access `org-repeat-round-time' 
directly or its value should be passed as an explicit argument. Perhaps 
the additional argument may be optional with fallback to 
`org-repeat-round-time' when it is omitted.





  reply	other threads:[~2024-05-14 11:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-29 10:48 Leap-year bug with todo-cycle Anton Haglund
2024-04-05 18:34 ` [POLL] Dealing with +1m/y repeaters when jumping to impossible date (should 05-31 +1m be 07-01 or 06-30?) (was: Leap-year bug with todo-cycle) Ihor Radchenko
2024-04-05 19:53   ` Russell Adams
2024-04-05 21:18   ` jman
2024-04-05 21:27     ` Ihor Radchenko
2024-04-06 14:52   ` [POLL] Dealing with +1m/y repeaters when jumping to impossible date (should 05-31 +1m be 07-01 or 06-30?) Max Nikulin
2024-04-07 11:47     ` Ihor Radchenko
2024-05-13 10:07   ` [POLL] Dealing with +1m/y repeaters when jumping to impossible date (should 05-31 +1m be 07-01 or 06-30?) (was: Leap-year bug with todo-cycle) Ihor Radchenko
2024-05-14 11:08     ` Max Nikulin [this message]
2024-05-14 12:56       ` [POLL] Dealing with +1m/y repeaters when jumping to impossible date (should 05-31 +1m be 07-01 or 06-30?) Ihor Radchenko
2024-05-14 13:10         ` Stefan Nobis
2024-05-18 11:40           ` Ihor Radchenko
2024-05-18 12:49             ` Stefan Nobis
2024-05-18 13:09               ` Ihor Radchenko
2024-05-18 14:26                 ` Stefan Nobis
2024-05-18 14:35                   ` Ihor Radchenko
2024-05-15 11:04         ` Max Nikulin
2024-05-18 11:50           ` Ihor Radchenko
2024-05-16 10:41         ` Max Nikulin
2024-05-18 11:56           ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='v1vgn6$6io$1@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).