emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [DISCUSSION] Sorting strings in Org mode vs. system locale
Date: Tue, 7 May 2024 18:06:17 +0700	[thread overview]
Message-ID: <v1d1vb$51n$1@ciao.gmane.io> (raw)
In-Reply-To: <87fruwtqo8.fsf@localhost>

On 05/05/2024 18:59, Ihor Radchenko wrote:
> Ihor Radchenko writes:
> 
>>> If a user access same files from Linux and macOS then it
>>> may be really annoying to get different order of entries in agenda. For
>>> most of Linux users it is better to use more smart
>>> `string-collate-lessp'. Some care is required to sort entries obtained
>>> from multiple buffers in predictable environment (locale, case
>>> conversion table).
>>
>> I agree. We can introduce a new customization -
>> `org-string-sort-function' that will be used across Org mode to sort
>> user text.
> 
> See the attached tentative patch.
> I added a customization, made everything in Org obey it, and provided
> some default options for MacOS users.

Contrary to Eli, I still think that there are enough locales where 
completely disregarding IGNORE-CASE is worse than fallback to `downcase' 
when IGNORE-CASE is t. Perhaps some kind of normalization (NFD?) may 
improve results further.

I consider the following as a kind of graceful degradation

(defun org-sort-function-fallback-downcase
    (a b &optional LOCALE IGNORE-CASE)
  (if ignore-case
     (string-collate-lessp (downcase a) (downcase b) locale ignore-case)
   (string-collate-lessp a b locale ignore-case)))

(defcustom org-sort-function
  (if (string-collate-lessp "a" "B" "C" t)
     #'string-collate-lessp
   #'org-sort-function-fallback-downcase))

I would consider a setter function for `org-sort-function' to avoid 
branches based of `func-arity' in `org-string<'.

I see a little point in purely downcase comparator 
`org-sort-function-downcase'.



  reply	other threads:[~2024-05-07 11:07 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06 20:15 test-org-table/sort-lines: Failing test on macOS Rudolf Adamkovič
2022-10-07 12:04 ` Max Nikulin
2022-10-08  5:25   ` Ihor Radchenko
2022-10-08 14:27     ` Max Nikulin
2022-10-09  3:59       ` Ihor Radchenko
2022-10-09 15:38         ` Rudolf Adamkovič
2022-10-09 16:53           ` Max Nikulin
2022-10-10 22:25             ` Rudolf Adamkovič
2022-10-12 16:09               ` Max Nikulin
2022-11-15  4:10                 ` Ihor Radchenko
2022-11-20  4:18                   ` Ihor Radchenko
2022-11-20  8:00                     ` Max Nikulin
2022-11-21  3:15                       ` Ihor Radchenko
2022-11-21 16:48                         ` Max Nikulin
2022-11-22  1:14                           ` Ihor Radchenko
2022-11-22 16:01                             ` Max Nikulin
2022-11-23 10:37                               ` Ihor Radchenko
2022-11-23 15:27                                 ` Max Nikulin
2022-11-23 17:01                                   ` Max Nikulin
2022-11-26  2:05                                   ` Ihor Radchenko
2022-11-29 16:40                                     ` Max Nikulin
2024-04-03 11:40                                       ` [DISCUSSION] Sorting strings in Org mode vs. system locale (was: test-org-table/sort-lines: Failing test on macOS) Ihor Radchenko
2024-05-05 11:59                                         ` Ihor Radchenko
2024-05-07 11:06                                           ` Max Nikulin [this message]
2024-05-07 13:09                                             ` [DISCUSSION] Sorting strings in Org mode vs. system locale Ihor Radchenko
2024-05-07 16:47                                               ` Max Nikulin
2024-05-11  9:38                                                 ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='v1d1vb$51n$1@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).