From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id yLaKD0fgKGY8OwEAe85BDQ:P1 (envelope-from ) for ; Wed, 24 Apr 2024 12:34:47 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id yLaKD0fgKGY8OwEAe85BDQ (envelope-from ) for ; Wed, 24 Apr 2024 12:34:47 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713954887; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=fS5/SnVwRXQK8+3trKefG4JwRokJjnVpw+59ibHoi58=; b=qnXYpyn1op/Q5juND6D+wDF7iJa0JcI6atJVTwB4raBR2TLUuU3jSq4hpAo6lZDw/vGkl2 yAlIfqSaex+mPb/aE0HOOCeBEXNZBbka/OyUKjskry5BECiMQCT3y2GE+9rpRkuVjzbJg7 D/jV/rVlaQ3gC4SqFw6Lndugd2h46q8KA8ScznqxecaZerdVGZ1tvoePapVPDTjSz0/zZC J4wLTSfj60xMggMrUjgT738Fn9LzGf0JV4NT0sSFr1Mfm+iGYWM0jSOt3gPSB2tz4Ghlra YUDLajCAfusDJxwcqkt5NyamvxHn9pL2dQkDUfcmixpNZxM2aIe/s7Lo33jHKw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713954887; a=rsa-sha256; cv=none; b=pCv8+wPrmrlDC8sVhC9lQkUMDQNBT8rqT8nYIXTLUo25BfLZI0pqWL4dDAvFpgj6vi7kWH WYQeUPPTnwN5pWlauf2pafWuTWmj/EwA9FMeb4uLsU1JtIkBKsaptq11ttkI34mwGe99Ua GAZyJxLJMwOpzCLzVLtsDvzFPYtW4kgpwaHv+QV2vNV6hieGMitasBesA5B8ir4IxgNrtN 0nIYofkKfxTIR/sb2NdEK2/r7XMG3AaTI6fdQwKqqgU5b1Jha8XRaQpJFh59LbVd9cS9Wh OU1UhE24/34okHKUC2Le5bzonf51kVu6gnYqJBHmNTXLnQEkYaaWAL7B+o8rzw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0E1AF3BC33 for ; Wed, 24 Apr 2024 12:34:46 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzZwn-0000PB-A8; Wed, 24 Apr 2024 06:33:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzZwl-0000Ot-Rg for emacs-orgmode@gnu.org; Wed, 24 Apr 2024 06:33:51 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzZwk-0006ZN-67 for emacs-orgmode@gnu.org; Wed, 24 Apr 2024 06:33:51 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rzZwi-0001DI-6u for emacs-orgmode@gnu.org; Wed, 24 Apr 2024 12:33:48 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] Re: [BUG] ob-shell: :shebang changes interpretation of :cmdline Date: Wed, 24 Apr 2024 17:33:37 +0700 Message-ID: References: <18f01342a2f.124ad27612732529.8693431365849276517@excalamus.com> <878r14qso9.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla Thunderbird Content-Language: en-US, ru-RU In-Reply-To: <878r14qso9.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 26 X-Spam_score: 2.6 X-Spam_bar: ++ X-Spam_report: (2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.78 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -5.78 X-Migadu-Queue-Id: 0E1AF3BC33 X-TUID: 1FXXZssswadc On 23/04/2024 17:28, Ihor Radchenko wrote: > > I propose the attached patch. > +++ b/lisp/ob-shell.el > @@ -322,14 +322,12 @@ (defun org-babel-sh-evaluate (session body &optional params stdin cmdline) > (with-temp-buffer > (with-connection-local-variables > (apply #'process-file > - (if shebang (file-local-name script-file) > - shell-file-name) > + shell-file-name > stdin-file > (current-buffer) > nil > - (if shebang (when cmdline (list cmdline)) > - (list shell-command-switch > - (concat (file-local-name script-file) " " cmdline))))) > + (list shell-command-switch > + (concat (file-local-name script-file) " " cmdline)))) Using `shell-command-switch' unconditionally may lead to executing /bin/sh instead of shell specified by `shell-file-name' for script files having no shebang, see https://superuser.com/questions/502984/writing-shell-scripts-that-will-run-on-any-shell-using-multiple-shebang-lines > The kernel refuses to execute such scripts and returns ENOEXEC, so the > exact behavior depends on the program you run such a script /from/. > > - bash 4.2.39 -- uses itself > - busybox-ash 1.20.2 -- uses itself > - dash 0.5.7 -- runs /bin/sh > - fish 1.23.1 -- complains about ENOEXEC, then blames the wrong file > - AT&T ksh 93u+2012.08.01 -- uses itself > - mksh R40f -- runs /bin/sh > - pdksh 5.2.14 -- runs /bin/sh > - sh-heirloom 050706 -- uses itself > - tcsh 6.18.01 -- runs /bin/sh > - zsh 5.0.0 -- runs /bin/sh > - cmd.exe 5.1.2600 -- looks at you funny I am not going to spend time testing current versions. I believe, multiple arguments should be specified as '(1 a "b c"). With shebang (as header arg or as part of the body) command should be /path/to/script [ARGUMENT]... when there is no shebang /shell/executable /path/to/script [ARGUMENT]...