From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tokuya Kameshima Subject: Re: Please test links Date: Sun, 16 Mar 2008 23:47:04 +0900 Message-ID: Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jau9Y-00036i-DY for emacs-orgmode@gnu.org; Sun, 16 Mar 2008 10:48:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jau9X-00036P-Rk for emacs-orgmode@gnu.org; Sun, 16 Mar 2008 10:48:00 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jau9X-00036I-Fv for emacs-orgmode@gnu.org; Sun, 16 Mar 2008 10:47:59 -0400 Received: from mail.ms.so-net.ne.jp ([202.238.82.30] helo=mx08.ms.so-net.ne.jp) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Jau9W-0005B3-PP for emacs-orgmode@gnu.org; Sun, 16 Mar 2008 10:47:59 -0400 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik , emacs-orgmode@gnu.org Cc: kames@fa2.so-net.ne.jp Hi Carsten, I checked org-wl.el and it works fine. BTW, I have another implementation of org-wl.el. Is it possible to merge my version to the git? The differences between git version and mine are: - Integrated `org-wl-open' function into `org-wl-open'. - org-wl-store-link: If the message on the cursor line is marked as refile ("o"), set the link's folder to the refile destionation folder. I prefer this behavior since I read the email in the inbox folder, set the refile mark, and create TODO task using remember package from the email before performing the refile operation. After I create tasks, I execute the refile. - Fixed "To:" field extraction problem where the function `elmo-message-entity-field' returns a string or a list of strings. - org-wl-open: Added a workaround for `wl-folder-goto-folder-subr', which moves point to the beginning of the current line in the old folder. Thanks, --Tokuya > From: Carsten Dominik science.uva.nl> > Subject: Re: Re: Please test links > Newsgroups: gmane.emacs.orgmode > Date: 2008-03-15 20:35:49 GMT (17 hours and 38 minutes ago) > > At least we got you to learn git! :-) > > Thanks for the analysis, I have fixed this problem for all link > packages, thanks a lot!!! > > Please, everyone, git it another shot. > > Ahh, I don't know what I would do without all this help. > > - Carsten ;;; org-wl.el - Support for links to Wanderlust messages in Org-mode ;; Copyright (C) 2004, 2005, 2006, 2007, 2008 Free Software Foundation, Inc. ;; Author: Carsten Dominik ;; Keywords: outlines, hypermedia, calendar, wp ;; Homepage: http://orgmode.org ;; Version: 1.0 ;; ;; This file is part of GNU Emacs. ;; ;; GNU Emacs is free software; you can redistribute it and/or modify ;; it under the terms of the GNU General Public License as published by ;; the Free Software Foundation; either version 3, or (at your option) ;; any later version. ;; GNU Emacs is distributed in the hope that it will be useful, ;; but WITHOUT ANY WARRANTY; without even the implied warranty of ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the ;; GNU General Public License for more details. ;; You should have received a copy of the GNU General Public License ;; along with GNU Emacs; see the file COPYING. If not, write to the ;; Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, ;; Boston, MA 02110-1301, USA. ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;; ;;; Commentary: ;; This file implements links to Wanderlust messages for Org-mode. ;; Org-mode loads this module by default - if this is not what you want, ;; configure the variable `org-modules'. (require 'org) ;; Declare external functions and variables (declare-function elmo-folder-exists-p "ext:elmo" (folder) t) (declare-function elmo-message-entity-field "ext:elmo-msgdb" (entity field &optional type)) (declare-function elmo-message-field "ext:elmo" (folder number field &optional type) t) (declare-function elmo-msgdb-overview-get-entity "ext:elmo" (&rest unknown) t) ;; Backward compatibility to old version of wl (declare-function wl-summary-buffer-msgdb "ext:wl-folder" (&rest unknown) t) (declare-function wl-folder-get-elmo-folder "ext:wl-folder" (entity &optional no-cache)) (declare-function wl-summary-goto-folder-subr "ext:wl-summary" (&optional name scan-type other-window sticky interactive scoring force-exit)) (declare-function wl-summary-jump-to-msg-by-message-id "ext:wl-summary" (&optional id)) (declare-function wl-summary-line-from "ext:wl-summary" ()) (declare-function wl-summary-line-subject "ext:wl-summary" ()) (declare-function wl-summary-message-number "ext:wl-summary" ()) (declare-function wl-summary-redisplay "ext:wl-summary" (&optional arg)) (defvar wl-summary-buffer-elmo-folder) (defvar wl-summary-buffer-folder-name) (defvar wl-summary-buffer-temp-mark-list) ;; Install the link type (org-add-link-type "wl" 'org-wl-open) (add-hook 'org-store-link-functions 'org-wl-store-link) ;; Implementation (defun org-wl-store-link () "Store a link to an WL folder or message." (when (eq major-mode 'wl-summary-mode) (let* ((msgnum (wl-summary-message-number)) (folder-name (let ((elem (assq msgnum wl-summary-buffer-temp-mark-list))) (if (equal (nth 1 elem) "o") ; marked as refile (nth 2 elem) wl-summary-buffer-folder-name))) (message-id (elmo-message-field wl-summary-buffer-elmo-folder msgnum 'message-id)) (wl-message-entity (if (fboundp 'elmo-message-entity) (elmo-message-entity wl-summary-buffer-elmo-folder msgnum) (elmo-msgdb-overview-get-entity msgnum (wl-summary-buffer-msgdb)))) (from (wl-summary-line-from)) (to (let ((to-field (elmo-message-entity-field wl-message-entity 'to))) (if (listp to-field) (car to-field) to-field))) (subject (let (wl-thr-indent-string wl-parent-message-entity) (wl-summary-line-subject))) desc link) (org-store-link-props :type "wl" :from from :to to :subject subject :message-id message-id) (setq message-id (org-remove-angle-brackets message-id)) (setq desc (org-email-link-description)) (setq link (org-make-link "wl:" folder-name "#" message-id)) (org-add-link-props :link link :description desc) link))) (defun org-wl-open (path) "Follow an WL message link." ;; XXX: The imap-uw's MH folder names start with "%#". (if (not (string-match "\\`\\(\\(?:%#\\)?[^#]+\\)\\(#\\(.*\\)\\)?" path)) (error "Error in Wanderlust link")) (let ((folder (match-string 1 path)) (article (match-string 3 path))) (if (not (elmo-folder-exists-p (wl-folder-get-elmo-folder folder))) (error "No such folder: %s" folder)) (let ((old-buf (current-buffer)) (old-point (point-marker))) (wl-folder-goto-folder-subr folder) (save-excursion ;; XXX: `wl-folder-goto-folder-subr' moves point to the ;; beginning of the current line. So, restore the point ;; in the old buffer. (set-buffer old-buf) (goto-char old-point)) (wl-thread-open-all) (and (wl-summary-jump-to-msg-by-message-id (org-add-angle-brackets article)) (wl-summary-redisplay))))) (provide 'org-wl) ;;; org-wl.el ends here