From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Kettleborough Subject: Re: Org Clock Timer in Frame Title bug Date: Sat, 28 Apr 2012 13:51:45 +0100 Message-ID: References: <8DD2D644-3CB5-4F40-9801-90C3AA577438@pobox.com> <87d37038b7.fsf@fastmail.fm> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([208.118.235.92]:53922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SO77v-0006DP-57 for emacs-orgmode@gnu.org; Sat, 28 Apr 2012 08:51:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SO77t-0007jI-A1 for emacs-orgmode@gnu.org; Sat, 28 Apr 2012 08:51:50 -0400 Received: from ueamailgate02.uea.ac.uk ([139.222.131.185]:35243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SO77t-0007j9-1M for emacs-orgmode@gnu.org; Sat, 28 Apr 2012 08:51:49 -0400 In-Reply-To: <87d37038b7.fsf@fastmail.fm> (Matt Lundin's message of "Sun, 22 Apr 2012 01:43:24 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Matt Lundin Cc: "emacs-orgmode@gnu.org" , Mike McLean On Sun, Apr 22 2012, Matt Lundin wrote: > Mike McLean writes: > >> It appears that there is a small problem with commit >> 37fafb7b9e4e8e1eeb6b8faa76a1621c28970ef5 (Option for clock and timer to >> be displayed in frame-title). The default value offrame-title-format in >> my setup is t and this causes an error when clocking in/out. > > I can confirm this bug. The problem is that org-clock-out calls a delq > on frame-title-format regardless of the value of > org-clock-clocked-in-display. This is a problem because > frame-title-format can be either a list or a string. Note: the same > problem will occur when calling org-clock-in if the value of > frame-title-format is a string and if org-clock-clocked-in-display is > set to 'frame-title. Checking (listp frame-title-format) ensures there will be no error when calling delq, but it doesn't fix the feature. If the user's frame-title-format is not a list then the feature will not work for no apparent reason. The same thing goes for global-mode-string too, which the current release of org-mode modifies. For the clock and timer display features to work as intended both of these variables need to be lists with either a string or a list as the first element. Note that simply being a list is not enough, it must contain a string or list as first element. This format causes the elements of the list to be treated as mode-line-formats recursively. The following in both org-clock.el and org-timer.el will ensure both variables have the correct format to begin with: (unless (and (listp frame-title-format) (or (stringp (first frame-title-format)) (listp (first frame-title-format)))) (setq frame-title-format (list "" frame-title-format))) (unless (and (listp global-mode-string) (or (stringp (first global-mode-string)) (listp (first global-mode-string)))) (setq global-mode-string (list "" global-mode-string))) It might be better to do this just once in org.el or org-install.el, since maybe other modules might want to put stuff in the mode-line or frame-title. Of course the user or another mode might edit either of the variables to something bad (like a symbol or string) afterwards. Maybe this should be done every time before clock-in/timer-start or any time we wish to append stuff to either of these lists? Thanks, George.