From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 6ApTLdQc+GUsjgAAe85BDQ:P1 (envelope-from ) for ; Mon, 18 Mar 2024 11:52:04 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 6ApTLdQc+GUsjgAAe85BDQ (envelope-from ) for ; Mon, 18 Mar 2024 11:52:04 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1710759124; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=HKiE62iw0ij0udvlr1wRuQDEBFiMNhNwz7Ftc5fmPPE=; b=XToVOqiGB4nuKQamoEdtf3o0K7MIGKEGtWCZLwyThnjtsrz3UbXr75kXZkpS4d9xOtXSM8 2eTxgXd9KaLFEH6HC1PEjFawiIGSXW/fwJhWsS4ZemiVXfp2AwyF45Yci9PeTHWmHqwwCY stB9Ikv/cUotogWFJaOhCisurW6O1GbBKHgrU/IZ1H/UbuW7TUBt1peNsVIKSkrL6yAeD3 FTmkbGLklPTEx4YBzClrYxBFs0/+zY0KzSJF7I8a9O1qnA5ElW9azEKY2zXKF3W6SUZppS AGCL/gHZil8a3YUxj605dAjt2Jha7ogMXwGgZG6kahuGNO68Rha62A7DCLvG9A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1710759124; a=rsa-sha256; cv=none; b=eE9LoDSrGOMeeBJwM+ROgl9jXxD8IYoU59oCPEUoX7571w7aYMq9FbuTRD71t4GzY1T6jO 73A+rwtvkR1jAfmkFCKJibTEqxjG/CIiICgGfhGKdpO1Blexj1qXuN9vbK2wEsin7rKG26 ROUaT/tXAPQ8UN0YgQfa0UjvvJ3DF5aOsgVKyQGDrL6L6AFdzriBVoGr6LO+wIgKCzpZ1j m/EaD2cMumz09mQ4PSnnYifrSyWyCWOi3J+A9+W8UgGepxasuViiroRLaG2VA53a3K8bU4 flAOXtVJCaL4rDYuk8meEB5Z75JC6X5vPbkiuyeqwfZHYhkkG3Ox/YexiwRcsg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 783BC375F6 for ; Mon, 18 Mar 2024 11:52:04 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmAa6-0007Rf-It; Mon, 18 Mar 2024 06:51:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmAa5-0007MO-8E for emacs-orgmode@gnu.org; Mon, 18 Mar 2024 06:51:01 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmAa3-000580-CJ for emacs-orgmode@gnu.org; Mon, 18 Mar 2024 06:51:00 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rmAa0-00055x-5Q for emacs-orgmode@gnu.org; Mon, 18 Mar 2024 11:50:56 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: Warn about shell-expansion in the docstring of org-latex-to-html-convert-command Date: Mon, 18 Mar 2024 17:50:46 +0700 Message-ID: References: <87wmr1rc2w.fsf@localhost> <874jdzjqkk.fsf@localhost> <6e49c590-ad27-4fb0-b1f2-6a89c60a0b58@gmail.com> <87msrncxhq.fsf@localhost> <735645dd-1ddf-4579-a6dd-2700f3e83c94@gmail.com> <87jzmdht2w.fsf@localhost> <87v85rd2m2.fsf@localhost> <87v85nip0g.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla Thunderbird Content-Language: en-US, ru-RU In-Reply-To: <87v85nip0g.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 26 X-Spam_score: 2.6 X-Spam_bar: ++ X-Spam_report: (2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -0.80 X-Spam-Score: -0.80 X-Migadu-Queue-Id: 783BC375F6 X-TUID: kE9uHswLfrgI On 15/03/2024 20:49, Ihor Radchenko wrote: > Max Nikulin writes: >> On 12/03/2024 20:03, Ihor Radchenko wrote: >> - '%i' and "%i" in any position including e.g. --option='%i' and >> protocol:"%i" >> - 'something%i' and "something%i" surrounded by spaces or at the end of >> command but with no spaces in "something". > > I am not confident that it will be safe. For example, consider something > awkward like foo\"%ibar\". I imagine that other edge cases are possible, > especially in exotic shells. I think quotes should not be stripped in such peculiar cases. The variants I suggested do not match it. Is it realistic? >> ... It should be applied to %%%i, >> but not to %%i. > > I am not sure what you mean here. "%%" is a way to specify literal "%" in `format-spec'. So '%%i' means in %i shell command and unquoting should not be applied to it. >>>> - I expected it as bugfix. > > It does not matter that most users will not be affected. Some users > being affected is enough to not commit this to bugfix. Our policy is not > to commit unsafe changes that may break existing configurations to > bugfix branch. Except critical fixes. Reasons why I consider this issue a severe enough: - Something weird may be executed as shell commands - Incorrect formulas in exported documents are more than just disappointment. An example of complain related to another bug: Re: Inequalities in math blocks. Wed, 06 Oct 2021 09:39:23 +0200. https://list.orgmode.org/m2bl42bo0k.fsf@me.com From my point of view, it is better to explain users that they are disturbed to be on the safe side. It is not choice between good and bad variants. Any decision is bad. >> emacs -Q --batch --eval '(find-file-noselect "not-found.txt" t)' >> Error: (file-missing "Searching for program" "No such file or directory" >> "git") > > This looks like Emacs bug. Likely in `vc-refresh-state'. It as an Emacs bug that missing git executable leads to a fatal error. It is a bug in Org that some hooks are called when just file content is necessary.