From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id OMmgCAVP32QlVQEASxT56A (envelope-from ) for ; Fri, 18 Aug 2023 12:59:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GFKYBwVP32QWUwAAG6o9tA (envelope-from ) for ; Fri, 18 Aug 2023 12:59:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ACA2166356 for ; Fri, 18 Aug 2023 12:59:16 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692356356; a=rsa-sha256; cv=none; b=Hi7Y55OKXmb4RDaPcBNNDczxXrk9mek4mzoXcYJK/inc+iM+KRXdUdgdQ8YFggbum1Pl/2 ONTPA8JeL5+JtQjgg/D+FiW+loGK9SiysKdxen1nAAASblG9HZz5WaP1HxLhllbupUDp11 NcZ09XMSMuVXWPSiX9ZJfT6vvzE0rigiVO3kEHBJnHBNuVdR/NRC5235dR2HVFBYMBFKWk XAVOh77NSAxWPHwesxw2wwt8sMaa7p0W+XG4GdohhzaipbAiZFkZr7Q5XEbGF5Oy+w56J7 pt6ONqJxzSp5YPvqSHupz6VyldVMB8yuuuHqPp8JPvLA3imWil31O1Qgr3gzQw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692356356; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=DXbxpfnYx5eoVd7bpmSQt4XqlxTx4AcLwNAxH0Cpv9I=; b=CcHLGAydapiywYENcLsKTSWIOrKe1IUaIpsXTgAOFJcWoUTDtO+7leWVGvUlECWDyXoG5k +Hlb2ii1/QxDMzWWyEGnMOISWEGiEETmfTfiG5GmfDOy3VN/EQ391wbgAXhNpN7S5/MWen 34feT62R6J77Ux6ORN+Om1HHqAUJZ1eTWEExqdRjYh7cm+WpWafAedU6p3Af1XDlOrkyNg 88dfhVybB43u2BxcG/E4HuDcO2jsTTWs/n+KiPf/PPYQwEonqhcoBm96QNb2yLGmWYdLmC xoOwuMxtz4fVk9JiXz6fMAwJCDgBs2izIUoenHw1npvSq2xa//uwz7TTs5oCVA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWxBN-0001xK-74; Fri, 18 Aug 2023 06:58:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWxAH-0001YY-MC for emacs-orgmode@gnu.org; Fri, 18 Aug 2023 06:57:13 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWxAF-0001nS-AU for emacs-orgmode@gnu.org; Fri, 18 Aug 2023 06:57:13 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qWxAA-0000Jr-QV for emacs-orgmode@gnu.org; Fri, 18 Aug 2023 12:57:06 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [BUG][SECURITY] ob-sqlite header args allows execution of arbitrary shell commands Date: Fri, 18 Aug 2023 17:56:58 +0700 Message-ID: References: <87zg2vl6qc.fsf@localhost> <87cyzkpwp4.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Content-Language: en-US, ru-RU In-Reply-To: <87cyzkpwp4.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-4.01, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Spam-Score: -4.77 X-Migadu-Queue-Id: ACA2166356 X-Migadu-Spam-Score: -4.77 X-TUID: d3tVTEFnpvWA On 18/08/2023 15:43, Ihor Radchenko wrote: > Max Nikulin writes: > >> #+begin_src sqlite :db '(literal "/tmp/ob.sqlite$(date >> >/tmp/ob-sqlite-vuln.log)") >> select 1 >> #+end_src > > Handling lisp values in header arguments is much more general issue not > tied to ob-sql or even to running shell commands. > > It should be addressed alongside with https://orgmode.org/list/87edsd5o89.fsf@localhost Ihor, this is a list, not an expression to be evaluated. There are some conditions to avoid user prompts for strings, lists, etc. They are considered safe. This particular case is handled namely by ob-sqlite and the proposed function in org-macs.