emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] epm.el: A CLI tool for package.el
Date: Thu, 4 May 2023 23:16:33 +0700	[thread overview]
Message-ID: <u30lp2$vpp$1@ciao.gmane.io> (raw)
In-Reply-To: <874jospf6w.fsf@localhost>

On 04/05/2023 17:24, Ihor Radchenko wrote:
> Max Nikulin writes:
>> For those who are not familiar with convention any target may be
>> specified in docs, keeping usual meaning of the default "all" target.
> 
> I am mostly concerned about the existing users who are already settled
> on running the default "make". Their workflow will be broken with your
> suggestion.

I hope, it is possible to achieve helpful error message with a link 
explaining change.

>> An I am unsure concerning user prompt.
> 
> My main concern is for the users who changed their elpa directory
> location. They might run into issues unexpectedly.

My opinion is that an error is better for make than user prompt. Try to 
load from default `package-user-dir' but install there only if it is 
explicitly enabled.

>>>> #!/bin/sh
>>>> ":"; # -*- mode: emacs-lisp; lexical-binding: t; -*-
>>>> ":"; exec emacs --script "$0" "$@"
>>>
>>> Let's not lock to bash. AFAIK, our makefiles can currently work on
>>> Windows. Using /bin/sh will lead to regression.
> 
> I thought that more portable way is using "env".

Either env would invoke sh anyway (like in org publish scripts) or it is 
necessary to use env -S feature of relatively recent GNU env. For 
cmd.exe it is better to provide a .bat file running

     emacs --script epm.el ...(something for POSIX $@)

>> +(defun epm-nonempty-p (s)
>> +  (and s (not (string-empty-p s))))
> 
> Can just use `seq-empty-p'.

I am neutral in respect to such change. I just decided to minimize 
dependencies.

>> +  ;; TODO (load site-run-file 'no-error 'no-message)
>> +  ;; may be necessary to load elpa-* deb packages when -Q option
>> +  ;; is used. See Info node "(elisp) Init File".
> 
> Given the explanation in the top comment, is this necessary?

Do you have any arguments against switching from emacs -Q to emacs -q? I 
am still unsure if it is safe enough, but not doing it is not better. I 
am considering adding -q to this script when it is called directly. 
Unfortunately Emacs does not have an option to override effect of -q.




  reply	other threads:[~2023-05-04 16:26 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11 10:36 Useful package? Compat.el Timothy
2021-10-11 14:28 ` Russell Adams
2021-10-11 14:40   ` Timothy
2021-10-11 18:04     ` Joost Kremers
2023-01-27 13:23 ` [POLL] Use compat.el in Org? (was: Useful package? Compat.el) Ihor Radchenko
2023-01-27 13:34   ` [POLL] Use compat.el in Org? Bastien Guerry
2023-01-27 20:38     ` Tim Cross
2023-01-27 21:38       ` Daniel Mendler
2023-01-27 22:29         ` Samuel Wales
2023-01-28 16:04   ` [POLL] Use compat.el in Org? (was: Useful package? Compat.el) Kyle Meyer
2023-01-30 11:35   ` Greg Minshall
2023-01-30 19:33     ` Ihor Radchenko
2023-01-30 19:40       ` Greg Minshall
2023-01-30 21:38         ` Daniel Mendler
2023-04-01 10:31   ` [PATCH] Add compat.el support to Org (was: [POLL] Use compat.el in Org? (was: Useful package? Compat.el)) Ihor Radchenko
2023-04-01 11:38     ` Daniel Mendler
2023-04-01 14:20       ` Max Nikulin
2023-04-02  8:52         ` Ihor Radchenko
2023-04-02 15:31           ` Max Nikulin
2023-04-02 16:04             ` Ihor Radchenko
2023-04-02 16:37     ` Max Nikulin
2023-04-02 17:00       ` [PATCH v2] " Ihor Radchenko
2023-04-03  8:46         ` [PATCH v3] " Ihor Radchenko
2023-04-08 11:15         ` [PATCH v2] " Max Nikulin
2023-04-08 11:41           ` Ihor Radchenko
2023-04-08 16:37             ` Max Nikulin
2023-04-13 12:42               ` Ihor Radchenko
2023-04-17 17:20                 ` Max Nikulin
2023-04-20  9:27                   ` Ihor Radchenko
2023-04-28 15:27                     ` Max Nikulin
2023-04-30 10:39                       ` [PATCH v4] " Ihor Radchenko
2023-05-03 12:14                         ` [PATCH] epm.el: A CLI tool for package.el Max Nikulin
2023-05-04 10:24                           ` Ihor Radchenko
2023-05-04 16:16                             ` Max Nikulin [this message]
2023-05-05  9:39                               ` Ihor Radchenko
2023-05-06  6:39                         ` [PATCH v4] Add compat.el support to Org (was: [POLL] Use compat.el in Org? (was: Useful package? Compat.el)) Max Nikulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='u30lp2$vpp$1@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).