From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 4BGUOGgTLGSDyAAASxT56A (envelope-from ) for ; Tue, 04 Apr 2023 14:09:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uLBKOGgTLGQBCAEAauVa8A (envelope-from ) for ; Tue, 04 Apr 2023 14:09:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 820D014B12 for ; Tue, 4 Apr 2023 14:09:12 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjfSh-0000QA-SK; Tue, 04 Apr 2023 08:08:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjfSh-0000Q2-13 for emacs-orgmode@gnu.org; Tue, 04 Apr 2023 08:08:31 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjfSd-0005oi-1T for emacs-orgmode@gnu.org; Tue, 04 Apr 2023 08:08:30 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1pjfSa-0001sB-DZ for emacs-orgmode@gnu.org; Tue, 04 Apr 2023 14:08:24 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] Autoload `org-assert-version' and remove org-loaddefs.el Date: Tue, 4 Apr 2023 19:08:18 +0700 Message-ID: References: <874juewk4k.fsf@kyleam.com> <87r0xi5jx7.fsf@gnu.org> <87o7obn0dp.fsf@localhost> <877cuzmreg.fsf@localhost> <87mt3qn0lb.fsf@localhost> <87zg7qjktr.fsf@localhost> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------srzyufiBPpST3y1MyKjBy6k0" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Content-Language: en-US In-Reply-To: <87zg7qjktr.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 9 X-Spam_score: 0.9 X-Spam_bar: / X-Spam_report: (0.9 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-1.925, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680610152; a=rsa-sha256; cv=none; b=ZTsGbHgnJhTLTSG1aUwKmi7SaDbvSiOvwpN42bqPpHNl4Oy59wel7+RyWL4N5/1x1kbMdI iLO4WGk+2/8cR7984P3xtL8byGn6+gIFn6Drr+tsLyyunRKyxNsn3s412wPa7DvF55/IYW qi5kSQfHcLQeBT2TnkxBaDgCTUJBheT+quaOn53Q2rKP18sPusj7HdHG2YGSo+V2skFMhH 5eKVitvdIPzufqAuwXxLE+71jczdTH90iAx53RsAhiZvUbUpWh2X6UsenBBGUiFlmLFerv u4qFmdq64jr2m1tfHEyb6rX/I3TNCxbiuMGBWWMShW5/aY0QtQ4PycrlVVi5TA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680610152; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=CHhpLsPRhS4aXU+6JaKAA4+wP/A4iwGnhGhR4Ua0uTs=; b=U+WrHw96XVEz0B9owQ4gMkxJ0YRPt99ixNvIOvbloKISRjTFyEXQg9sV3eSKg6N5l1Zwmn mrpLLiyd3bMkqJsxsTjiVnjXJGzJ2XMzWquyb1sHbKfmu28kqJeOD+jofkCsJ1v++fB3Cz k8qsczEnw0dm40UEM7PdQdB/q3sJxgEkFfS//vqTRoJ6T9t6vdJ3fNFBwXjwzvSmgXccq3 NOZst+C35iNuAZRd6SFSUvUIPASXQSuVv3g0zZTIFnJ3gHBAOIAFMWyyaJyHuNpN6XwUWV aCrGzYSwzCpRamY3SXPpH2NrVOpDxYWWp4Ogd0iX5eVpaKGVE764TPMSXD39AA== Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -0.92 X-Spam-Score: -0.92 X-Migadu-Queue-Id: 820D014B12 X-TUID: aMlBT70cSbsd This is a multi-part message in MIME format. --------------srzyufiBPpST3y1MyKjBy6k0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/04/2023 23:44, Ihor Radchenko wrote: > 1. The old problem with mixed installation that manifests itself for > some users > 2. The new problem with org-assert-version, which appears to be even > more frequent, despite trying preventing (1). I leave decision up to you. My opinion that both cases are weird. With `org-assert-version' users become aware that Org is broken rather quickly, without it they have a time bomb that gives impression of bugs in Org. From my point of view the real issue is that in both cases error messages are not instructive. The downside of current implementation of `org-assert-version' is that Org does not work at all. The above is related to *mixed compilation*, attempt to compile when some files from old version is loaded. The result is that some files are compiled with old macro definitions, some files are not compiled at all. A different issue is *mixed load* when Org might be properly compiled, but at first some files from old version are loaded prior to adding the directory containing new version to load path. I am not familiar with straight.el. Ihor will you consider the issue as reproduced if I compile emacs from some tag in git repository on Debian or Ubuntu, not with provided binary packages? There are some funtoo LXC images, I never use it, so I have no idea how much time it will take to create build environment enough to build Emacs and how close it to Gentoo. Do you consider the following as similar to package install issue for Emacs < 29? See the attachment cd update-issue/ emacs -Q -l load-old-compile-new.el emacs -Q -l load-new.el ==> old/upissue.el <== (require 'upissue-macro) (defun upissue-example (x) x) (provide 'upissue) ==> old/upissue-macro.el <== (defun upissue-macro-example (x) x) (provide 'upissue-macro) ==> new/upissue.el <== (require 'upissue-macro) (upissue-macro-check) (defun upissue-example (x) x) (provide 'upissue) ==> new/upissue-macro.el <== (defmacro upissue-macro-check () (message "upissue-macro-check called")) (defun upissue-macro-example (x) x) (provide 'upissue-macro) ==> compile-new.el <== ;; Compile new version (add-to-list 'load-path (expand-file-name "new")) (byte-recompile-directory "new" 0 :force) ==> load-new.el <== ;; Load new version (setq debug-on-error t) (add-to-list 'load-path (expand-file-name "new")) (require 'upissue) ==> load-old-compile-new.el <== ;; Load old version (add-to-list 'load-path (expand-file-name "old")) (byte-recompile-directory "old" 0 :force) (kill-buffer "*Compile-Log*") (require 'upissue) ;; Compile new version (add-to-list 'load-path (expand-file-name "new")) (byte-recompile-directory "new" 0 :force) --------------srzyufiBPpST3y1MyKjBy6k0 Content-Type: application/gzip; name="update-issue.tar.gz" Content-Disposition: attachment; filename="update-issue.tar.gz" Content-Transfer-Encoding: base64 H4sIAAAAAAAAA+2XwW6jMBCGOfMUo1wKldzahIDUHvfal3DwJEVxMDXQTd9+HVK2SZuUKotI u5rvQhRsCTT+5h+aUskaWV5VDd4arW6bsv19g9obCu5Iknh7FemM719bhJh6Io5FlKZplEYe F0nEhQd8sCf4hKaqpQXwinzV6Lw4ua7v/g/FDyw+NblFuHqtPFvLzJrQDxQumgK6f3Ej16VG CDYhbNzd0prnXL1tC/1LvwpxBs0J/3enYJgu0Oc/T5M3/yPh/E+nPCL/x+C95m3Ze2XvesSl n574Vw78L/D3RfI/Fnv5P2vzP+Lk/xh8kv+HLSF7xGxFU8H/xin/x8z/SOz5z9M2/wX5Pwqt 0G2t4YjvEIQ+QLDGqpJLhMmxJZnUGtUk/NAbaJT4ARz4n5l1mWtkrg+Mmv/J7vt/6pZFMd/m v+sF5P8Y3N/Dr13VwVUdntFWuSn8QCrFasN0XtVwpY1UrJT1IwS4KWWh2KI9JnLteoLb1so/ f3HnyGJ3hpSbKbLa2JfdCuBwtzA2o4nge3Hgf1vngeX3vuK/+Os/T6fO/1lM8/84OP8fXNUP 5a+wfgKF82bJTMHQWmOhDs9pCu8/Lsj+b8ZH/41WbNhBoM//OIo7/2eJiLfzv5sDyP8x6Px3 VT8n/N22nvDfrtgL/2CVa83mzWKBFibXr7MHezDL68nRfkEDCkEQBEEQBEEQxCD8AdXzVaIA KAAA --------------srzyufiBPpST3y1MyKjBy6k0--