Re: [PATCH] Autoload `org-assert-version' and remove org-loaddefs.el

[Max Nikulin <manikulin@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2692 bytes --]

On 02/04/2023 23:44, Ihor Radchenko wrote:
> 1. The old problem with mixed installation that manifests itself for
>     some users
> 2. The new problem with org-assert-version, which appears to be even
>     more frequent, despite trying preventing (1).

I leave decision up to you. My opinion that both cases are weird. With 
`org-assert-version' users become aware that Org is broken rather 
quickly, without it they have a time bomb that gives impression of bugs 
in Org. From my point of view the real issue is that in both cases error 
messages are not instructive. The downside of current implementation of 
`org-assert-version' is that Org does not work at all.

The above is related to *mixed compilation*, attempt to compile when 
some files from old version is loaded. The result is that some files are 
compiled with old macro definitions, some files are not compiled at all.

A different issue is *mixed load* when Org might be properly compiled, 
but at first some files from old version are loaded prior to adding the 
directory containing new version to load path.

I am not familiar with straight.el.

Ihor will you consider the issue as reproduced if I compile emacs from 
some tag in git repository on Debian or Ubuntu, not with provided binary 
packages? There are some funtoo LXC images, I never use it, so I have no 
idea how much time it will take to create build environment enough to 
build Emacs and how close it to Gentoo.

Do you consider the following as similar to package install issue for 
Emacs < 29? See the attachment

cd update-issue/
emacs -Q -l load-old-compile-new.el
emacs -Q -l load-new.el

==> old/upissue.el <==

(require 'upissue-macro)
(defun upissue-example (x) x)
(provide 'upissue)

==> old/upissue-macro.el <==

(defun upissue-macro-example (x) x)
(provide 'upissue-macro)

==> new/upissue.el <==

(require 'upissue-macro)
(upissue-macro-check)
(defun upissue-example (x) x)
(provide 'upissue)

==> new/upissue-macro.el <==

(defmacro upissue-macro-check ()
   (message "upissue-macro-check called"))
(defun upissue-macro-example (x) x)
(provide 'upissue-macro)

==> compile-new.el <==
;; Compile new version
(add-to-list 'load-path (expand-file-name "new"))
(byte-recompile-directory "new" 0 :force)

==> load-new.el <==
;; Load new version
(setq debug-on-error t)
(add-to-list 'load-path (expand-file-name "new"))
(require 'upissue)

==> load-old-compile-new.el <==
;; Load old version
(add-to-list 'load-path (expand-file-name "old"))
(byte-recompile-directory "old" 0 :force)
(kill-buffer "*Compile-Log*")
(require 'upissue)
;; Compile new version
(add-to-list 'load-path (expand-file-name "new"))
(byte-recompile-directory "new" 0 :force)

[-- Attachment #2: update-issue.tar.gz --]
[-- Type: application/gzip, Size: 543 bytes --]