From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 0MMULyWnKWQPVwEASxT56A (envelope-from ) for ; Sun, 02 Apr 2023 18:02:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id YIXcLiWnKWSlEgAAauVa8A (envelope-from ) for ; Sun, 02 Apr 2023 18:02:45 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7A9EB10600 for ; Sun, 2 Apr 2023 18:02:45 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pj07r-0002si-6R; Sun, 02 Apr 2023 12:00:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pj07g-0002q2-1n for emacs-orgmode@gnu.org; Sun, 02 Apr 2023 12:00:04 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pj07e-0002a4-92 for emacs-orgmode@gnu.org; Sun, 02 Apr 2023 12:00:03 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1pj07c-0005uV-Pe for emacs-orgmode@gnu.org; Sun, 02 Apr 2023 18:00:00 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] Autoload `org-assert-version' and remove org-loaddefs.el Date: Sun, 2 Apr 2023 22:59:51 +0700 Message-ID: References: <874juewk4k.fsf@kyleam.com> <87r0xi5jx7.fsf@gnu.org> <87o7obn0dp.fsf@localhost> <877cuzmreg.fsf@localhost> <87mt3qn0lb.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Content-Language: en-US In-Reply-To: <87mt3qn0lb.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-2.37, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680451365; a=rsa-sha256; cv=none; b=NbUD+losj/wM2PZUZRDcxkervWIXmmxRrbt6KV/SAW53whTpLwSIGRdr9q1P8ZexWHUI4t bGh3B9S/LAMmfovBd+MyoqWVkhrsjmhFnMCF3wFa9LPAIr0kOfUnVtV6tmvQpBW6JnHimv 82dE8OEfFov7K0LzLU+AsNs1SMvy7ZYKXCTlQ60xePkXNDANNv9aKY45dd/cj8EStG+wWv CPBx4aa1wtXQ9y8THCuQpgYr4eR7UcjBAOMEH7Xv9nuUriatit7GPu1OaTsBwVIXvBWpIU bBbUvmC0teMoYuaERTDqnG7lJgKGoKjhlKHrmpoeV4PvBE4SsydgkqrUCWXAWw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680451365; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=svqTnn7OpYizyHu/p3iHcISQLKWMSYsImr/3N8U7CUw=; b=K5eKkJYabeAnRcUF4yVzzyMQ44/dHsj45U76xIGMLOrbcwGBvcSi11bcz1Yeo8YP1NkTuP oV6dwH3hiloqOQz6yN3/Cz2ObCvuLlQj1ZegrZz4Saqjz5QF1GlXWbP3vbmi6fvh7mMwqh hrqAWdG9wrLSnMWxd3UC+6DKxHBCBixMPqkU80rhejLwrvsXl4mcMoKoLPVZGJRYy0sCoS W+VBD3i2VaqGhkGoYT2tdyTxz0G7SelfkRjyK/nVDKHbzwIlMo82ZbI+bRuZ9v/cAi2hxH P9RGEz/PnDxDHDy6ZGzxfCFyoaThlGyMEnyyTRQ6vm/XpGr7TPVqMUj9TFQrng== X-Migadu-Spam-Score: 3.97 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Spam-Score: 3.97 X-Migadu-Queue-Id: 7A9EB10600 X-TUID: wBkh1iYfFb8l On 02/04/2023 15:35, Ihor Radchenko wrote: >>> I was able to reproduce on Debian using virtual machine. >> >> To be precise, I am surprised that you are unable to reproduce the issue >> with older Emacs version compiled from source. > > Does it mean that you are able to? I reproduced the issue with packages available in Debian and Ubuntu, including -Q, so minimally affected by distribution-specific configuration, but I have not tried to compile Emacs myself. I am judging from changes in Emacs code made after release of version 28. > I only tried on Gentoo, because my Debian-foo is not good enough to hunt > all the required compile-time dependencies for Emacs. apt build-dep emacs and perhaps "apt install" for some …-dev packages for new features. However my surprise is namely dependence on specific packaging/distribution. My expectation that it should be reproducible in Gentoo as well. >>> https://old.reddit.com/r/orgmode/comments/123qnqq/workaround_for_orgassertversion_problem_not/ >> >> I have no clue why your patch should help in this case. > > It won't, but the very reason that message appeared is the need to do > that awkward workaround. It must not be needed - we are causing way too > much inconvenience to users of Emacs versions we claim to support. Either I missed your point or the issue will be just postponed. Patched variant will not prevent mixed version compilation, so users still may experience calls of undefined functions or incompatible argument types. >>>> I am in doubts if emacs version should be checked or it should be e.g. >>>> (fboundp 'org-assert-version). >>> >>> It is indeed a cleaner approach. >> >> I am not sure. Perhaps it should be (or (fboundp 'org-assert-version) >> (new-package-management-code)). Since testing for private function is >> not a reliable solution, only version check is available. > > May you elaborate? I do not think it is good idea to rely on (or (fboundp 'org-assert-version) (fboundp 'package--reload-previously-loaded)) I have not checked if some public function may be used for feature detection of code appeared in Emacs-29. That is why I would consider (when (or (fboundb 'org-assert-version) (version<= "29" emacs-version)) (org-assert-version)) However I am still in doubts if it is improvement in comparison to simple (org-assert-verions) without any conditions.