From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oGS9LmIGZWN0/QAAbAwnHQ (envelope-from ) for ; Fri, 04 Nov 2022 13:32:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WGq+LmIGZWOQdgAA9RJhRA (envelope-from ) for ; Fri, 04 Nov 2022 13:32:34 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 82EECF241 for ; Fri, 4 Nov 2022 13:32:34 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqvrI-0002RJ-RS; Fri, 04 Nov 2022 08:31:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqvr5-0002O0-K5 for emacs-orgmode@gnu.org; Fri, 04 Nov 2022 08:31:29 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqvr3-0008HO-Ij for emacs-orgmode@gnu.org; Fri, 04 Nov 2022 08:31:27 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1oqvr0-00053g-0J for emacs-orgmode@gnu.org; Fri, 04 Nov 2022 13:31:22 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] org.el: Warning for unsupported markers in `org-set-emphasis-alist' Date: Fri, 4 Nov 2022 19:31:15 +0700 Message-ID: References: <87o86mw86r.fsf@localhost> <87fsrxkahq.fsf@nicolasgoaziou.fr> <87fsrxa1j5.fsf@localhost> <878rxoa6lk.fsf@localhost> <87pmqtj09r.fsf@localhost> <87mt9743di.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US In-Reply-To: <87mt9743di.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 26 X-Spam_score: 2.6 X-Spam_bar: ++ X-Spam_report: (2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Emacs-orgmode" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667565154; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=q3dfHiyPOE1e9tfzEtI4oDsNzSdDxD2QAXZzzIZYeWs=; b=JSbxd/6zVnpyqguZcAbcqLSUpk+pyc4CZhA5l/c5f6FjJoR3hQ+9Jdqld9lLARQe4ahF57 dSDWJ2ua1XWD2rVmEhfeZL45tuND1yrbqrIqfNAtekpUL0i8bh24adV4jwln+keVPmAoxu kqovnP83r/XuUjFQ/g94bexxTsvPCZ2WvPRUuppw2KCmnmqr7rD7b9UqkSLsKQpYfpfZhT iTvCUt5qJsAUgOvBpWgC+e6KyO2xlImD+/oY2fqEOY9Yyf6MUGx0tfu45G75oBjGIp2E9B DxpdHP0fH7e6li6o63hiuLUF9SMbH8gSuMtpUokChGSwFC5Vr63u/CQofUD6EQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667565154; a=rsa-sha256; cv=none; b=PGUScVmBCAtIZO/77occ4PLdbKEm83b6TYttVQr2GQKzBw9SKTYplPj+X1/liUzsEWb76w k41sg/Nb9aEuncunEASOONFC6lt2HwCgKAGdpCQ2/Y082tyZhMlMOjwM4lH/5yGMUeeLMM yEYWYhDcdNiB/DIdNRHQ+PcrH+PiJjrnr23a6NwgXxuxkUrFbrV2KDyeIGYaURKqRpNSoy OMoWqnCnSj1Nj9eariddEwux5u7258XvmHbsdSKIt3EVshwUlhKb7/GZAkiI96TWdFDJPn 168R7/86TTfz0Lqii8tIyn1UuUMPMJ9S9qANA6nv5IgJDtkgJJyjsFZ4IGnoHQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.70 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 82EECF241 X-Spam-Score: 2.70 X-Migadu-Scanner: scn1.migadu.com X-TUID: NLkY4t1hi/Vx On 04/11/2022 13:53, Ihor Radchenko wrote: > > I have reviewed the patch, and I'd like to suggest a new version with the > following changes: Great! I have not tried your patch in action, but I do not see substantial changes. > 1. Use `set-default-toplevel-value' instead of `set' that might be > quirky in some scenarios. Almost certainly it is an improvement. Docs in the Emacs repo have been updated, but the published variant still suggests `set-default' https://www.gnu.org/software/emacs/manual/html_node/elisp/Variable-Definitions.html > 2. Use `warn' instead of `message' as more alarming. I do not mind. > 3. Remove verbatim in ("=" org-verbatim verbatim), ("~" org-code > verbatim), and the :type spec. AFAIU, they are unused. But can you > please double-check? It seems, before the following commit, verbatim was used to suppress flyspell, but now "~" and "=" are hardcoded. 9fb2e047d 2016-12-08 09:44:26 +0100 Nicolas Goaziou: Split `org-emph-re' and `org-verbatim-re' I think, verbatim option should not be removed from `defcustom' :type just now. For some users it might cause fallback to raw lisp value in easy customization UI. Perhaps another warning should be added to the `org-set-emphasis-alist' validator and the option should be labeled as unused in the :type definition.