From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cK3DBVkiUWNIdAEAbAwnHQ (envelope-from ) for ; Thu, 20 Oct 2022 12:26:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id SDzQBVkiUWONMwEA9RJhRA (envelope-from ) for ; Thu, 20 Oct 2022 12:26:33 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D1C5AF57E for ; Thu, 20 Oct 2022 12:26:32 +0200 (CEST) Received: from localhost ([::1]:41236 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olSkv-000767-PV for larch@yhetil.org; Thu, 20 Oct 2022 06:26:30 -0400 Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olSc5-0004u7-Tq for larch@yhetil.org; Thu, 20 Oct 2022 06:17:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olSUt-0004lE-FY for emacs-orgmode@gnu.org; Thu, 20 Oct 2022 06:10:01 -0400 Received: from ciao.gmane.io ([116.202.254.214]:50410) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olSUr-0001qD-SH for emacs-orgmode@gnu.org; Thu, 20 Oct 2022 06:09:55 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1olSUo-0008KK-40 for emacs-orgmode@gnu.org; Thu, 20 Oct 2022 12:09:50 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [BUG] ox-odt fails for org-id links (e.g., from org-roam v2) [9.5.2 (9.5.2-gfbff08 @ /home/moritz/.emacs.d/elpa/27.2/develop/org-9.5.2/)] Date: Thu, 20 Oct 2022 17:09:42 +0700 Message-ID: References: <877d0xfu9m.fsf@localhost> <877d0wayn8.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US In-Reply-To: <877d0wayn8.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666261592; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=DxOGw7PSu7gRReb9sC/HfneHKRZ4EyesQeChWHIx7yc=; b=KbfJHJs6FXuSiRKbWBREAk+SaYMkCbcOqyugDJoprjo9ZV/dx2Y68iyZ4NQFnL18lvdKna aRVOI/dtczV+iWVOSdsXKsjYZIOY7+dGCaNTscBAX8r3MZTzBxLq4q9VbNKer93SKwezkl cZF7EJWbeS3yBud+7NfRo6s+F2zlEmgUXf+/4F8VPyde5oUCfcDbb4iMxwe7hVd4B7D2j3 SMtCxk9BtLm7d/51wjz7A37cyg9UGoh0ts4MFzhy67C0QJe+t0XIXeClKeeJ+W/HHNaC0z e3a1Fdo2yAr3XHcz3EX2uodN6Feqr3tgXuVJczl6eVAWGK+NpzsfgZq0DoYQQg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666261592; a=rsa-sha256; cv=none; b=H0lSA0Lyk5icMdIfFS9toGnmxZMzodBtSfToV3oTXTny2CR5Ensh5XvARsYYSJ0Tiq5m5y U3TXEZTQ/IOEh+V1ZehJb28gAZyReTeGIvgmTomzWi56uwj8R8GABQf1/MWTYIBq/hwbVv n+LhHsxFXHv47UbMgVtoCnYRC24bzgNlQcLxQAzGpHVHG5eVAPiHkv8MnMT8+kWFHAMNaM cRaOu8cuZts4m8s7opEbTMSkbRW5eicYj8VMeAei8BueweVn/8vM5kWRYCBzsOSRsgwGHo QR1DUlwYZQu96qfC7Dj0wCAQf9R1UeJ2lgtSXn4pKvb3Q8T48YnXc+6qPK92TQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.77 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D1C5AF57E X-Spam-Score: 2.77 X-Migadu-Scanner: scn1.migadu.com X-TUID: U9sSbcpYLLl2 On 19/10/2022 17:36, Ihor Radchenko wrote: > > --- a/lisp/ox-odt.el > +++ b/lisp/ox-odt.el > @@ -2737,6 +2737,12 @@ (defun org-odt-link (link desc info) > (format "%s" > (org-export-get-reference destination info) > (or desc (org-export-get-ordinal destination info)))) > + ;; Link to a file, corresponding to string return value of > + ;; `org-export-resolve-id-link'. > + (plain-text > + (format "%s" > + destination > + (or desc (org-export-get-ordinal destination info)))) I am apologizing if my comments make no sense. I remember a thread on improper handling on id links in ox-html, so I am a bit surprised that a link to the whole file (if I got the goal of the patch correctly, of course) is the only problem with ODT. - ox-html may transform file suffix from .org to .html. Have I missed the same code for ox-odt? - Doesn't destination should be passed through some quoting-escaping function to avoid characters in file names that may make XML invalid? (Perhaps id links between .org files will be broken earlier.) Max Nikulin. Re: Internal link broken when publishing (was org-id with ox-html) Tue, 14 Sep 2021 23:33:43 +0700. https://list.orgmode.org/shqit9$8ds$1@ciao.gmane.io