From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ONJwLzjgHWP95gAAbAwnHQ (envelope-from ) for ; Sun, 11 Sep 2022 15:18:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oDJsLzjgHWNEdAEA9RJhRA (envelope-from ) for ; Sun, 11 Sep 2022 15:18:48 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 54828CE19 for ; Sun, 11 Sep 2022 15:18:47 +0200 (CEST) Received: from localhost ([::1]:46078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oXMrG-0001JX-1p for larch@yhetil.org; Sun, 11 Sep 2022 09:18:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXMqo-0001JN-97 for emacs-orgmode@gnu.org; Sun, 11 Sep 2022 09:18:18 -0400 Received: from ciao.gmane.io ([116.202.254.214]:51546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXMqm-0003la-KA for emacs-orgmode@gnu.org; Sun, 11 Sep 2022 09:18:18 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1oXMqk-0008VB-3X for emacs-orgmode@gnu.org; Sun, 11 Sep 2022 15:18:14 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH v2] Re: Adding target and custom id links doesn't ask for description Date: Sun, 11 Sep 2022 20:18:06 +0700 Message-ID: References: <87a68c4pyc.fsf@localhost> <8735e091pn.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-4.101, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662902327; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=EiVQj5bN1wphOM8obPhsgppr1LXthKw/A70wrusUIYY=; b=aS7TaOfGMO0r/aC6ZBpzFR0b0afXoPflN0x8Kj6sC+HTpHD1lQprgkhP5XHi7DL6NPfW4y 2reHGNLFyYLjOFkH7xklPn4mNuMArfVFqrJU/K7RsWVbm0dv/nig/GI8oQ0W91AygfAaRE VzVfJS4uNH5pZGMg44CvtuDyakg3aj0meEBIFAwZc0tPcD1ETTiAYsnnQ2GKcRjB++Kocp fRMC93Pc+/q4uUJ56uFAobYeJYt1GRwudKUf4jfiu+v+s3vhR37Gt2d7HTHa+1NKzfL0BT heKaycA/qOq76GluMUrhSUxVoCjfA5gW6bKbRZgeigm9BB6KztJW6N3oSSrSNA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662902327; a=rsa-sha256; cv=none; b=aq9TDbEEOETowk0Vk1sGpzJTP3loQ1JQzSV3PkzWLf235+myk/0pK21CmgoX5FFqAeJiid syYAeC/sdBinKey90rZglJYnng2VaWkctJ+7bJ3wotahJeqdNmUAuKeJsMNYpbESoL1BW/ S7t+Em+7ORXh+C2CgJiS61cfnLMDDaxYSP5kLqAu77KsOpHnqgdoX2Z5OmNYQJbfboiGVh s2yIKHKeVcoNIi6XH8pfcnQnBRcieGpABbsWqfv/G5vD4TrIxmPHfZ6HFlKYuZA8QQnLZU yFHTpsjAbf/OqAIy/hFTwYVMEPBsiQjQEK10IfD8RX4pn6G4ZEHQDJNcC2ITZw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.89 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 54828CE19 X-Spam-Score: 3.89 X-Migadu-Scanner: scn0.migadu.com X-TUID: kjJw5k4b5EjG On 14/08/2022 16:53, Max Nikulin wrote: > On 13/08/2022 12:01, Ihor Radchenko wrote: >> See the updated version of the patch attached. It works on my side. >> >> --- a/lisp/ol.el >> +++ b/lisp/ol.el >> @@ -1577,10 +1577,8 @@ (defun org-store-link (arg &optional interactive?) >>            t)))) >>      (setq link (plist-get org-store-link-plist :link)) >>          ;; If store function actually set `:description' property, use >> -        ;; it, even if it is nil.  Otherwise, fallback to link value. >> -    (setq desc (if (plist-member org-store-link-plist :description) >> -                       (plist-get org-store-link-plist :description) >> -             link))) >> +        ;; it, even if it is nil.  Otherwise, fallback to nil (ask >> user). >> +    (setq desc (plist-get org-store-link-plist :description))) > > I can not say that I understand design of `org-store-link` and > `org-insert-link' pair, but I suspect that you might try to fix the > issue in a wrong place. > > It seems the same :link and :description value were set for purpose, see > `org-insert-link' code: > >         (dolist (l org-stored-links) >           (when (equal link (cadr l)) >         (setq link (car l)) >         (setq auto-desc t))) Ihor, I beg you pardon. I was wrong writing that you are trying to fix the issue in a wrong place. I figured out that the purpose of this snippet is completion by link description, not detecting of the case of identical link target and description. You have just committed the patch from the following thread where I provided more details: Max Nikulin. ido, org-insert-link, and completion based on link description. Tue, 6 Sep 2022 21:34:12 +0700. https://list.orgmode.org/tf7lp4$5ha$1@ciao.gmane.io Now I believe that your change is an improvement. I do not see any real reason to store the same description as the target. "~/Desktop/Org/captures.org::target" for <> as default value of the description prompt might be a hint to the user for which link their should write description, but I hope, there is a better way to do the same. I have seen a mention that some export backend may create perhaps invisible links if description is omitted, but if it is still an issue, it should be fixed in affected backends. Unfortunately, your patch does not fix the real issue. The title (not nil) should be saved for link description when the heading contains the CUSTOM_ID property. I tried to address it in the following patches: Max Nikulin. Re: Bug: org-store-link uses CUSTOM_ID instead of target point. Sat, 6 Nov 2021 19:51:29 +0700. https://list.orgmode.org/e2c807a7-1924-6f08-9e63-4f70aee9d3b5@gmail.com