emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: Bug: org-store-link uses CUSTOM_ID instead of target point [9.4.4 (release_9.4.4 @ /usr/share/emacs/27.2/lisp/org/)]
Date: Sun, 14 Aug 2022 16:58:04 +0700	[thread overview]
Message-ID: <tdagvc$1012$2@ciao.gmane.io> (raw)
In-Reply-To: <e2c807a7-1924-6f08-9e63-4f70aee9d3b5@gmail.com>

On 06/11/2021 19:51, Max Nikulin wrote:
> On 06/05/2021 19:41, Bastien wrote:
>> Fr Ml writes:
>>
>>> I have a problem with the function org-store-link it doesn't work as
>>> described in the documentation:
>>> https://orgmode.org/manual/Handling-Links.html
>>> "For Org files, if there is a '<<target>>' at point, the link points
>>> to
>>> the target."
>>
>> Fixed in maint, thanks a lot for reporting this and Ihor for
>> confirming the bug.

Another issue likely caused by this change:

Carlos Pita to emacs-orgmode. Adding target and custom id links doesn't 
ask for description. Tue, 2 Aug 2022 14:44:58 -0300.
https://list.orgmode.org/D99A712C-18D1-4A4F-8093-35A0BFB469C4@gmail.com

> Bastien, unfortunately your fix caused duplication of stored links like 
> "file:~/org/file.org::#custom_id" when point is outside of <<target>>. 
> Earlier #CUSTOM_ID link was stored in addition to 
> "file:~/org/file.org::*Heading" search link. My suggestion is to revert 
> your patch and to just reset custom-id variable when <<target>> link is 
> stored. Another effect or your patch, that I consider unintentional, is 
> storing 
> [[file:~/org/file.org::#custom_id][file:~/org/file.org::#custom_id]] 
> instead of [[file:~/org/file.org::#custom_id][Heading]]. I prefer 
> "original" behavior.
> 
> Third patch is intended to avoid links inserted as 
> [[target][file:~/org/file.org::target]] in the case of same file. I 
> suppose, just [[target]] is better. Current variant looks unbalanced and 
> misleading. Of course, you are free to skip last patch.
> 
> I am confused by `org-insert-link' behavior. It inserts links like 
> [[file:~/org/file.org::#custom_id][file:~/org/file.org::#custom_id]] 
> without user prompt for description but 
> [[file:~/org/file.org::#custom_id][Heading]] requires to confirm 
> "Heading" description explicitly. I would expect that "raw" link is 
> subject to ask user for more friendly option.
> 




  reply	other threads:[~2022-08-14 10:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-04 19:17 Bug: org-store-link uses CUSTOM_ID instead of target point [9.4.4 (release_9.4.4 @ /usr/share/emacs/27.2/lisp/org/)] Fr Ml
2021-05-05  2:34 ` Ihor Radchenko
2021-05-06 12:41 ` Bastien
2021-11-06 12:51   ` Max Nikulin
2022-08-14  9:58     ` Max Nikulin [this message]
2022-09-13 13:05     ` Ihor Radchenko
2021-05-06 20:08 ` Table alignment problem Fr Ml
2021-05-07 14:50   ` Ihor Radchenko
2021-05-08  6:37     ` Jeremie Juste
2021-05-08  7:45       ` Fr Ml
2021-05-08  7:48     ` Fr Ml
2021-05-08  8:24       ` Ihor Radchenko
     [not found]         ` <5ebfdc6f-6e40-1470-4379-4a5a2b666aa7@t-online.de>
     [not found]           ` <87czu1pivb.fsf@localhost>
     [not found]             ` <6c4c8084-3800-c085-b724-f5653d7c20bd@t-online.de>
     [not found]               ` <87eeeh17fq.fsf@localhost>
     [not found]                 ` <8975eded-5a22-cb9c-b85e-f3b523f16411@t-online.de>
     [not found]                   ` <871ragff66.fsf@localhost>
     [not found]                     ` <84936763-9384-7e6c-5304-b94217298b9a@t-online.de>
     [not found]                       ` <87lf8o9pgn.fsf@localhost>
     [not found]                         ` <eb465a73-691d-01be-135e-f58a9ff36173@t-online.de>
     [not found]                           ` <87im3s9ie8.fsf@localhost>
     [not found]                             ` <2c2f2204-14b1-49b2-658b-2b8b75ab86b9@t-online.de>
2021-05-15  9:26                               ` [PATCH] Pixel-wise table alignment Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='tdagvc$1012$2@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).