From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UPxcOKLG+GIlOgEAbAwnHQ (envelope-from ) for ; Sun, 14 Aug 2022 11:55:47 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id SJ15N6LG+GKsBgAAG6o9tA (envelope-from ) for ; Sun, 14 Aug 2022 11:55:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8B7673352B for ; Sun, 14 Aug 2022 11:55:46 +0200 (CEST) Received: from localhost ([::1]:46364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNALR-0008WP-QR for larch@yhetil.org; Sun, 14 Aug 2022 05:55:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNAJl-0007qR-62 for emacs-orgmode@gnu.org; Sun, 14 Aug 2022 05:54:04 -0400 Received: from ciao.gmane.io ([116.202.254.214]:45716) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNAJj-00042U-Ou for emacs-orgmode@gnu.org; Sun, 14 Aug 2022 05:54:00 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1oNAJg-0008e5-NZ for emacs-orgmode@gnu.org; Sun, 14 Aug 2022 11:53:56 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH v2] Re: Adding target and custom id links doesn't ask for description Date: Sun, 14 Aug 2022 16:53:50 +0700 Message-ID: References: <87a68c4pyc.fsf@localhost> <8735e091pn.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US In-Reply-To: <8735e091pn.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660470946; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=a63EpXTlS0RiOTLUH3dw5ArNRHBAKL8U1/JA1DPWFZQ=; b=d2hiyAAJC+VDGyO2ZkcFPuvyRlJXCWXYvRdbxxOspSxBdPtSWBBKsHjAuH3xeDP3RlQ5dm e4LSckIhR3hLI9+r6Q3P5YCs9z6C8O07N/xMlGhH1TKRn8PywyOtuLMCnAuIohvhRuObSB 6nffeWwIMnaiSrEl6YAlCidR6Os/RrnLOY6RjwyQYLuVAVNAOhXvYGLyafG/DQTjqD8OUs QVt6E4AAgJRfNaVpD89PDAqGtoKVymqZ2IXxjxXucFpRUPwW90I6RSWh+0GxNKaZVZg1b2 Bom07nPkVfc1xMpufGOTMTQ3kmR1yvM5G5C0pSyYX8l6aDmB4a6Avhl4VDa8Ug== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660470946; a=rsa-sha256; cv=none; b=MJ2pNRCv52HoYUIV8uE1gS4zh8nEZ2lU/uyyNtRN6htjGlmbU6DRANICb9n99Uejyfcmny dsESdFT9Toa4orkpa0o0p/aJmeST/1M1in+telJu+kPWoFyn7Bbq13Vf1Mg+zTFwcAvTF/ QQf12ErvralSEZMZ5LaN5jTgrO1M3xjsun2IhOFY0q++YkLumtiSF5jOqZAhYwm8lj9g9t oksc0xGrqu0+XXwerev3x+Ymb1hYM+J8j2kghpDrN4f8Mbvw9wiPEe9fJJiIhO/jgkXrgf LIiNGcWlmbZ+qqr/kZrm6SK3okakKLokqoN2tK5/cR+1Oep83xbQE6+vMVtPkw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.84 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8B7673352B X-Spam-Score: 2.84 X-Migadu-Scanner: scn1.migadu.com X-TUID: EoYaab10tZPM On 13/08/2022 12:01, Ihor Radchenko wrote: > See the updated version of the patch attached. It works on my side. > > --- a/lisp/ol.el > +++ b/lisp/ol.el > @@ -1577,10 +1577,8 @@ (defun org-store-link (arg &optional interactive?) > t)))) > (setq link (plist-get org-store-link-plist :link)) > ;; If store function actually set `:description' property, use > - ;; it, even if it is nil. Otherwise, fallback to link value. > - (setq desc (if (plist-member org-store-link-plist :description) > - (plist-get org-store-link-plist :description) > - link))) > + ;; it, even if it is nil. Otherwise, fallback to nil (ask user). > + (setq desc (plist-get org-store-link-plist :description))) I can not say that I understand design of `org-store-link` and `org-insert-link' pair, but I suspect that you might try to fix the issue in a wrong place. It seems the same :link and :description value were set for purpose, see `org-insert-link' code: (dolist (l org-stored-links) (when (equal link (cadr l)) (setq link (car l)) (setq auto-desc t))) However I am puzzled by (unless auto-desc I would say that namely the same :link and :description should cause query to default description and user prompt. I may be wrong. Maybe the protocol of communication between these functions may be documented with more details.