From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YFCQD0rT82JhDAEAbAwnHQ (envelope-from ) for ; Wed, 10 Aug 2022 17:48:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id wL57D0rT82KsfgEA9RJhRA (envelope-from ) for ; Wed, 10 Aug 2022 17:48:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AFE8D3A6CA for ; Wed, 10 Aug 2022 17:48:25 +0200 (CEST) Received: from localhost ([::1]:54362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLnUW-0001od-1U for larch@yhetil.org; Wed, 10 Aug 2022 11:19:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLnTX-0001lE-M3 for emacs-orgmode@gnu.org; Wed, 10 Aug 2022 11:18:27 -0400 Received: from ciao.gmane.io ([116.202.254.214]:47686) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLnTW-00007P-2y for emacs-orgmode@gnu.org; Wed, 10 Aug 2022 11:18:27 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1oLnTT-0003Bb-VK for emacs-orgmode@gnu.org; Wed, 10 Aug 2022 17:18:23 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH v3] Re: [BUG] org-attach-id-ts-folder-format fails on customized IDs [9.6 (9.6-??-2e9999783)] Date: Wed, 10 Aug 2022 22:18:18 +0700 Message-ID: References: <87k084v1wa.fsf@localhost> <871qtxhsm6.fsf@localhost> <87a68ce32u.fsf@localhost> <871qtodygs.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US In-Reply-To: <871qtodygs.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660146505; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9ksrVGSmzswwwa34IbKj2LrffwS4k2g269SZOiJGkkk=; b=RmerIjhDCTTCbw7jmpbgFFKPI97UGgFKWrzhPrDWEuukV+kvRwaXEyjlZngojY2SqlKbp+ fQGWerKgtZdOXAXru9AzuDeH1DTx/NIP4T0Dg1wc/GRUNad5r6IYXlYFP323JuQA5XDAAB xsKR4q7seVxjSfjHHXumS9MkKiFn4x1JGYuaSJGZWED2ZiNL7HI9GGad9YOe8Pni0a9MIR 7bBMNPH9xBYm15kXiX4iDekl0ROmPfkDUwJbVByyLB+YQhROYRSsZ5VGm54ZeFcuqjCI1Q z2erb/IYbPt1HY4CUWilpHMPXlYvuGlm6T9tv2baZzPYTs9aExZiJXZe9nF/9g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660146505; a=rsa-sha256; cv=none; b=ONy9wjk6k+KFXIXJ6/aIM3Vwq0enTQWcuA4WuJIWUcN0F1wIPRrQEAjn1P+mz8vW0wKlSu 8YPUmuDu2IVBrt3ioXfRJFgGTDU3enpkv6sNN1YwiZ69hE2/n6Rf7Zcm4RnMvXvykjmlbg SRGjPHvDGXlLjscaLwQ5PExghyU6siA4alnXdGRqEv6EyRtW2aW5+Y9Fnr0t1acOjma7R1 5w4RrSM5nJXCpCdT2Jwv72zu+khW4xbghfbUluh6EgF/j2Xl6QhI/8CnjR8IHqiU/tSSkp Nt+7hvqBVVHKjwDpnQ2+NvGjDf9BTbErQz2l0EI+sPe67Nj8mLHNXiZuMoq1fQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.31 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: AFE8D3A6CA X-Spam-Score: 4.31 X-Migadu-Scanner: scn1.migadu.com X-TUID: Q+Qv+KgmcSxO On 10/08/2022 20:23, Ihor Radchenko wrote: > Max Nikulin writes: > >>> +the path." >>> + (if (< (length id) 3) >>> + (format "--/%s" id) >> >> Please, do not use path components starting with dash, it is terrible >> for CLI tools. By the way, you promised underscores, not dashes. > > Why? It is inconvenient in interactive sessions (in scripts appropriate measures must be taken anyway), the following does not list content of the "--" directory: ls -l -- > I slightly dislike the "___xx" compared to "______" because it will > create a proliferation of top-level folders as opposed to cramping the > non-standard IDs into a single "______" folder. I believed that proliferation of folders is for purpose. Intermediate directories allows to avoid excessive number of files in single directory. ext4 with directory tree index usually is not the case, but other filesystems may have rather poor performance when too much files are stuffed into single folder. Some applications become really slow for huge directories. On the other hand there are not so many distinct file names that may fall into "__" directory, so perhaps it is OK. Concerning "unknown" I am less sure. I do not have strong opinion how to properly deal with short IDs.