From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MJcpFHYvlmKq6gAAbAwnHQ (envelope-from ) for ; Tue, 31 May 2022 17:08:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id iFX6E3YvlmIEZwAAauVa8A (envelope-from ) for ; Tue, 31 May 2022 17:08:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E82DA2FAC7 for ; Tue, 31 May 2022 17:08:37 +0200 (CEST) Received: from localhost ([::1]:46058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nw3U4-0006ob-6j for larch@yhetil.org; Tue, 31 May 2022 11:08:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nw3T1-0006m1-N3 for emacs-orgmode@gnu.org; Tue, 31 May 2022 11:07:31 -0400 Received: from ciao.gmane.io ([116.202.254.214]:52852) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nw3T0-0001cC-4V for emacs-orgmode@gnu.org; Tue, 31 May 2022 11:07:31 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nw3Sw-0001hy-EK for emacs-orgmode@gnu.org; Tue, 31 May 2022 17:07:26 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH v3] Re: Bug in 9.5.3 org--file-default-apps Date: Tue, 31 May 2022 22:07:18 +0700 Message-ID: References: <963d5f94-3fdf-a01b-bc91-edc99222cb34@gmail.com> <87czgeaxir.fsf@localhost> <6615610d-93ae-171f-b554-3f4cc79354cc@gmail.com> <87a6bhc1w6.fsf@localhost> <86692975-4d5f-6933-3227-c6b208f76862@gmail.com> <877d6lbsg5.fsf@localhost> <7c75b724-1ea2-5e3e-cbe6-e1895fd35bd3@gmail.com> <877d6j2htv.fsf@localhost> <87ilq14p6p.fsf@localhost> <87v8u0396t.fsf@localhost> <87ilpz3bi0.fsf@localhost> <87h75ip5r6.fsf@localhost> <87zgj46hwo.fsf@localhost> <8735gr15ok.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654009717; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=VAHebbv1lfj0rht1p+i3s6AFARenQuvD5yn5U72GOwU=; b=Jar2z7wIYF7+rJqwlefIF3Ykw23NeyixNaoLN6yp9qyzj3dZScJYu3umjBTnjG/nBGVxth xPl5egD9TyI38tUkYZdEyTGG4Xo+SzCnBhGOIh04Volhl/C8atN+NNCvBwP9KSfeH5WEMl DMwG8W/YiKcn35qR4LQL0XDNUOSLbqd8SRqTp5Fi83L3fedKXkQg4G0RxWtfiZAKANcB0X gW58xqNxFFitZnGPjzB1gBsjVAzAUh/Q3oW09ZwUDp9Sk/EgvNmEqngdKlNjkg5B6TMEmd ViuT3XYRISflwrnZmlEVnxMhC9CLZpHWZaJFOZvkeF8UV5A7qI+hPzlQea6lRg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654009717; a=rsa-sha256; cv=none; b=UIRNRtkEHfOB6OI0jXwFVAzEp3nvEFn8e5XlSc3H5rq29FCmH5waEdKy4JHUtcep9U6xNW rND/pxH/wsfOwH8PZM62X9ShixSrIwoDFw9BOEEVXz3WIorUUMv+KtOoTNVwUA5OTrZTzf pt1zi33WThR4R44HVJDQfOX1QAwJsIDcKFlo0NWxbShErtSzjUPA19uvJnnK29beoFGBi1 dK+A2I3/MvGL06qkzMymimQWYGsHHEkQV6orAijnUYygG9YIQuz7byg01w+rHPMbOlwj64 nMnxqTBTwANCho9ytgetf+q+L8jNPP093mYUs6iRG1Gf3Kg+19+GmEHanrshjQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.86 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E82DA2FAC7 X-Spam-Score: 1.86 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4ikdbJsN4G4e On 30/05/2022 22:38, Max Nikulin wrote: > (let* ((file-executable (executable-find "file")) >        (mime-type-file >         (and file-executable >          (shell-command-to-string >           (format "%s --brief --mime-type --dereference %s 2>/dev/null" >                  ; ... >         ))) >        (mime-type (if (org-string-nw-p mime-type-file) >                       mime-type-file >                     (mailcap-extension-to-mime (or ext ""))) There is an implementation of "file" that does not support --mime-type in particular and long options at all in general: https://landley.net/toybox/help.html#file toybox that is installed on Android. Windows port http://gnuwin32.sourceforge.net/packages/file.htm looks dead, but anyway for cmd.exe "2> nul" should be used instead of ">/dev/null". It may be safer to check (string-match-p "\\`[-a-zA-Z0-9+_.]+/[-a-zA-Z0-9+_.]+\\'" mime-file-type) instead of error redirection. I still think that `mailcap-extension-to-mime' should be fallback, not just alternative to trying file command.