From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8FddKPkTdGIXDgEAbAwnHQ (envelope-from ) for ; Thu, 05 May 2022 20:14:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id eEFqJ/kTdGKaHwEAG6o9tA (envelope-from ) for ; Thu, 05 May 2022 20:14:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4D58199A3 for ; Thu, 5 May 2022 20:14:16 +0200 (CEST) Received: from localhost ([::1]:49344 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmevN-0005i0-UO for larch@yhetil.org; Thu, 05 May 2022 13:05:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46232) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmeeg-0005Gp-Kn for emacs-orgmode@gnu.org; Thu, 05 May 2022 12:48:42 -0400 Received: from ciao.gmane.io ([116.202.254.214]:55530) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmeef-0005CY-1b for emacs-orgmode@gnu.org; Thu, 05 May 2022 12:48:42 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nmeeb-0007Yd-Pf for emacs-orgmode@gnu.org; Thu, 05 May 2022 18:48:37 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] New LaTeX code export option: engraved Date: Thu, 5 May 2022 23:48:29 +0700 Message-ID: References: <87wnf1z1w8.fsf@gmail.com> <87sfpogyag.fsf@localhost> <87v8ukyo94.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Content-Language: en-US In-Reply-To: <87v8ukyo94.fsf@gmail.com> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651774456; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=YjbgsBMHQtEjJ+3PCU6+JUlBXpJ06+m8uCwsC7QS/iI=; b=MT8mbkpRDjaEGj16fK+MmT6SgXntLPRlHBuvU7MMUG5k/jNK4A1NJmV8JMdI3xG2JvWt+X 6X1kL77Ud/qBbffEDA2hrdXupYazx9bEccC4lN55IYlyDHL7OTTdHqGGShiGeT5iS99LJ+ jWHQV/uBkOwsxbNVcHEZevaDWyPNH43dRK8G1+hJyYo+i2egP/8GmCVuFW4ikuTF2tNfGy orNMIh/oTpKJh+2YRIa4ae0wzRk4PD7w/9dTLSQOVJQabQ3Wgb32IA4QksSFYGVl/EKE5K HhFigrMlD5o/YQJ+Ph4jL7qLTuLszjWV21JQlHuMa4ezk9HccxcRjY+AyrtKAQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651774456; a=rsa-sha256; cv=none; b=Mq0UnTWSdDjOjL82dL+k/mtGZ8LGe/tgsOwTbaC9Qm8gQMMaUL20O2Kqm+9sc7Nkc6R35/ pFujlLHPi5qrsCMv2H9/xlVbn/IwglfIdKiPj/LhJ4wBvCcT/35rpxO6Wy/Y3MvhwWrTO7 2bgIIgcZgf3SJqRTZhwk+hje4nghZ/Nop+bKKbioXBn2sUUn5vHm6d9IneJ09vvmlEIaa9 GxB6kMIp8sVi44EKqZ33DA00uTj55yHXtIc6pWfE1TX+oXSDlBvrYpMOsp4yt8AbdLxNje CxL+bPKXoGC9LxvSkfpaPzchlxsOFq+umwetqgslGFbrfS0ezKkF0sR0VLSHwg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.41 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4D58199A3 X-Spam-Score: 2.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: UgeYP+9Tgxlj On 05/05/2022 22:17, Timothy wrote: > Subject: [PATCH 1/4] ox-latex: Refactor `org-latex-src-block' When I was trying to fix an issue with caption, I was not brave enough for massive changes. I do not like the original code of the function. There are some unit tests for exporting of src blocks. Maybe the new option should be tested as well. > +(defun org-latex-src-block--verbatim > + (src-block info _lang caption caption-above-p _label > + _num-start _retain-labels _attributes float) On the one hand I have no a better suggestion, but on the other hand 10 arguments is too much for straightforward code from my point of view. Unsure that getting parameters in each function or passing a property list would not be worse however. It reminds me a case when a colleague failed in despair trying to figure out what was wrong with his 15 argument fortran function. I do not remember exactly whether it was a missed argument or an extra one. The last one was assumed to be a parameter (constant) and the identifier was not available in debugger since compiler just substituted the number without creation of a symbol and it added even more confusion. My other notes are rather loosely related to your patches. The issues may be postponed till someone will start a new thread for them. My hope is that some of them might be easily addressed so that they will not need separate testing. A problem with percent sign in captions is tracked on updates.orgmode.org. Some environments has not fixed yet: https://list.orgmode.org/YT2PR01MB45101E27DC6251D8F8B7B366F6EC9@YT2PR01MB4510.CANPRD01.PROD.OUTLOOK.COM/ That time I was puzzled why the option is named "multicolumn" while only regular "figure" is added: > + (cond ((string= "multicolumn" float) > + (format "\\begin{figure*}[%s]\n%s%s\n%s\\end{figure*}" If language is added to "#+begin_example:" than the block content is properly fontified in the Emacs buffer. It would be great to treat such example similar to source block during export. When some code is not supposed to be executed, it is natural to use example block. I am curious if new functions may be reused.