From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YE7SC8XqGWKWiwAAgWs5BA (envelope-from ) for ; Sat, 26 Feb 2022 09:54:29 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id WGaXBMXqGWLbNgEAG6o9tA (envelope-from ) for ; Sat, 26 Feb 2022 09:54:29 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B38012389A for ; Sat, 26 Feb 2022 09:54:28 +0100 (CET) Received: from localhost ([::1]:45286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNsqR-00081u-8r for larch@yhetil.org; Sat, 26 Feb 2022 03:54:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNsmm-00081i-3D for emacs-orgmode@gnu.org; Sat, 26 Feb 2022 03:50:42 -0500 Received: from ciao.gmane.io ([116.202.254.214]:53482) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNsmk-0008Of-6a for emacs-orgmode@gnu.org; Sat, 26 Feb 2022 03:50:39 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nNsmh-0006ZK-BF for emacs-orgmode@gnu.org; Sat, 26 Feb 2022 09:50:35 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [BUG] org-insert-link should use DEFAULT in read-string when asking for description Date: Sat, 26 Feb 2022 15:50:29 +0700 Message-ID: References: <87sfs7jafo.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US In-Reply-To: <87sfs7jafo.fsf@gmail.com> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645865668; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=XTxUPzFgX7T3PzTUceCuB9aFgHoLtGwbnfDCXlApOlI=; b=F2cqjtsKE3BIH9qrEnFPEqz3+p89ikGz+/jbV/+kyGBWe4gy71b2MnMO4kUTd6xCWaNJlV VMU877N3OO8NN8Cu2W+3BdIMhMzcX95DHkrskIu7WmL0CDvwdNnViawF+D8dVHhAVC/6uU Ff5tRLo7jih4oznUyzh5OEKSqAQGi4xtqI2OuN1n1lv2Gb4X7Z61hLUUkvBik91O+U6MG+ iwRO9IOqtjV/mJxTIr3j3WWf/UhHq1Z7GnOHpSJrIYcc8YmAZrTsiKWWg40ohwJ1/W+lNB flbGHfaBeMcRuoBWcWVtt/NMyYoPcH/zCmYyBHNxKSkwxCg1ZpMqDQNdr7R+3w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645865668; a=rsa-sha256; cv=none; b=FkxDjva0NMxGhCGMQdGRKGaoJhWNOdTB0QIQ0JTnv9EArYJ1uMDZR01FWw5l+fgTkxcDqo l7KCeFTBRJw7H83SrzI8wqaXo+Q1ed6EDuXBjaQcQm1mxlD5QVP+5wWnZqz9fKyC5C3gGu MBgfv2TCRqpekM3XZyH2QbvBiqgks98MkDMFbYxOQEG+sXT3Q8MRmtBRQU/VQLlPl4nmfR wnz7uhPeA8RB3knruYq/3SHBsKeysfqklkjQrABFZzh3WSIk5VbktBq0wGGpZAnef3XS0l PFcl58jaZ3B3/aNBnBKjoKdszfbHO2hmNS65jON/Znza+70qoxHlMZV/mC1FeA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.08 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B38012389A X-Spam-Score: 2.08 X-Migadu-Scanner: scn0.migadu.com X-TUID: 7wzbQ3iiy6O1 On 25/02/2022 21:19, Visuwesh wrote: > > Currently, when asking the user for the description of link, > `org-insert-link' calls `read-string' with a non-nil INITIAL-INPUT but > this argument is discouraged and deprecated; moreover, it is unfriendly. > > `org-insert-link' should, ideally, use the DEFAULT argument. If the > user decides that the suggested description is okay, they can type M-n. Due to lack of experience with emacs I can miss something. If so, please, correct me. Are you suggesting replacing (read-string "rs-initial: " "Some initial") by (read-string "rs-default: " nil nil "Some default") ? Is it possible to override provided default description by empty string in the latter variant? Currently it is possible to erase description using just backspace or C-S-backspace. P.S. Many GUI applications pre-select whole value when some input field is focused, so it is possible to overwrite current value by typing anything. It may be convenient but is not consistent with emacs behavior. Moreover it makes uncertain if visually selected text overwrites X PRIMARY selection.