From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ELYCFN3R1WFn2AAAgWs5BA (envelope-from ) for ; Wed, 05 Jan 2022 18:14:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id SJCAEN3R1WFUhAAAauVa8A (envelope-from ) for ; Wed, 05 Jan 2022 18:14:05 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D46723A4FC for ; Wed, 5 Jan 2022 18:14:04 +0100 (CET) Received: from localhost ([::1]:44122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n59rP-00085S-WB for larch@yhetil.org; Wed, 05 Jan 2022 12:14:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n59qD-0007Ol-0D for emacs-orgmode@gnu.org; Wed, 05 Jan 2022 12:12:49 -0500 Received: from ciao.gmane.io ([116.202.254.214]:46592) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n59qB-0000Mt-7w for emacs-orgmode@gnu.org; Wed, 05 Jan 2022 12:12:48 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1n59q8-0003vK-0V for emacs-orgmode@gnu.org; Wed, 05 Jan 2022 18:12:44 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] ob-shell-test, test-ob-shell and introduction Date: Thu, 6 Jan 2022 00:12:28 +0700 Message-ID: References: <17d48f09729.ddbece82213631.8340272801066201269@excalamus.com> <87pmqs58mx.fsf@gmail.com> <17d53474fd6.c0a62421660695.6561002670353136607@excalamus.com> <87lf13pcme.fsf@gmail.com> <17d8ddd76f7.d167f605179643.3635445903460764440@excalamus.com> <87bl1u49ru.fsf@tsdye.online> <17dcc5a0e3e.d8ca0ef6361712.4976360594738663013@excalamus.com> <875yr4iu3a.fsf@tsdye.online> <17e11edb77e.adb20ab5289948.958495178633735939@excalamus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <17e11edb77e.adb20ab5289948.958495178633735939@excalamus.com> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 18 X-Spam_score: 1.8 X-Spam_bar: + X-Spam_report: (1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-1.057, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641402844; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=5sa63uPGrnSbVCYqM+6RvUk1/ua8dZg0s3zI55ipuAY=; b=lGT/CHEOrZnT7lme7sgB8jcdV8XyG3yjss3nlR8jVjPd10UHCLWjqhZlj7lMA0TIpcIueD 8EnI3LC1qOd7qZbZTF1qOv/VelM7kf+jOFwYUprhLi8oLFcSxSg8y0FVJh8HWU61O5N22v EN8qGRB9SzbHVP+7kb2Xu5bxVglceA9EIVClDVkClvukUZ0/Cf0AU0BzXpAdVBfs5Wy15r qoadNO00SRsm9GKWZk0maPP78l/38Onwl5WHcMtRjSFh3QEVs18o7ZlrRl/2eHDsge1Cr/ R+QRbP1RmbAPzVAr8uHsBAyqdS/eWOXgANVLbq39WjEfq4h01jQKAEah6BZkug== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641402844; a=rsa-sha256; cv=none; b=VzEbE0RKf0+K2EjWT4BEieCDDwpeMzB/0dTfPb1SuqwYD+ArmMPaUDhnbzhdCBvSljbvRi 3+FZk0n0nE37tK2+qb7XXwSNWlNWYqw2IKe+bNTg2iDfXhj7XFCEooeYihiPgVBCPKxgJN 9G+zdwvVUhCyCgaxzhFkqZpDPQHDvWsqBQwY7tX7muI/CHatu9GM7AqHhEe0xMhHL2URrL XqknN5yAJ3XogCRbIgXgQCeNAt2nllo/J4S5/UUlzVQ1kC92gSGUiy2ylETDIYkcUsH0mf OzsF1Y6xB/oyskLvps/vEl9+32/Cw26Ta6Y0zYXEdiNDcuCwlUtPD/bwRDBZ5w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.60 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D46723A4FC X-Spam-Score: -3.60 X-Migadu-Scanner: scn0.migadu.com X-TUID: Y2ANuFULA9db On 01/01/2022 02:18, Matt wrote: > > > Wow. Nice work! > > Thanks. I pushed things to Worg, if you haven't seen already > (https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-shell.html). > If you read it and find anything missing or unclear, please let me > know. Thank you, I was not aware of ":cmdline" argument and of ":shebang" as a means to avoid stray prompts (I have seen mentions of similar problem for other languages in this list). I have noticed some glitches. - https://www.mirbsd.org/pics/logo-grey.png works only with http: protocol for me. - I am unsure concerning example after "…or as a standlone script.", maybe it should be wrapped into #+begin_example. - In some cases "sh" is used despite bashisms in the code like "declare" or "echo -ne". Actually "printf" may be more convenient instead of "echo -n" - "export" in session example is unnecessary. It is matter of taste though. Bash and dash is not the case, but some shells require that assignment and export should be separate commands. - In your examples variable values are simple. Often it is safer to add double quotes around variable or command expansion. I would consider adding quotes just to encourage people to do the same by default with hope that less scripts will give strange results in response to a file name containing a space. Actually my first impression was that backslashes before quotes in some cases were added by mistake. Another unescaped pair of quotes may make your intention more clear. However it is related to code style where everybody has opinion, so I do not insist.