From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sDcCET2T0mFQ5QAAgWs5BA (envelope-from ) for ; Mon, 03 Jan 2022 07:10:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id UhKcDT2T0mHXggEAauVa8A (envelope-from ) for ; Mon, 03 Jan 2022 07:10:05 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E7AB2302AF for ; Mon, 3 Jan 2022 07:10:04 +0100 (CET) Received: from localhost ([::1]:51220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n4GXk-0005hY-2n for larch@yhetil.org; Mon, 03 Jan 2022 01:10:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4GWp-0005hQ-3S for emacs-orgmode@gnu.org; Mon, 03 Jan 2022 01:09:07 -0500 Received: from ciao.gmane.io ([116.202.254.214]:56126) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4GWn-0006UV-I5 for emacs-orgmode@gnu.org; Mon, 03 Jan 2022 01:09:06 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1n4GWl-0004xJ-Pv for emacs-orgmode@gnu.org; Mon, 03 Jan 2022 07:09:03 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [patch] improved: add TTL as defcustom to ox-icalendar Date: Mon, 3 Jan 2022 13:08:54 +0700 Message-ID: References: <20211230225919.1a660666@hsu-hh.de> <20220102142849.0af72bcb@hsu-hh.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20220102142849.0af72bcb@hsu-hh.de> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-3.354, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641190205; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qwDNwbxOr9OoKJmGYsgF6qR4O1Sj5LAWZZsDCNNctps=; b=pUAq50gT73wtZx6sRHhUecmS1YOK1WswJ+tcmlXhLQhaKA6nUXLKGm7ogSxGC1yrzBXR03 qdaT3td2BqNQV7/7gSl8PCHISBFJt2u2MVNQDoGdy/G9Fq5XaBgtJwlV1e6hNi8obCTYQz fvrNWV1KFCoUwix2wWyEMe46weLX2CwfMuQ2I1gnvswAgzvBhYHmiMS/aA9q4U3BbVgz+U znvqGeVqQPThAkFvkAFiYBt+sQmmnHcidCc8FifFdmr2vu2iOnLVsQslRh5/9+Ux2mOB5N aiMey+psmXVs9sr3FskemPEHT/RcATUG9G4Mn1eBmP04uBKPiAgQav9zfKF3Vg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641190205; a=rsa-sha256; cv=none; b=TqwzAR9AX7BaAwwOr9ybStjg0aBRb9lmjX7g8fSzgE8rlqXW40wmjSOryPpsEFaoX91Arm JLutnKtmfWnirZtUf+lWUqvswpsSuDNZqeEjKJj4zCqjwH7aZnjiGcyiO/y8DFeJCdfF90 nbIhOm66DKwAxFvx9rGs2+3QqTFbXlewONN+ge/pbf1csT+I0X99PNjrJBcoocDfA3WqZI Lohp5zGr8HMF73pUtgg2/eWPSFiwUh7cGqJdeLR8vMMMlrNGdKIkaRPN+PRNbC8uQLNn0f S8qWoqBwx43Amh9wsNkSxqGcMRybAyu+9+qD9FBpBE5F5e5pU07fIk9TBGe73A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.49 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E7AB2302AF X-Spam-Score: -2.49 X-Migadu-Scanner: scn1.migadu.com X-TUID: dVMq1ixpMyIJ On 02/01/2022 20:28, Detlef Steuer wrote: > >> This is my first try ever to contribute anything in elisp. Thanks for the patch. It is tracked on https://updates.orgmode.org/ It is easier to review and to apply a patch when it it is prepared in context format ("-u" option of diff). Several additional lines of code above and below changed ones makes the patch more tolerate to unrelated changes in the same file. It is a hint for humans as well. See info "(diffutils) Tips for Patch Producers" https://www.gnu.org/software/diffutils/manual/html_node/Tips-for-Patch-Producers.html or "NOTES FOR PATCH SENDERS" section in "man patch". If you have never used git (or other VCS) before then it is likely an overkill for a single patch, diff output with manually added description is OK. However you may find such tool rather convenient as number of changes will grow. See https://orgmode.org/worg/org-contribute.html for some hints addressed to contributors. I am not a nextcloud or org-icalendar user, so while I expect that suggested change is an improvement, I can say nothing concerning the code.