Re: [Patch] to correctly sort the items with emphasis marks in a list

[Max Nikulin <manikulin@gmail.com>]

On 25/11/2021 19:11, Ihor Radchenko wrote:
> Maxim Nikulin writes:
> 
>> I think, new variant should be committed even it does not fix Juan's
>> case. He have not confirmed the fix yet.
> 
> The patch does apply onto main, but I have a comment.
> 
>> +      ;; Emphasis of second word.
>> +      ;; Locales with significant spaces (C, es_ES, pl_PL)
> 
> I suspect that most of maintainers simply use C/en_US locales and we may
> not be able to catch test errors in foreign locales. Do you know a good
> way to automate testing with different locales? Can it be somehow
> automated?
> 
> Otherwise, the patch looks good for me.

For this test locale is fixed to "C", see below. Concerning tests of 
multiple locales, I have no idea besides a virtual machine (qemu, 
VirtualBox, etc.) or container (docker, LXC, etc.)  with enough enabled 
and generated locales. I think, more locales may be enabled on SourceHut 
as well.

https://list.orgmode.org/s864tq$jet$1@ciao.gmane.io/
On 21/05/2021 00:06, Maxim Nikulin wrote:>
> In the following subthread Nicolas mentioned that some of them could fail
> https://orgmode.org/list/87r1j6b6ku.fsf@nicolasgoaziou.fr
> I do not see any reason for failure. I just have tried C.UTF-8, en_US.UTF-8,
> es_ES.UTF-8, and ru_RU.UTF-8 locales (interactively) and do not see any
> problem. This set of locales has 3 different collation rules,
> however I do not think it matters for tests.
> 
> On 20/04/2021 19:37, Maxim Nikulin wrote:
>> On 20/04/2021 00:50, Nicolas Goaziou wrote:
>>> Maxim Nikulin writes:
>>>
>>>> On 19/04/2021 23:08, Nicolas Goaziou wrote:
>>>>>> +      ;; Space role in sorting.
>>>>>> +      ;; Test would fail for locales with ignored space, e.g. en_US, it works
>>>>>> +      ;; in C and currently rare locales having significant space (es_ES, pl_PL)
>>>>>> +      (should
>>>>>> +       (equal "- Time stamp\n- Timer\n"
>>>>>> +              (org-test-with-temp-text "- Timer\n- Time stamp\n"
>>>>>> +                (org-sort-list t ?a)
>>>>>> +                (buffer-string))))))
>>>>> Since this test is bound to fail for some developers, I assume it
>>>>> shouldn't be included.
>>>>
>>>> Locale "C" is forced for this group of tests.
>>>
>>> Sorry, I don't understand. There is no locale change around this test,
>>> so it will fail, for example, for me. I wouldn't want to get a noisy
>>> failure each time I run tests.
>>
>> Certainly flaky tests must be avoided. However I can not identify the source of confusion (yours or mine).
>>
>> There is redefinition of `string-collate-lessp' to run tests with "C" locale:
>> https://code.orgmode.org/bzg/org-mode/src/master/testing/lisp/test-org-list.el#L1207
>>
>> And it works for me