emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [Patch] to correctly sort the items with emphasis marks in a list
Date: Thu, 25 Nov 2021 23:59:23 +0700	[thread overview]
Message-ID: <snofdg$8b1$1@ciao.gmane.io> (raw)
In-Reply-To: <877dcw3052.fsf@localhost>

On 25/11/2021 19:11, Ihor Radchenko wrote:
> Maxim Nikulin writes:
> 
>> I think, new variant should be committed even it does not fix Juan's
>> case. He have not confirmed the fix yet.
> 
> The patch does apply onto main, but I have a comment.
> 
>> +      ;; Emphasis of second word.
>> +      ;; Locales with significant spaces (C, es_ES, pl_PL)
> 
> I suspect that most of maintainers simply use C/en_US locales and we may
> not be able to catch test errors in foreign locales. Do you know a good
> way to automate testing with different locales? Can it be somehow
> automated?
> 
> Otherwise, the patch looks good for me.

For this test locale is fixed to "C", see below. Concerning tests of 
multiple locales, I have no idea besides a virtual machine (qemu, 
VirtualBox, etc.) or container (docker, LXC, etc.)  with enough enabled 
and generated locales. I think, more locales may be enabled on SourceHut 
as well.

https://list.orgmode.org/s864tq$jet$1@ciao.gmane.io/
On 21/05/2021 00:06, Maxim Nikulin wrote:>
> In the following subthread Nicolas mentioned that some of them could fail
> https://orgmode.org/list/87r1j6b6ku.fsf@nicolasgoaziou.fr
> I do not see any reason for failure. I just have tried C.UTF-8, en_US.UTF-8,
> es_ES.UTF-8, and ru_RU.UTF-8 locales (interactively) and do not see any
> problem. This set of locales has 3 different collation rules,
> however I do not think it matters for tests.
> 
> On 20/04/2021 19:37, Maxim Nikulin wrote:
>> On 20/04/2021 00:50, Nicolas Goaziou wrote:
>>> Maxim Nikulin writes:
>>>
>>>> On 19/04/2021 23:08, Nicolas Goaziou wrote:
>>>>>> +      ;; Space role in sorting.
>>>>>> +      ;; Test would fail for locales with ignored space, e.g. en_US, it works
>>>>>> +      ;; in C and currently rare locales having significant space (es_ES, pl_PL)
>>>>>> +      (should
>>>>>> +       (equal "- Time stamp\n- Timer\n"
>>>>>> +              (org-test-with-temp-text "- Timer\n- Time stamp\n"
>>>>>> +                (org-sort-list t ?a)
>>>>>> +                (buffer-string))))))
>>>>> Since this test is bound to fail for some developers, I assume it
>>>>> shouldn't be included.
>>>>
>>>> Locale "C" is forced for this group of tests.
>>>
>>> Sorry, I don't understand. There is no locale change around this test,
>>> so it will fail, for example, for me. I wouldn't want to get a noisy
>>> failure each time I run tests.
>>
>> Certainly flaky tests must be avoided. However I can not identify the source of confusion (yours or mine).
>>
>> There is redefinition of `string-collate-lessp' to run tests with "C" locale:
>> https://code.orgmode.org/bzg/org-mode/src/master/testing/lisp/test-org-list.el#L1207
>>
>> And it works for me




  reply	other threads:[~2021-11-25 17:00 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-02 18:15 Juan Manuel Macías
2021-04-09 22:28 ` Nicolas Goaziou
2021-04-10  0:01   ` Juan Manuel Macías
2021-04-10 10:19     ` Nicolas Goaziou
2021-04-10 11:41       ` Juan Manuel Macías
2021-04-13 17:31         ` Maxim Nikulin
2021-04-13 19:08           ` Juan Manuel Macías
2021-04-14 15:42             ` Maxim Nikulin
2021-04-14 15:51               ` Maxim Nikulin
2021-04-14 17:07               ` Juan Manuel Macías
2021-04-14 21:36                 ` Juan Manuel Macías
2021-04-15 14:58                 ` Maxim Nikulin
2021-04-15 18:21                   ` Juan Manuel Macías
2021-04-16 14:59                     ` Maxim Nikulin
2021-04-16 15:30                       ` Maxim Nikulin
2021-04-17 13:27     ` Maxim Nikulin
2021-04-18 17:52       ` Juan Manuel Macías
2021-04-18 21:20         ` Juan Manuel Macías
2021-04-19  8:33           ` Nicolas Goaziou
2021-04-19 12:34             ` Maxim Nikulin
2021-04-19 16:08               ` Nicolas Goaziou
2021-04-19 17:00                 ` Greg Minshall
2021-04-19 17:17                   ` Tom Gillespie
2021-04-19 18:00                     ` Greg Minshall
2021-04-19 17:36                 ` Maxim Nikulin
2021-04-19 17:50                   ` Nicolas Goaziou
2021-04-20 12:37                     ` Maxim Nikulin
2021-04-20 12:20                 ` Maxim Nikulin
2021-04-20 13:57                   ` Nicolas Goaziou
2021-04-20 15:51                     ` Maxim Nikulin
2021-04-20 20:37                       ` Nicolas Goaziou
2021-04-21 13:10                         ` Maxim Nikulin
2021-04-21 15:45                           ` Juan Manuel Macías
2021-04-24 14:41                             ` Maxim Nikulin
2021-05-20 17:06                           ` [Patch] tests for org-remove-invisible Maxim Nikulin
2021-05-20 18:06                             ` Nicolas Goaziou
2021-09-27 16:53                               ` Max Nikulin
2021-11-25 12:11                           ` [Patch] to correctly sort the items with emphasis marks in a list Ihor Radchenko
2021-11-25 16:59                             ` Max Nikulin [this message]
2021-05-15 20:43                     ` Bastien
2021-05-15 22:09                       ` Nicolas Goaziou
2021-05-16  6:04                         ` Bastien
2021-04-28  5:46     ` Bastien
2021-04-28  6:37       ` Nicolas Goaziou
2021-04-28  6:49         ` Bastien
2021-04-28  8:04           ` Bastien
2021-05-15 13:32             ` Bastien
2021-05-15 15:10               ` Maxim Nikulin
2021-05-15 20:44                 ` Bastien
2021-04-12 13:50 Juan Manuel Macías
     [not found] <mailman.57.1618243212.17744.emacs-orgmode@gnu.org>
2021-04-12 18:51 ` Ypo
2021-04-12 23:18   ` Juan Manuel Macías
2021-04-12 23:52     ` Samuel Wales
2021-04-13 14:16       ` Juan Manuel Macías

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='snofdg$8b1$1@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: [Patch] to correctly sort the items with emphasis marks in a list' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).