From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YH3BEBVRnmFnEAEAgWs5BA (envelope-from ) for ; Wed, 24 Nov 2021 15:49:57 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qO5cDBVRnmH4WAAAB5/wlQ (envelope-from ) for ; Wed, 24 Nov 2021 14:49:57 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C8A2498D8 for ; Wed, 24 Nov 2021 15:49:56 +0100 (CET) Received: from localhost ([::1]:54894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mptau-0001Su-0B for larch@yhetil.org; Wed, 24 Nov 2021 09:49:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mptZu-0001Ri-7h for emacs-orgmode@gnu.org; Wed, 24 Nov 2021 09:48:54 -0500 Received: from ciao.gmane.io ([116.202.254.214]:39544) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mptZs-00026e-SO for emacs-orgmode@gnu.org; Wed, 24 Nov 2021 09:48:53 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mptZq-0000VF-CI for emacs-orgmode@gnu.org; Wed, 24 Nov 2021 15:48:50 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] Fix regex for determining image width from attribute Date: Wed, 24 Nov 2021 21:48:42 +0700 Message-ID: References: <87czmtuy0p.fsf@gmail.com> <87ilwl71gh.fsf@gmail.com> <87a6hxuw0y.fsf@gmail.com> <877dd07fnb.fsf@gmail.com> <8735noqig0.fsf@gmail.com> <87wnl05ag6.fsf@gmail.com> <87y25fq5d2.fsf@gmail.com> <8735nnlaef.fsf@gmail.com> <87v90jph1w.fsf@gmail.com> <871r37l96a.fsf@gmail.com> <87k0gzpb5s.fsf@gmail.com> <87h7c2pb6w.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <87h7c2pb6w.fsf@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-4.1, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637765396; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=kry1+ij3TdmjbSGrqQ9e8vyderQVYx0qtZ6ClmHiXp8=; b=p0zpQvXmcpNaNgCkNvqSp8iECWVGIGa7hY86Gmk9OXa6Fy/FgUtzt7t8De1LhSnfr7b/2P BNWZvcvJRvCeBZxn2Pf3T7tDA1N95BttXRxoOKmUYEI3JcnBRzL6QLLmxFDXvMr3k1iZqQ uY3rEsHWqh1wirNnisiWPLFTLZLskzJlDXIpMobxScRfV72yMSxT3lGjCBhB/6CGkjUdLm 3cRPSBv8sLBIWG1JwbOlUDsW0/n9sH92Gh4dADPPpu2jWMEPTr4lQUZcMvLdel7XB0zzjo yEmxk73cCrKNrPWj46/FAfwJuhnMnkyQXAX2IqmDGwHNJFoCXTiYXq6A6Mkyxg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637765396; a=rsa-sha256; cv=none; b=b/HdC1Xxx6lsnu/2QNtCQsjwYIKy78V7p3PZtr8FfXxuR+NdRVrAkKLICPAQI807UztrMW eVBkOE2HfNoeFVUy0z+VOLjr5nzcFwrDAU4xKUzNyqkVmK3yATsy3qyZ0T/up3lHAd5lzs Ohms0HWdb8HjL1FFs8xsmw9uBsY/1KA46tcLfX5JgwfHtaifEiv08/HZxCtpCfzJLzqHWB v4dMkr3PyHJUQY5RULNdCeGH7OdT9USKuPu1YaEi6d5zIY0+2gp9mmqk/FxxupRlD7FwHA tFjLUuwvXR6sMaQJ2KSFuHJpOq5nhuaNn+btKXL/L4UizuhaFWAZv1tTid0FnA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.29 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C8A2498D8 X-Spam-Score: -2.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3dVTwqaBMlJ/ On 24/11/2021 08:57, Matt Huszagh wrote: > Max Nikulin writes: > >> I may be wrong, but it seems both the old and the new regexps match >> >> #+attr_html : :width 50% >> >> that is not a keyword due to a space before ":". The dot in the regexp >> is too permissive. > > I agree. > >> Despite ".*" includes ": " before ":width", I would prefer explicit >> space before ":width". > > Currently we have a space before .*. Would you prefer it after? Anyway, > I've also implemented this change. Let me know what you think. This is related solely to docscring. > +that is not found, use the first #+ATTR_.*:width specification. I am unsure how to make this phrase more clear, maybe something like "use :width value from the first #+ATTR_,*" or even "#+ATTR_xxx" to avoid ".*". > + (re-search-forward (funcall attr-re "[a-z]*?") > + par-end t)))) https://orgmode.org/worg/dev/org-syntax.html#Keywords has no requirement that it may be letter only. I expect it to be more coherent with http://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/org-element.el#n2387 that uses "\\S-" non-space character.