From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uBrJJ5c4kWHEuQAAgWs5BA (envelope-from ) for ; Sun, 14 Nov 2021 17:25:59 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0TNdI5c4kWFcJwAAB5/wlQ (envelope-from ) for ; Sun, 14 Nov 2021 16:25:59 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1F2E83EB2F for ; Sun, 14 Nov 2021 17:25:59 +0100 (CET) Received: from localhost ([::1]:42918 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmIKL-0000oG-OZ for larch@yhetil.org; Sun, 14 Nov 2021 11:25:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35978) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmIJn-0000ne-NO for emacs-orgmode@gnu.org; Sun, 14 Nov 2021 11:25:25 -0500 Received: from ciao.gmane.io ([116.202.254.214]:49592) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmIJl-0001S8-0Y for emacs-orgmode@gnu.org; Sun, 14 Nov 2021 11:25:23 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mmIJh-0004pt-50 for emacs-orgmode@gnu.org; Sun, 14 Nov 2021 17:25:17 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend Date: Sun, 14 Nov 2021 23:25:05 +0700 Message-ID: References: <87bl2mycxq.fsf@kraus.my> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <87bl2mycxq.fsf@kraus.my> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-3.402, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636907159; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=nIDnH3PO9PI/HXf9LiLmRdW8Ug3gAwiUza0NHQT7CHk=; b=qS7tQnH2NCUUAewrKke90STQfN/FLZPLtvGCCeqWCHpI6+3KsSia6zpSXMNkNMyQ/VV6cf vEwjnV1FkPceTV/fcJiOgSeLk4gucclN+HMLGcZfVK73yJqGfiGyAhN04aoRg7vq9HNWfB 3LyWeEvDSNyMCw1Gri7qiqfdiSFynN/9oC8kC40D6nIbEWOIWMUqwgDSH6rh2BbrzJOM47 PK4CrN+JLS4ZUnRyo4Tt/TWaYBDI1EaK4KJTOVRC+NUxAbrfAThysRv18iHF0/GOpzHhfp JeRXjLH0TDy9New65AH3neN5AML6sRMf3TXry+BOuZUAKI4FBAtHCvqC5pJl1Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636907159; a=rsa-sha256; cv=none; b=FtNLxriH8ox5pRSNiGKDGxViUfB4vozquOcBrCZ9DGKQmpWSOCepFSgFlcihH+WhHKhee8 hgdA0yxab51VUGYcupyaveOl0TOWw/7pwjkyguJeRIXcZ/gQ/Ve4GAD8A2JqEFIwCaMd4N 4C23oY73Z5ShnxWSP5KewgSmL0yOBLMQjekYBLjBfI96zKzb4QN/lPTcJyzeIubQdWXDdm IekCFoOZe9p3/MpOFkqM/ck01i+bORXdXsZI8Q1/qBLuoWDwRK9eA0nvAAi2IGZHKnFNLt ZHOD1kpK5gzmVoJBPMYcvYwCNZtNKZLZuz+3GMcvV0ezUvIPSfFlcY1dLmIaLw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.34 Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1F2E83EB2F X-Spam-Score: -2.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: qf7zLPBYjG5P On 14/11/2021 22:28, Daniel Kraus wrote: > * lisp/ob-clojure.el: Add support for babashka and nbb backend. > --- > +(defun ob-clojure-escape-quotes (str-val) > + "Escape quotes for STR-VAL." > + (replace-regexp-in-string "\"" "\\\"" str-val 'FIXEDCASE 'LITERAL)) > + > +(defun ob-clojure-eval-with-babashka (bb expanded) > + "Evaluate EXPANDED code block using BB (babashka or nbb)." > + (let ((escaped (ob-clojure-escape-quotes expanded))) > + (shell-command-to-string > + (concat bb " -e \"" escaped "\"")))) Does not it an open door for security vulnerabilities? Consider a string somewhere in the code: "`echo arbitrary code execution`". Only outer quotes are escaped.