From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0DjJLTbQZmFlEgEAgWs5BA (envelope-from ) for ; Wed, 13 Oct 2021 14:25:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id eGOCKTbQZmGLDgAA1q6Kng (envelope-from ) for ; Wed, 13 Oct 2021 12:25:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1E03520D8D for ; Wed, 13 Oct 2021 14:25:26 +0200 (CEST) Received: from localhost ([::1]:57972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1madJz-0006Yz-Gc for larch@yhetil.org; Wed, 13 Oct 2021 08:25:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1madIR-0006KE-IU for emacs-orgmode@gnu.org; Wed, 13 Oct 2021 08:23:47 -0400 Received: from ciao.gmane.io ([116.202.254.214]:46960) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1madIP-0006jS-UR for emacs-orgmode@gnu.org; Wed, 13 Oct 2021 08:23:47 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1madIM-0009pS-EU for emacs-orgmode@gnu.org; Wed, 13 Oct 2021 14:23:42 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken Date: Wed, 13 Oct 2021 19:23:35 +0700 Message-ID: References: <87mtnovv7f.fsf@alphapapa.net> <87h7dvy70t.fsf@localhost> <87ee8zxwic.fsf@localhost> <878rz3ddet.fsf@gmail.com> <87czoaug5x.fsf@gmail.com> <87o87tso54.fsf@localhost> <87pms9mf7v.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <87pms9mf7v.fsf@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634127926; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=h7DlX2Dv5yfM8PKKiFbzJgDDhVtyr/Ze9dX15We6MoY=; b=PEG8t9xkpScTZRg13wxYbDMkYuaOY9juMnARhSlw5dQeLuuSNtqV6G8g3N5QB0hQ4zj8vv JF3+NV9QV6XNc0YJiL2nr5M1bwrj0RbHgq69watOq9W+HcF95OX8NQQ/dE5VMS1D5d43X9 05oQaAIDYSZlKtulG60tppiOPitNCo6sZfMA5o6kS95zbA5uDEcQUyOdom2iXLH4tQ/D+D bSxpaMqBaOC4a5/n6/j6WZMBMBKhTXxqOGzyoFXN8noFCW5l+2wm9bX3BxpGse+zTcBX3H ToZPgHXw628Ryfd+f9HtrXjp2ICDyyMTJ2nVrgqaBvFLh0tLEcwVBrDsbIyzNQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634127926; a=rsa-sha256; cv=none; b=ntBeIO+gNX40b2vSvNj1o/P6BV2KVyi4bir+E7cNNHqTZV9BBaUixbBkUCmkE3Y/osEeui AcyY7kDqg6Us6M+RmQQuSkqCdmX+HxIPjQ27Q+PzZxPriegWNRwZSKZL4RGKWeY4hx+Joq JXVVgSx92iSxGoObIydJyaeOXRXEg4/cCC1I1KfWEgAY+EH9BWnRgsIA/Bm0is4UaAsrzq 5A1RUXYNU69JIV+RYfqtV6C/X0dWajAhm/DBelCPc+WbvmJMg2wPWcwaPJMELnQ5g294Qz wOzx1AO4uQclufIBVdp5YjlK0XXSW/paRwlqnGulWf8Al1Vzw83AU2KG/77XEA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.81 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 1E03520D8D X-Spam-Score: -1.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: EWjCWHgIAEG1 On 13/10/2021 16:44, Marco Wahl wrote: > > Clearly I'm for kicking out org-no-popups completely. Many details have > been mentioned already. The big argument for that change for me is that > the code gets simpler. I have no strong opinion. Second patch locally restoring `pop-up-windows' is more suitable for the bugfix branch since it is closer to older behavior. Dropping the macro completely may be a step to future, so first version of patch is more suitable for main (do not forget to drop other variant during merge however). I am not confident with complicated `display-buffer' machinery. It has action argument that looks promising to specify local hint to override default actions but to let users customize `display-buffer-alist'. I have no idea of particular hint for `org-goto' though. Unfortunately `with-output-to-temp-buffer' used there does not allow to specify action argument for `display-buffer'. Unsure if `temp-buffer-setup-hook' can be used to prepare a window for `display-buffer'. Does someone have settings that pins help buffer to particular window/frame of location in a frame (e.g. bottom of "sidebar")?