From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IEORODJpXGHWQwAAgWs5BA (envelope-from ) for ; Tue, 05 Oct 2021 17:03:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OJ1GNDJpXGGSDAAAB5/wlQ (envelope-from ) for ; Tue, 05 Oct 2021 15:03:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 110AC2B568 for ; Tue, 5 Oct 2021 17:03:14 +0200 (CEST) Received: from localhost ([::1]:48486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXlyG-0007Yk-BO for larch@yhetil.org; Tue, 05 Oct 2021 11:03:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56736) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXll4-0006fI-B0 for emacs-orgmode@gnu.org; Tue, 05 Oct 2021 10:49:35 -0400 Received: from ciao.gmane.io ([116.202.254.214]:46048) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXll3-00083K-1Y for emacs-orgmode@gnu.org; Tue, 05 Oct 2021 10:49:30 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mXll1-0002Jc-0u for emacs-orgmode@gnu.org; Tue, 05 Oct 2021 16:49:27 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken Date: Tue, 5 Oct 2021 21:49:17 +0700 Message-ID: References: <87mtnovv7f.fsf@alphapapa.net> <87h7dvy70t.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <87h7dvy70t.fsf@localhost> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633446194; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ueqGthYs3hiWAqrIAiN5NUkU7R9SwPuW6azLNJFY3WQ=; b=Gq5t3tS1RCMjtCM3xP9Q2o0OmROQvC+07A55wfPZtbtPkj4KHxerw4IBZfHRXUZ6aKlfzW QQr2YvekQZ/BOVOEM3ZJjDd3GDzIKr3e8ww21QXVMd9EplvrQPSBpx4EB9hIj408VrcjvT gr1Osm3UIo8SZeOjIFbdDx1sGAJCQI7Uvf7/CS4NjWWhglqvsTVxtS94b5yLU9KKYyJ7hw IXxqidZtpjbUBZLWi37BewUeXfwugpZbQT+NsdICoaXLqGdziRLmW7tqAGc5jkcPAJCEo5 418NUMoFhZvMr1avghEnuhB7nIBAteGEG7Is3xJekOSqMkvVTjQExdUeer/PSw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633446194; a=rsa-sha256; cv=none; b=Omi5i2EesVi6c0NLApLw1K1H3rbmM5ChhcethEO41u1uAaBeFPgiKtznzVhs6Ef3pN5hIQ jfYpuStvdMd7awPv4w55ecPHOcu0lNFwSySpTQOZNk0Pul1g6qb2nqwiEirWLHqnhseBXQ QunXqsPcExSwJU+jf04uW6BK7h30NQh5uoHAzIK/HYea616OTNNe49eDL4K7njN6OzszJ6 DM2g/94aft60133x6NJKjDTiQgymNwOJDUYpLipSbrw00fNkGSp76P3kC8VgPs+ixl9kas DEveox+raO0jMZcMrkPVxb1AGCp+B2xFxN4V8moVibpNojr3AxjBwt3yRfuFHA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.81 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 110AC2B568 X-Spam-Score: -1.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: g+CLSrk02VtL On 05/10/2021 19:45, Ihor Radchenko wrote: > Max Nikulin writes: > >> Regression is caused by >> >> commit 399481bad10845a77f210c9320ff1efee9a312c8 >> Author: Ihor Radchenko >> Date: Mon May 31 20:47:45 2021 +0800 >> >> Do not ignore user-defined display-buffer-alist in org-insert-link > > See the attached fix. The fix looks reasonable, though I fail to > understand why org-no-popup was even used in org-goto-location. We kind > of want a popup there. git blame did not reveal anything useful either. Thank you, Ihor. I am a user of alternative `org-goto' interface. I have tried default one having a couple of windows in the frame (indirect buffer for subtree, indirect for src block). It seems, previous window configuration is restored correctly when `org-goto' is finished. Curiously `org-no-popup' was introduced namely for `org-goto` > commit b508943d329fed2af457c50afd5f63938b23c58c > Author: Achim Gratz > Date: Thu Dec 20 10:18:02 2012 +0100 > > org-compat: new macro org-no-popups > > * lisp/org-compat.el (org-no-popups): New wrapper macro which > let-binds the correct variables to suppress popup windows depending > on the Emacs version in use. This is a compile-time decision when > byte-compiling. > > * lisp/org.el (org-get-location, org-switch-to-buffer-other-window): > Use the wrapper `org-no-popupsĀ“ to let-bind the correct variables > for suppression of popup window To emphasize actual changes due to the patch just suggested by Ihor: git diff -b HEAD~ diff --git a/lisp/org-goto.el b/lisp/org-goto.el index 0a3470f54..352bf9f2e 100644 --- a/lisp/org-goto.el +++ b/lisp/org-goto.el @@ -203,7 +203,6 @@ When nil, you can use these keybindings to navigate the buffer: "Let the user select a location in current buffer. This function uses a recursive edit. It returns the selected position or nil." - (org-no-popups (let ((isearch-mode-map org-goto-local-auto-isearch-map) (isearch-hide-immediately nil) (isearch-search-fun-function @@ -236,7 +235,7 @@ position or nil." (use-local-map org-goto-map) (recursive-edit))) (kill-buffer "*org-goto*") - (cons org-goto-selected-point org-goto-exit-command)))) + (cons org-goto-selected-point org-goto-exit-command))) ;;;###autoload (defun org-goto (&optional alternative-interface)