From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UDuNDylJU2FJTgEAgWs5BA (envelope-from ) for ; Tue, 28 Sep 2021 18:56:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id psIRCylJU2FGUgAAbx9fmQ (envelope-from ) for ; Tue, 28 Sep 2021 16:56:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D5FFDF1AE for ; Tue, 28 Sep 2021 18:56:08 +0200 (CEST) Received: from localhost ([::1]:52032 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVGOl-0002zG-RR for larch@yhetil.org; Tue, 28 Sep 2021 12:56:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVGN2-0002wW-2j for emacs-orgmode@gnu.org; Tue, 28 Sep 2021 12:54:20 -0400 Received: from ciao.gmane.io ([116.202.254.214]:46604) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVGN0-0004QY-HT for emacs-orgmode@gnu.org; Tue, 28 Sep 2021 12:54:19 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mVGMy-0000zP-6S for emacs-orgmode@gnu.org; Tue, 28 Sep 2021 18:54:16 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] oc-csl: Add support for the text and year citation styles Date: Tue, 28 Sep 2021 23:54:05 +0700 Message-ID: References: <87fstoojam.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 2 X-Spam_score: 0.2 X-Spam_bar: / X-Spam_report: (0.2 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-2.562, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632848168; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=LXxsJLqhg6hq2SsyRvfpxx0mKM3iOvE/OWne97a00Q4=; b=rbTEluw3cMoyOWbH0Glx+Pk+V42wUDKoH31nMunlgD3lWYtVXzOjpTZNoratNawlykUY+r kULwiqS4QEZK7RlonW1StpJEVX7a98YoE31woeSpho9NGwwwHhj0WLCfeY5LR2ZfBU8SQk OuBDhLvGoS+R2q9r9iPCiVwMUxrz6z3hajLkkAuSc6fBplBkSkKkCuSG0CzVVJsoOJbe4b 6l++LlRTc7RtFuUcEGCCBF3cu3AbCTa6YskjExQ24vQg5hJBVE199U2Kbjsz2eHoOdkn7V bZZbDDiDNUQURJb+Y+vvnBjVQ/JDKTEoeTU/ECpxara5fYlon8x5AIoBCyBfWg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632848168; a=rsa-sha256; cv=none; b=qsGkM2J6rpItmlnrQVkBvU1wMV2yLCL7BBm/rMuyckSHEMMYlJ+XuyDIsJyTgWiuKkn5mA GXajaBNrJCjtaU3LgOerN+p1UScjmc7W6jj7/IdLsktQAdGfl03hTjoxKoSemLGLyolYWT O7f0sGAfakVUg07bJx3Z8pqhoVm4Uv7AgXGMmIepxX0uzCmvkyDfDP3ntUMT9pCcrOBU9j wqG9Oe/68THIS3hK68Pv05cf9YbXTfy6bp0/O8ARHMLMt+X9obXCt32VzqdX1Z+Mov+8Rr 3+bmSulk74cY24xms8/gxhod33EIiXLz8rJL9Qt7DGsdbANLAPfFY9VTLpXROA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.20 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: D5FFDF1AE X-Spam-Score: -2.20 X-Migadu-Scanner: scn1.migadu.com X-TUID: KVN0eI+Y/9df On 28/09/2021 23:39, András Simonyi wrote: > > I've attached a patch with the pcase pattern refactored following > Nicolas's example -- hopefully this solves the problem. I do not see the issue any more. No pause during compilation, reasonable file size -rw-rw-r-- 1 ubuntu ubuntu 24992 Sep 28 16:48 lisp/oc-csl.el -rw-rw-r-- 1 ubuntu ubuntu 15767 Sep 28 16:48 lisp/oc-csl.elc > On Tue, 28 Sept 2021 at 17:16, András Simonyi wrote: >> >> Thanks, I'll try to put together a patch fixing the problem and send it shortly. >> best wishes, >> András >> >> On Tue, 28 Sept 2021 at 17:03, Max Nikulin wrote: >>>> András Simonyi writes: >>>> >>>>> the attached patch adds support for the text (textual) and year >>>>> (year-only) citation styles in the CSL org-cite processor. >>> >>> This patch has a problem similar to ones earlier fixed by Nicolas: >>> https://orgmode.org/list/seomi1$785$1@ciao.gmane.io "Re: citations: rx >>> problems with emacs-26.3" Sun, 8 Aug 2021 20:34:55 +0700 >>> >>> Compiling single /home/ubuntu/org-mode/lisp/oc-csl.el... >>> >>> In toplevel form: >>> oc-csl.el:330:10:Error: Bytecode overflow >>> Makefile:59: recipe for target 'oc-csl.elc' failed >>> make[2]: [oc-csl.elc] Error 1 (ignored) >>> >>> It is for emacs-26.3 (Ubuntu-18.04 LTS bionic). Sorry for confusion, emacs-25.2 is shipped in ubuntu-18.04.