From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 3YUaIQB1S2H5QgAAgWs5BA (envelope-from ) for ; Wed, 22 Sep 2021 20:25:04 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cLoiHAB1S2HYHgAA1q6Kng (envelope-from ) for ; Wed, 22 Sep 2021 18:25:04 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C4A101A8E3 for ; Wed, 22 Sep 2021 20:25:03 +0200 (CEST) Received: from localhost ([::1]:50686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT6vV-0008OO-OO for larch@yhetil.org; Wed, 22 Sep 2021 14:25:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT606-0000SE-M0 for emacs-orgmode@gnu.org; Wed, 22 Sep 2021 13:25:46 -0400 Received: from ciao.gmane.io ([116.202.254.214]:56312) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT604-0003CB-Np for emacs-orgmode@gnu.org; Wed, 22 Sep 2021 13:25:41 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mT5uC-0007HQ-VJ for emacs-orgmode@gnu.org; Wed, 22 Sep 2021 19:19:36 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] ox.el: add smart quotes for Greek Date: Thu, 23 Sep 2021 00:19:30 +0700 Message-ID: References: <87bl4omst8.fsf@posteo.net> <279c8d6d-ebcf-2149-416d-c75bdf227f05@gmail.com> <874kad1y12.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <874kad1y12.fsf@posteo.net> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632335104; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Kw19nUKFTsKnGOCNA0jTXxGquv/rPL1t6ac0Q9gbDbI=; b=W7da4vi+hj5XYSktLMoGSmF/faawbn56mKGDjuWmYNbDJNgG8l7dAkhazFln3DXc78/XbG xJ0dDlcR05L1Uhl+lrs3ti1ZjRC6PyCFweP/ZrIezzz7VehY/La9qZTFpu2X8s8DqkW2yt fsUKzM3keHe0ag6Hp5mb9KtKv+6sT5+xSH6h7Ce9BfgYtx9oeE1u9i6chmFO6byfuoCfpd 1iFFgUwfYxLOW8vcTlp2HsFbzZDL4vq3sbe8j4qkU3nKeWdh8UbQ9NgGyOm+ARBey0/A55 IwSfWlhcOmL/cGhSBfUGKbAXa+LiK0JVGmrSNVSlw01h+xgEZZflRfPymK4IHw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632335104; a=rsa-sha256; cv=none; b=Dh7FSuI0r9G8d3yHbXs5gbhmFb3XTWzPKgMLq2rjIjcc1y+FpaHa6m2T+HMU5cxPLZ9lIa aV3kOthTC/wM9Jj8b2Dl77enMOXASky/3iuEjRIeXi6YqmKJclhgQ8cgraXa4FLCDxyfEJ LAZqxNC2xQPO/NcdOIfKVz7XwAZxRfRHGeCi/DWUquCZ2HFhWlGNMPkuuKQ/T+j2zBEKT0 q59cR29Q4Eov/abPb2mPSli+xCRzX9u1wCmSmrMtGfEkqiKZ6SGUJXRXcvpSSGA9XUY7Ex l7TBdUcBf3vV2EfKyTm3YCI1sPHAD2NAa0psW+CUlWHU91SoBycu5C7dLCiyOw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.79 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: C4A101A8E3 X-Spam-Score: -1.79 X-Migadu-Scanner: scn0.migadu.com X-TUID: S8dN5n5PGPeo I believe, the patch is an improvement. It would be nice to have a comment clarifying the choice of secondary opening quote mark, but it is not required. It seems there is no recommendations or established practice for documenting of such decisions. I have not tested the patch though. > -`org-export-smart-quotes-alist' and `org-export-dictionary'. > +`org-export-smart-quotes-' and `org-export-dictionary'. It it intentional change? I have not found other variables having the same prefix. On 22/09/2021 03:20, Juan Manuel Macías wrote: >> [...] >> Possible options: >> - Add the note directly to the .el file. I am afraid, as inline >> comment it could be considered too long. >> - To a file in the "doc" directory dedicated to such decisions (there >> is no such file yet however) with a reference from the .el file. >> - Commit message. It is acceptable but not apparent for a person who >> reads the code that git log may provide detailed explanation of >> particular choice. > ... > Haralambous is a great TeX guru, and a great scholar and theorist of > Greek typography, but... I would say that in this case his mind is more > focused on a historical tradition probably abandoned before the digital > age. That character could get better support in future. I know, such chance is almost improbable, but imagine, a person familiar with the paper of Haralambous would consider change of the quote mark in question believing that Org developers were not aware of the "right" symbol. A comment in the source code may provide a hint that the choice was conscious. I forgot to mention it in my message from 2020-08-15 that I did not find the U+201F character in TeX pre-unicode LG* encodings for Greek.