From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wDoTJLNAGWGReQAAgWs5BA (envelope-from ) for ; Sun, 15 Aug 2021 18:28:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id cGWwH7NAGWFNBwAAB5/wlQ (envelope-from ) for ; Sun, 15 Aug 2021 16:28:35 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EEE877639 for ; Sun, 15 Aug 2021 18:28:34 +0200 (CEST) Received: from localhost ([::1]:38438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFIzw-0004Nd-Hj for larch@yhetil.org; Sun, 15 Aug 2021 12:28:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFIzB-0004NP-O9 for emacs-orgmode@gnu.org; Sun, 15 Aug 2021 12:27:45 -0400 Received: from ciao.gmane.io ([116.202.254.214]:40476) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFIz9-0003Fe-Vz for emacs-orgmode@gnu.org; Sun, 15 Aug 2021 12:27:45 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mFIz7-0007N9-Kv for emacs-orgmode@gnu.org; Sun, 15 Aug 2021 18:27:41 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Maxim Nikulin Subject: Re: org-attach-sync uses directory-empty-p (new in Emacs 28) Date: Sun, 15 Aug 2021 23:27:35 +0700 Message-ID: References: <87pmun8t2o.fsf@kyleam.com> <87lf593tv0.fsf@gmail.com> <9dd6d3bf-46cc-31a2-aead-3af7d53e741c@gmail.com> <87lf57y92w.fsf@gmail.com> <87wnonjcmc.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <87wnonjcmc.fsf@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 7 X-Spam_score: 0.7 X-Spam_bar: / X-Spam_report: (0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-2.147, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1629044915; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=sEeuRWojI/mKF2T04ulkHATT8lECown3jzUCROmpIDI=; b=UWOad/ELnX6hY19WPmExLTBRN0+HNsulAQQf34PIJSNhAX2FN7uAsjWjx1aBlD2OgtXH/M xeigUyNzk02hBwFqf2+76RWzoVg9W9T34W4NfUEz2KDNgq1CfS/uIMR65c+0CA5V4iUK7E uju8wcG2av9mBzsryLVV5OfPQGpX2l+6sdzKXgk9OqUPzDorW/sr2mYuuY5KiYrOUZ9fNy OA4A+gRrxifsLcCM1Ve2MdK4GBCh+jBD9ANER6+edyVmg4XJfl6TlwU2W0hA6ArJW8OxRT aygiIHzliJ+sudoCWFNEoWaHLaPo3sO88Ynm5RkUrbNnP7Cv4TJqsiVw2WHPuQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1629044915; a=rsa-sha256; cv=none; b=bKkOG6Z1UFJzyj1slruCeW2ZPv+oaIbo8WL96/uCml6c4pUbXjC1fvtXmSVK5sKKBQ1iBE wN79vIg098ZKQ4MJTv6FxHSzBuV/nco5mw41XjGGg4Nhlqvg6tt7GvHj7SO3VKyXVRuCK0 OWgd5TpyrB/ARof/AuuCy3UMmMACfxhi0UTPyAiUBtW7mzGHa0avrpgBPdM+/hk+nRY6lk L/Qi9ejWQnXHaftGP/pzDi2+8TUw7PHuTl5MT3cnjkG/LzoJ+2v6RiUJS3W/WaX1Sf/1N9 5mNxzOIrBmYKLpWbNTe37vfDVzDy4NBFfT5DTRLxrzQyxL0cQZiDM2R96ohj/g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.81 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: EEE877639 X-Spam-Score: -1.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: KQO0ac23SF0F On 15/08/2021 16:11, Marco Wahl wrote: > Maxim Nikulin writes: > >>>> Compiling single /home/ubuntu/org-mode/lisp/org-compat.el... >>>> >>>> In end of data: >>>> org-compat.el:1255:1:Warning: the function ‘directory-empty-p’ is not >>>> known to >>>> be defined. > >> I have never fought with this kind of problem. After looking at the >> other constructs in the org-compat.el file, I have tried >> >> (if (fboundp 'directory-empty-p) >> (defalias 'org-directory-empty-p #'directory-empty-p) >> (defun org-directory-empty-p (dir) >> ; ... > > The latter suggestion landed in master a few minutes ago. Thank you. The warning has disappeared for current master HEAD and Emacs-25.2. Maybe a brief comment in org-compat.el clarifying usage of version comparison vs. `fboundp' would be helpful to avoid similar issues in future. E.g. I am unsure concerning simple < vs. version< (whether attempt of version check could cause a compatibility issue). Fortunately latest change does not use any of them.