From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MY5ML94MFWFcngAAgWs5BA (envelope-from ) for ; Thu, 12 Aug 2021 13:58:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id mLUoKt4MFWF0eQAAB5/wlQ (envelope-from ) for ; Thu, 12 Aug 2021 11:58:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 24DE2198EF for ; Thu, 12 Aug 2021 13:58:22 +0200 (CEST) Received: from localhost ([::1]:47222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mE9Lo-0000Zl-A4 for larch@yhetil.org; Thu, 12 Aug 2021 07:58:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mE9LI-0000Yv-2F for emacs-orgmode@gnu.org; Thu, 12 Aug 2021 07:57:48 -0400 Received: from ciao.gmane.io ([116.202.254.214]:52042) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mE9LG-0005d6-4U for emacs-orgmode@gnu.org; Thu, 12 Aug 2021 07:57:47 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mE9LC-0002Qv-3p for emacs-orgmode@gnu.org; Thu, 12 Aug 2021 13:57:42 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Maxim Nikulin Subject: Re: org-attach-sync uses directory-empty-p (new in Emacs 28) Date: Thu, 12 Aug 2021 18:57:35 +0700 Message-ID: References: <87pmun8t2o.fsf@kyleam.com> <87lf593tv0.fsf@gmail.com> <9dd6d3bf-46cc-31a2-aead-3af7d53e741c@gmail.com> <87lf57y92w.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <87lf57y92w.fsf@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628769502; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=PB0sjpNhDHOxYYLU8XOogyC78DUI5oPrIefZW2cPtXs=; b=HN6R5n6QFEKybDSLhlI8VE7ScMhvW2LKDFvkJi6sXBlCPIqERrNhR5AO0sRlTzmQtW3fB7 XJpHdXc/m+2OI9LVyeKnpWL34XolwEPOMQ8UMrgjWcBdMTDq1g9qGp0Popx/galr9D/Fto op+EAhro0feLo8DwDaDrvBk8ehTNTSs2BnRLJTcxP1FJf6A0GkQoDdVtwUKEodnTDbv0qI bi/0mJ5L7vOjy+IhfhiWJUWUH3CtqsucKx6/s3iN/1XUte6mRwtllo8xr4InQ9ZAgYJk/R hXhjMLJgOyxJwc/269q/t27cSGrFkYmA6qSkcCsaHowJhmKmq5cNziHatduYKQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628769502; a=rsa-sha256; cv=none; b=PMvK4NP8v4oWTVGCPY/OmcuMkwGS8FEolu9bVVmtii39e4XbAqT29bhHzJl+5YAbpsr1af JJePD0JSPzS/l1dFw9yEdsdRnwtQqoJysVRNN3BRRbmx2QC3qWRIJ0N6TJCBF1oVOu3vMw tX/cjWPuad0EEs8TusqFo5j9sf7L9WhQyhnoZcdq5bjOJXenApMoDBjoEI8ItfBBsFoj4D 75+Pwja7YrX7FaZ26mXKgCbsDG5of/TW2f5F1BteM2cv6f88BIJ+MgDJuV/qk3h3kCJRQg qZ1lxVmSXXfwBcI9vSqJuoqIAwKVIsYPb1UYUZvZOQ3jt2WuXYObXkbtWUThaw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -0.31 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 24DE2198EF X-Spam-Score: -0.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: stAiObnX1GpX On 12/08/2021 04:17, Marco Wahl wrote: > Maxim Nikulin writes: >> >> Compiling single /home/ubuntu/org-mode/lisp/org-compat.el... >> >> In end of data: >> org-compat.el:1255:1:Warning: the function ‘directory-empty-p’ is not >> known to >> be defined. ... > > How make the compiler happy? I have never fought with this kind of problem. After looking at the other constructs in the org-compat.el file, I have tried (if (fboundp 'directory-empty-p) (defalias 'org-directory-empty-p #'directory-empty-p) (defun org-directory-empty-p (dir) ; ... I have no idea if there are any drawbacks of such approach, I can only say that such form suppresses the warning. It seems, version comparison is sensible when an existing function gets new arguments, not in the case of completely new function.